From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0071.outbound.protection.outlook.com [104.47.37.71]) by dpdk.org (Postfix) with ESMTP id 995D81B1EC for ; Fri, 6 Oct 2017 18:22:58 +0200 (CEST) Received: from BN6PR03CA0001.namprd03.prod.outlook.com (10.168.230.139) by CO2PR03MB2358.namprd03.prod.outlook.com (10.166.93.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 6 Oct 2017 16:22:56 +0000 Received: from BY2FFO11FD016.protection.gbl (2a01:111:f400:7c0c::119) by BN6PR03CA0001.outlook.office365.com (2603:10b6:404:23::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Fri, 6 Oct 2017 16:22:56 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD016.mail.protection.outlook.com (10.1.14.148) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 6 Oct 2017 16:22:55 +0000 Received: from [10.214.249.140] ([10.214.249.140]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v96GMqIF029481; Fri, 6 Oct 2017 09:22:53 -0700 To: Thomas Monjalon , References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> <2584395.73f1Oakct5@xps> CC: From: Hemant Agrawal Message-ID: <1afffe26-d574-0c6d-6101-836aaca1a37b@nxp.com> Date: Fri, 6 Oct 2017 21:52:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2584395.73f1Oakct5@xps> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131517805756633038; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189002)(377454003)(24454002)(199003)(81166006)(498600001)(47776003)(23746002)(53936002)(33646002)(6246003)(31686004)(106466001)(356003)(54356999)(53546010)(105606002)(76176999)(305945005)(50466002)(31696002)(77096006)(189998001)(97736004)(50986999)(68736007)(36756003)(65956001)(64126003)(2906002)(83506001)(229853002)(8936002)(230700001)(8676002)(65806001)(86362001)(58126008)(316002)(5660300001)(69596002)(65826007)(104016004)(110136005)(85426001)(81156014)(2950100002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2358; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD016; 1:qXUM3oYvIAfsmLneh3FslpVURiB5/Jnsmw5Umz2RAUNuNUUHTFdAba9sG1m2BC72xRVJW9VR1YrWtYmnLuSi0r1ATi3tvEWLBvqr+zNLpN/6qIFsUEdEZxnPSLza+CCf X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 940a8f3b-d040-4514-4fce-08d50cd6803a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2358; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 3:LrL+VwBoNRDlPZPY3otc7/gn0RZptC/bYbz2J2XEqq51EZU4+Sf0JSU9135oDYvH8JX/Fs7doiZzcTs9Ef3YCxEtC5jXKogK/TLM7ORi4gm1IXjH52rwudKTnRYrZqeYhOaJyq4/Ns49WbO5WamPzGDw6MTiM3rQ8m1xRVcRYzQBLXRxEg2qiLvfqfNyKcaGk05vo3ntAirmiP9D/mtF/qczXzKudiMoFqI7sDSAi9W8IiQ/DMnCPSLLM3FE/lqYhGZnXhJaIkef9kVblf/o4iYy8lC9g0PXb/ejDGf6wTKdbRF3N7gJo4UsE5qq42ohIHV9x2vGIJWQk7M7Kevk1g==; 25:nQsJQQBreQeOZ86vNainBvtB2PFlFFFb9UGwWbE4PgyqZeecctvbgp6+PLSvfVDAvk+/oGgcGH3vC267nmsL3dITfFRelCGxJM7semyGrF/aZ52YNU8ofqzGa9tmlw0+yPGa31tFiRwW+Ry2xuZ8z9ruwfJP5CfaXYk7wRwCgWdSFu2WHNIxA127Fn8g4vF1Jy9Z5oc934+r7my+E+Jh8UqvPnQ8m3YiXsx1Zhah5NL9vNyQdJYItcNvrrodimAv3kyR02eBYvwSeoQ0Ylct/VtPkvg0e8IuZxITb3VO9csB9zGv1XTYdoZIuoKShB11C5fkDbBob2PCTntARZERjA==; 31:HkXGLUCOhjb457tKtMfjGFLr204bIDieMq1qfJ77lKbXQNQEglm11tNWKtGSVgRaRv8SCcHI5QNYeF/cDSovJRkbORhxvUW9PnUMV1nRsgJcqTNSINLDN+v+K8E0xFHF+CHPEGmFHFpNZpOQqiB0MpfWOLIlZo7sC5bwHS4VzCGtXmHonUMW3XtCqL5CU9yvtLauJ0BrJ3b4jXaGY3IbYVSOr8YWD8i+u8XWreJrUm8= X-MS-TrafficTypeDiagnostic: CO2PR03MB2358: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123559100)(20161123556025)(20161123561025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2358; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2358; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 4:ZIrx05reAR8ohugmqIHfHazmQphL07oCFwxAoG90pfYV9ADXZ98i78I5V48iyKiFfIaUFlymRXIeSv6bbKV2kViHY9EBNyDuRFUibG9jO90K5dbgfCoDdz5n3jWK1OM9cQ5coNjiCUOBhbi4C/Ub6LwodkJbn+GDOOgYWedCl0Gi5wIA8G0W3ANTbRhKCx2mJyf8hoGCHbSL6mDsECe1G1JmjNacXIvQmnqZID8ZyxBCcKkEA4ra8BevbKlL/GsZ7cxn3EUJPsgvIzOTeD0SPzwsB3B6Msk+y9pYFDN06ZU= X-Forefront-PRVS: 0452022BE1 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR03MB2358; 23:lHh475/iwBIW/xIjecYCL8C/9hZizGq5739LU?= =?Windows-1252?Q?9IerUHp3efoFgZffXoUxyhqXzquknzpHKUYddrC5xKpl7N1aCkEWlv15?= =?Windows-1252?Q?GaRYk/0rNuSNZxw31reauIK8sC5hYdecy6Bt3ieT5SJbbIzHRlVplFWI?= =?Windows-1252?Q?yi/LHsK/F7vNtDlP4zLoM1MEuc3PpMg1kg1IV3A0PRQuTSkZG2a2d/Ec?= =?Windows-1252?Q?TL05xE36/Eyxfx/hGLQVzPgInNVQRzSXCeZz12ak5G6CRt/kY+IPtWRv?= =?Windows-1252?Q?IUPdWjH8NkFiHit5MEXGRFNjzApDG/2ds2G+bJzE0413HzGmk0wrS9bI?= =?Windows-1252?Q?WqYbc66iPfRj8Ha1MBnRX7RUyUBloX0s/JLCKwYFIll8pFzry0yxCpRX?= =?Windows-1252?Q?IKrHpxu5Vt/Y8gR37dkgfd+DpK0N6eRWk94AGprZusen3/Y7bx1KAEoh?= =?Windows-1252?Q?TUilcCXl8sQ90KbUFTkskpWbc6dVy54F4loyykOJMr477oLw7RnzaKvf?= =?Windows-1252?Q?b3Ei/ugIp8rbix+n//bqW7x10tfbc2avehQ8+olPwjNb715hca68Wnse?= =?Windows-1252?Q?9c+0qRILKVCBYsm9j249e0dezxQVb2hTywcvkb4YZLS2/+OSw1HDp2TZ?= =?Windows-1252?Q?AyGC0QYu52JRCzaXPF6A8djE5365ucoZ0BI63hXG7e07rGSOS7qpvFRw?= =?Windows-1252?Q?/gMkIye7qiOu8IParTSr1gmvn66lOYaHRTOXxk3SH6MVzSsPe+iuiGhZ?= =?Windows-1252?Q?x3I7JgVS/o7UGxpgzmlCPHAO8CLndrha0FWWUGzk5RhMJTkvvd8vv8KG?= =?Windows-1252?Q?pXVJw1Bas0dQp+bVIlQsVgbNSt33+l7P4f/JAVPgDErATC6Dq13BY/or?= =?Windows-1252?Q?YVLSLPHyB5BtNttsDgX289y6cSZTBU0JCU0khnHYeGr1vRWiNOnQ54oO?= =?Windows-1252?Q?t1ngwugdvdTM8FC0iU/0JsHS/4tv8sc5RYTQP/DpW/v/KAedEBGcwMsq?= =?Windows-1252?Q?iEaMWaNJRKOIpO8o2n14CQSGiPJyHy2vSYSKxqAjTbnU28f8EdwjGm+z?= =?Windows-1252?Q?Sf+NjzgyQqimTKu1lpGcjqo4sZjjcigyBJT3mQ1wx5PeypB9os9Gp5Yp?= =?Windows-1252?Q?pPQVKik0DotKqbf3OKrD90eq0IxMriVdWZ1MKmSR6X693qmoD81Pb3XX?= =?Windows-1252?Q?hbzuFV1CqXhJ/+WgshPeZsjMRmEOl6/LpsU3gNfuQ+fl2SRrsETxzOCz?= =?Windows-1252?Q?9Cz0eH3O7h+uQVno7mHNQkFn0zDOGb8dfPG/Vdkny8a4JstlVc0QjjGJ?= =?Windows-1252?Q?KjrPGAe6Lkprf42jix7/9rgLmy7ruU/Ga09Im7Sgll7FeOMo2Qer+PHY?= =?Windows-1252?Q?v0VkJAkLCF2sf713iSW44F+KFWxlTpycBG9SEvoY9vsNSr+L6G3hcvFG?= =?Windows-1252?Q?Eyrle4cj5i6pRZrhtMbqRLbJEwzOaWdkeuD0ue0bVHt23MjCONEBfRw2?= =?Windows-1252?Q?dICNqw=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 6:4MHD6Gw8PM7m2O9G6DBWNSOuVbujdm3utBQpDM/sQjMMG6wRAS9VZbCBQN9of8w9TIfJoNl3VOspe9HUXEqmADgHzCI9oQA9lItz/LS+WV6RY9f5FlDiBf6Cyoh6GQpRwrH4LMSa3VnfGKeLfrtNCPAydmMK2AeLg/429fgIpmonAymOWHz4IEgs/Kw1QUkq7ByeLv2A4rxaq2PIXec5zkRfpulPU0wax2YL2qKd2O8kcoKiwC55CF/y9kHEtliGQIJ8rg+ieG8dimqQ1XqSExseAloRUeCbKsZA5Z/FplAgO+sENRgI+qGwrN3x6Tit9277Lv6Mbq7AWpDVjumK7Q==; 5:sEW4EqZ1YCvq6xV01tNhiHk7dhxoT/YqVbwDjgpsHsOhowlaXZ0E0DMePdBgDbIfDk2zvaC4Ox0V7yTxFn83eo+hTOcQ2zHMQj1Yi3RalMSDlt4NZAzD1NphyEoyNjpbBnRs1wh9TN3xLAXPb8ufng==; 24:u7MoPZLSdCJ5D+cMBwJALle0EykO7dJGE+RnlhNIJGoxPGY4wDix1+Al9v42eBh2TSOU3TM4aF3Jywr+29Surb3u8EFoUpEdi3ekME0cA8c=; 7:wYMd2XzRjYSbRmC2BO8v/hH6NMBNUS5rg464Ba3g0EZbdh70jH3FziQKpcbUOaFaiNYSKq5zxGQ/YYReGxweweVSMejrtPMJkk4r+H4rNJHCf0/boUfNMAvK64yvnwdYRQx290/h0R6oShpfsuqFXAE4RNl4RtAz8UJ7uV3qKS8DI0SuUBNyAojQu8hnH0yL14gOVJOf45Cr3O63Iv9BUXqNjs1KcegAg8gpl/06C0Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2017 16:22:55.5541 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2358 Subject: Re: [dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 16:22:59 -0000 On 10/6/2017 5:11 AM, Thomas Monjalon wrote: > 13/07/2017 13:48, Hemant Agrawal: >> In case no_pci is configured, fslmc bus will still need the >> the vfio to be enabled. >> >> Signed-off-by: Hemant Agrawal >> --- >> --- a/lib/librte_eal/linuxapp/eal/eal.c >> +++ b/lib/librte_eal/linuxapp/eal/eal.c >> +#ifdef RTE_LIBRTE_FSLMC_BUS >> + if (!vfio_enabled) { >> + if (!vfio_enable("vfio_fsl_mc")) >> + vfio_enabled = 1; >> + } >> +#endif > > It seems to be a hack. > VFIO is not only PCI. > Why --no-pci is impacting VFIO? > > Anatoly? > At present there are only 2 users of VFIO. PCI and fsl-mc bus. One options is that we always enable vfio irrespective of --no-pci flag. My believe is that vfio-pci will be present in most system supporting any other flavor of vfio (platform, fsl-mc etc). The other option is what I proposed. i.e. if vfio is not already enabled the platform is FSLMC bus, enable it. regards, Hemant