From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FA66A04BC; Fri, 9 Oct 2020 23:01:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A54B1D542; Fri, 9 Oct 2020 23:01:47 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BFBA51D525 for ; Fri, 9 Oct 2020 23:01:44 +0200 (CEST) IronPort-SDR: 2xalvYLVty9O6daY22PGA0EK0yJRTmyYHmBH754dG8vC1IkfTBDNpYaf/uUZnAVxqaSFX8DB2n nfVVzrcXkWGw== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="164749475" X-IronPort-AV: E=Sophos;i="5.77,356,1596524400"; d="scan'208";a="164749475" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 14:01:42 -0700 IronPort-SDR: iYP4wo/zKzyOmKmUJ/2pe50NvYFnajuEuv01gcZsxCDJlQs5OwSWubOtZZhulTO/3pVSb91oMx brzbEI2GHrIA== X-IronPort-AV: E=Sophos;i="5.77,356,1596524400"; d="scan'208";a="462316602" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7]) ([10.252.18.7]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 14:01:41 -0700 To: Kevin Traynor , Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com References: <20201007214848.249516-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <1b2fba84-97bb-8362-7fc5-a814690290ce@intel.com> Date: Fri, 9 Oct 2020 22:01:39 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/2020 10:10 AM, Kevin Traynor wrote: > On 07/10/2020 22:48, Thomas Monjalon wrote: >> As described in doc/guides/prog_guide/poll_mode_drv.rst, >> the naming scheme for the xstats is parts separated with underscore: >> * direction >> * detail 1 >> * detail 2 >> * detail n >> * unit >> where detail 1 can be "q" followed with a queue number. >> It means the name of the stats per queue should be rx_qN_* or tx_qN_*. >> >> The second underscore was missing so far. >> Fixing the basic xstat names may be considered an API change, >> that's why it should not be backported. >> >> While fixing this mistake, some examples of the naming scheme >> are given as part of the API documentation of rte_eth_xstat_name. >> More proposals about standardizing statistics: >> http://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf >> >> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids") >> >> Signed-off-by: Thomas Monjalon >> --- > > Acked-by: Kevin Traynor > Applied to dpdk-next-net/main, thanks.