From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
by dpdk.org (Postfix) with ESMTP id A5EE32B82
for <dev@dpdk.org>; Thu, 29 Mar 2018 15:19:47 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
[10.11.54.5])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 187C2401DEB5;
Thu, 29 Mar 2018 13:19:47 +0000 (UTC)
Received: from [10.36.112.54] (ovpn-112-54.ams2.redhat.com [10.36.112.54])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 694128444A;
Thu, 29 Mar 2018 13:19:45 +0000 (UTC)
To: zhiyong.yang@intel.com, dev@dpdk.org
Cc: jianfeng.tan@intel.com, zhihong.wang@intel.com, thomas@monjalon.net,
dong1.wang@intel.com, tiwei.bie@intel.com
References: <20180214145330.4679-1-zhiyong.yang@intel.com>
<20180321030343.64399-1-zhiyong.yang@intel.com>
<20180321030343.64399-5-zhiyong.yang@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <1b93fd09-9802-bff7-bea4-5b4839860983@redhat.com>
Date: Thu, 29 Mar 2018 15:19:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180321030343.64399-5-zhiyong.yang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.11.55.6]); Thu, 29 Mar 2018 13:19:47 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
Thu, 29 Mar 2018 13:19:47 +0000 (UTC) for IP:'10.11.54.5'
DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH v3 4/4] net/vhost: add NULL pointer checking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 13:19:48 -0000
Hi,
On 03/21/2018 04:03 AM, zhiyong.yang@intel.com wrote:
> When vhost user PMD works in client mode to connect/reconnect virtio-user
> with server mode, new thread sometimes may run to new_device before
> queue_setup has been done, So have to wait until memory allocation is
> done.
>
> Release note is updated in the patch.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> doc/guides/rel_notes/release_18_05.rst | 7 +++++++
> drivers/net/vhost/rte_eth_vhost.c | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst
> index 3923dc253..7b301f021 100644
> --- a/doc/guides/rel_notes/release_18_05.rst
> +++ b/doc/guides/rel_notes/release_18_05.rst
> @@ -41,6 +41,13 @@ New Features
> Also, make sure to start the actual text at the margin.
> =========================================================
>
> +* **Added support for virtio-user server mode.**
> +
> + In a container environment if the vhost-user backend restarts, there's no way
> + for it to reconnect to virtio-user. To address this, support for server mode
> + is added. In this mode the socket file is created by virtio-user, which the
> + backend then connects to. This means that if the backend restarts, it can
> + reconnect to virtio-user and continue communications.
I think this shouldn't be part of this patch.
>
> API Changes
> -----------
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 3aae01c39..2490bad0b 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -580,6 +580,15 @@ new_device(int vid)
> eth_dev->data->numa_node = newnode;
> #endif
>
> + /* The thread may run here before eth_dev->data->rx_queues or
> + * eth_dev->data->tx_queues have gotten valid memory, so have to
> + * wait until memory allocation is done.
> + */
> + while (!eth_dev->data->rx_queues ||
> + !eth_dev->data->tx_queues) {
> + usleep(1);
> + }
> +
> for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
> vq = eth_dev->data->rx_queues[i];
> if (vq == NULL)
>
I don't like the idea of polling here.
It looks like Junjie is addressing the problem in a different way [0],
do you confirm it would work in your case?
Thanks,
Maxime
[0]: http://dpdk.org/dev/patchwork/patch/36643/