* [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability
@ 2018-04-10 6:17 Ophir Munk
2018-04-24 12:49 ` Ferruh Yigit
2018-04-24 13:11 ` Gaëtan Rivet
0 siblings, 2 replies; 5+ messages in thread
From: Ophir Munk @ 2018-04-10 6:17 UTC (permalink / raw)
To: dev, Gaetan Rivet; +Cc: Thomas Monjalon, Olga Shern, Pascal Mazon, Ophir Munk
Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
The net result of failsafe Tx capabilities is the logical AND of Tx
capabilities among all failsafe sub_devices and failsafe own default
capabilities.
Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
drivers/net/failsafe/failsafe_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 057e435..e33821a 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -81,7 +81,8 @@ static struct rte_eth_dev_info default_infos = {
DEV_TX_OFFLOAD_MULTI_SEGS |
DEV_TX_OFFLOAD_IPV4_CKSUM |
DEV_TX_OFFLOAD_UDP_CKSUM |
- DEV_TX_OFFLOAD_TCP_CKSUM,
+ DEV_TX_OFFLOAD_TCP_CKSUM |
+ DEV_TX_OFFLOAD_TCP_TSO,
.flow_type_rss_offloads = 0x0,
};
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability
2018-04-10 6:17 [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability Ophir Munk
@ 2018-04-24 12:49 ` Ferruh Yigit
2018-04-24 13:11 ` Gaëtan Rivet
1 sibling, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-04-24 12:49 UTC (permalink / raw)
To: Ophir Munk, dev, Gaetan Rivet; +Cc: Thomas Monjalon, Olga Shern, Pascal Mazon
On 4/10/2018 7:17 AM, Ophir Munk wrote:
> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> The net result of failsafe Tx capabilities is the logical AND of Tx
> capabilities among all failsafe sub_devices and failsafe own default
> capabilities.
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability
2018-04-10 6:17 [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability Ophir Munk
2018-04-24 12:49 ` Ferruh Yigit
@ 2018-04-24 13:11 ` Gaëtan Rivet
2018-04-24 14:17 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Gaëtan Rivet @ 2018-04-24 13:11 UTC (permalink / raw)
To: Ophir Munk; +Cc: dev, Thomas Monjalon, Olga Shern, Pascal Mazon
Hi Ophir,
On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> The net result of failsafe Tx capabilities is the logical AND of Tx
> capabilities among all failsafe sub_devices and failsafe own default
> capabilities.
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index 057e435..e33821a 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -81,7 +81,8 @@ static struct rte_eth_dev_info default_infos = {
> DEV_TX_OFFLOAD_MULTI_SEGS |
> DEV_TX_OFFLOAD_IPV4_CKSUM |
> DEV_TX_OFFLOAD_UDP_CKSUM |
> - DEV_TX_OFFLOAD_TCP_CKSUM,
> + DEV_TX_OFFLOAD_TCP_CKSUM |
> + DEV_TX_OFFLOAD_TCP_TSO,
> .flow_type_rss_offloads = 0x0,
> };
>
> --
> 2.7.4
>
Thanks,
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability
2018-04-24 13:11 ` Gaëtan Rivet
@ 2018-04-24 14:17 ` Ferruh Yigit
2018-04-24 14:19 ` Gaëtan Rivet
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2018-04-24 14:17 UTC (permalink / raw)
To: Gaëtan Rivet, Ophir Munk
Cc: dev, Thomas Monjalon, Olga Shern, Pascal Mazon
On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> Hi Ophir,
>
> On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
>> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
>> The net result of failsafe Tx capabilities is the logical AND of Tx
>> capabilities among all failsafe sub_devices and failsafe own default
>> capabilities.
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Hi Gaetan,
My bad that I confused the maintainer for the PMD, that is why it went in
without waiting your ack, sorry about that.
I will update commit to add your ack.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability
2018-04-24 14:17 ` Ferruh Yigit
@ 2018-04-24 14:19 ` Gaëtan Rivet
0 siblings, 0 replies; 5+ messages in thread
From: Gaëtan Rivet @ 2018-04-24 14:19 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Ophir Munk, dev, Thomas Monjalon, Olga Shern, Pascal Mazon
On Tue, Apr 24, 2018 at 03:17:31PM +0100, Ferruh Yigit wrote:
> On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> > Hi Ophir,
> >
> > On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
> >> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> >> The net result of failsafe Tx capabilities is the logical AND of Tx
> >> capabilities among all failsafe sub_devices and failsafe own default
> >> capabilities.
> >>
> >> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> >
> > Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>
> Hi Gaetan,
>
> My bad that I confused the maintainer for the PMD, that is why it went in
> without waiting your ack, sorry about that.
>
> I will update commit to add your ack.
No problem, it was mostly to confirm that including this was ok.
Regards,
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-24 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 6:17 [dpdk-dev] [PATCH v1] net/failsafe: add TCP TSO default Tx capability Ophir Munk
2018-04-24 12:49 ` Ferruh Yigit
2018-04-24 13:11 ` Gaëtan Rivet
2018-04-24 14:17 ` Ferruh Yigit
2018-04-24 14:19 ` Gaëtan Rivet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).