From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B12132C1A for ; Tue, 21 Mar 2017 17:04:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490112297; x=1521648297; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=j51iO08aJ++Bgbt+RrcnfcsbxpH4Z6r8GsdkDnZBK7U=; b=VewBM/cJF2j4y7txHm/RHT1hb0wr5gF3x2IbpHfzacxHC2YZiISFXCOG fc4lScR+wC9g7lACtP28qSUhb2TIRw==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 09:04:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,200,1486454400"; d="scan'208";a="79461347" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 21 Mar 2017 09:04:00 -0700 To: Keith Wiles , dev@dpdk.org References: <20170307223918.33906-1-keith.wiles@intel.com> <20170321151212.53854-1-keith.wiles@intel.com> Cc: declan.doherty@intel.com From: Ferruh Yigit Message-ID: <1ba53431-9333-66a7-22bc-5b65967dcc19@intel.com> Date: Tue, 21 Mar 2017 16:03:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321151212.53854-1-keith.wiles@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] net/bonding: reduce slave starvation on rx poll X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 16:04:58 -0000 On 3/21/2017 3:12 PM, Keith Wiles wrote: > When polling the bonded ports for RX packets the old driver would > always start with the first slave in the list. If the requested > number of packets is filled on the first port in a two port config > then the second port could be starved or have larger number of > missed packet errors. > > The code attempts to start with a different slave each time RX poll > is done to help eliminate starvation of slave ports. The effect of > the previous code was much lower performance for two slaves in the > bond then just the one slave. > > The performance drop was detected when the application can not poll > the rings of rx packets fast enough and the packets per second for > two or more ports was at the threshold thoughput of the application. > At this threshold the slaves would see very little or no drops in > the case of one slave. Then enable the second slave you would see > a large drop rate on the two slave bond and reduction in thoughput. > > Signed-off-by: Keith Wiles Acked-by: Declan Doherty Applied to dpdk-next-net/master, thanks.