DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Pradeep <pradeep@us.ibm.com>,
	Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH v7 8/9] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
Date: Thu,  8 Sep 2016 22:18:10 +0530	[thread overview]
Message-ID: <1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1473349652.git.gowrishankar.m@linux.vnet.ibm.com>
In-Reply-To: <cover.1473349652.git.gowrishankar.m@linux.vnet.ibm.com>

From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>

This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu
core map in powerpc with SMT off. cpu_core_map_compute_linux currently prepares
core mapping based on file existence in sysfs ie.

/sys/devices/system/cpu/cpu<LCORE_NUM>/topology/physical_package_id
  /sys/devices/system/cpu/cpu<LCORE_NUM>/topology/core_id

These files do not exist for lcores which are offline for any reason (as in
powerpc, while SMT is off). In this situation, this function should further
continue preparing map for other online lcores instead of returning with -1
for a first unavailable lcore.

Also, in SMT=off scenario for powerpc, lcore ids can not be always indexed from
0 upto 'number of cores present' (/sys/devices/system/cpu/present). For eg, for
an online lcore 32, core_id returned in sysfs is 112 where online lcores are
10 (as in one configuration), hence sysfs lcore id can not be checked with
indexing lcore number before positioning lcore map array.

Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
---
 examples/ip_pipeline/cpu_core_map.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/examples/ip_pipeline/cpu_core_map.c b/examples/ip_pipeline/cpu_core_map.c
index cb088b1..dd8f678 100644
--- a/examples/ip_pipeline/cpu_core_map.c
+++ b/examples/ip_pipeline/cpu_core_map.c
@@ -351,8 +351,10 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)
 			int lcore_socket_id =
 				cpu_core_map_get_socket_id_linux(lcore_id);
 
+#if !defined(RTE_ARCH_PPC_64)
 			if (lcore_socket_id < 0)
 				return -1;
+#endif
 
 			if (((uint32_t) lcore_socket_id) == socket_id)
 				n_detected++;
@@ -368,6 +370,7 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)
 					cpu_core_map_get_socket_id_linux(
 					lcore_id);
 
+#if !defined(RTE_ARCH_PPC_64)
 				if (lcore_socket_id < 0)
 					return -1;
 
@@ -377,9 +380,14 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)
 
 				if (lcore_core_id < 0)
 					return -1;
+#endif
 
+#if !defined(RTE_ARCH_PPC_64)
 				if (((uint32_t) lcore_socket_id == socket_id) &&
 					((uint32_t) lcore_core_id == core_id)) {
+#else
+				if (((uint32_t) lcore_socket_id == socket_id)) {
+#endif
 					uint32_t pos = cpu_core_map_pos(map,
 						socket_id,
 						core_id_contig,
-- 
1.9.1

  parent reply	other threads:[~2016-09-08 16:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 16:48 [dpdk-dev] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 1/9] lpm: add altivec intrinsics for dpdk lpm on ppc_64 Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 2/9] acl: add altivec intrinsics for dpdk acl " Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 3/9] l3fwd: add altivec support for em_hash_key Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 4/9] table: enable table library for ppc64le Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 5/9] sched: enable sched " Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 6/9] port: enable port " Gowrishankar
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 7/9] pipeline: enable pipeline " Gowrishankar
2016-09-08 16:48 ` Gowrishankar [this message]
2016-09-08 16:48 ` [dpdk-dev] [PATCH v7 9/9] table: fix verification on hash bucket header alignment Gowrishankar
2016-09-08 16:54 ` [dpdk-dev] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le Dumitrescu, Cristian
2016-09-09 15:59   ` Thomas Monjalon
2016-09-27  6:46     ` gowrishankar muthukrishnan
2016-09-27  7:01       ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com \
    --to=gowrishankar.m@linux.vnet.ibm.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=pradeep@us.ibm.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).