From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76F63A00C4; Tue, 4 Oct 2022 17:58:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 156B340DDC; Tue, 4 Oct 2022 17:58:41 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 460D840A79 for ; Tue, 4 Oct 2022 17:58:40 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9B0E566; Tue, 4 Oct 2022 18:58:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9B0E566 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664899119; bh=LAQwsf/YC1mGjWpdwohi+q58OYTRueWpz5HNb6XqT78=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Je2FZAsSSmL+2H1Zd6NUiVY86h7vs7wnqQQ0MWjHH8Xoo676mSJIzS18wvciA4tw6 9ZuPnkYrTb92iqbUXaOXmdr2L+gIwKwsWMmkGWL2p8LkZ6DH2ok5XsO5SOsgCPhNBE YBAAW+v5rVwNA3EOcGmEnx/FoxV12ETGARRQg05k= Message-ID: <1bd5c9f2-e1a5-8e19-fb41-08a5e6e66a43@oktetlabs.ru> Date: Tue, 4 Oct 2022 18:58:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] mempool: fix get objects from mempool with cache Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Aaron Conole Cc: olivier.matz@6wind.com, bruce.richardson@intel.com, jerinjacobk@gmail.com, dev@dpdk.org, Yuying Zhang , Beilei Xing References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk> <20220202081426.77975-1-mb@smartsharesystems.com> <43c333f7-83fa-3072-8db1-8b3a6ece5999@oktetlabs.ru> <98CBD80474FA8B44BF855DF32C47DC35D8738B@smartserver.smartshare.dk> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8738B@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/22 18:13, Morten Brørup wrote: > @Aaron, do you have any insights or comments to my curiosity below? > >> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru] >> Sent: Tuesday, 4 October 2022 14.58 >> >> Hi Morten, >> >> In general I agree that the fix is required. >> In sent v3 I'm trying to make it a bit better from my point of >> view. See few notes below. > > I stand by my review and accept of v3 - this message is not intended to change that! I'm just curious... > > I wonder how accurate the automated performance tests ([v2], [v3]) are, and if they are comparable between February and October? > > [v2]: http://mails.dpdk.org/archives/test-report/2022-February/256462.html > [v3]: http://mails.dpdk.org/archives/test-report/2022-October/311526.html > > > Ubuntu 20.04 > Kernel: 4.15.0-generic > Compiler: gcc 7.4 > NIC: Intel Corporation Ethernet Converged Network Adapter XL710-QDA2 40000 Mbps > Target: x86_64-native-linuxapp-gcc > Fail/Total: 0/4 > > Detail performance results: > ** V2 **: > +----------+-------------+---------+------------+------------------------------+ > | num_cpus | num_threads | txd/rxd | frame_size | throughput difference from | > | | | | | expected | > +==========+=============+=========+============+==============================+ > | 1 | 2 | 512 | 64 | 0.5% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 2 | 2048 | 64 | -1.5% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 1 | 512 | 64 | 4.3% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 1 | 2048 | 64 | 10.9% | > +----------+-------------+---------+------------+------------------------------+ > > ** V3 **: > +----------+-------------+---------+------------+------------------------------+ > | num_cpus | num_threads | txd/rxd | frame_size | throughput difference from | > | | | | | expected | > +==========+=============+=========+============+==============================+ > | 1 | 2 | 512 | 64 | -0.7% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 2 | 2048 | 64 | -2.3% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 1 | 512 | 64 | 0.5% | > +----------+-------------+---------+------------+------------------------------+ > | 1 | 1 | 2048 | 64 | 7.9% | > +----------+-------------+---------+------------+------------------------------+ > Very interesting, may be it make sense to sent your patch and mine once again to check current figures and results stability.