Re: [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError

[Luca Vizzarro <Luca.Vizzarro@arm.com>]

On 30/05/2024 16:47, Juraj Linkeš wrote:
>> @@ -129,21 +130,27 @@ class RemoteCommandExecutionError(DTSError):
>>       severity: ClassVar[ErrorSeverity] = ErrorSeverity.REMOTE_CMD_EXEC_ERR
>>       #: The executed command.
>>       command: str
>> +    _command_stderr: str
>>       _command_return_code: int
>>
>> -    def __init__(self, command: str, command_return_code: int):
>> +    def __init__(self, command: str, command_return_code: int, command_stderr: str):
> 
> I wanted to change the order here as well to command, command_stderr
> and command_return_code last. The API change doesn't matter as DTS is
> still experimental
> 
Ack.
>>           """Define the meaning of the first two arguments.
>>
>>           Args:
>>               command: The executed command.
>>               command_return_code: The return code of the executed command.
>> +            command_stderr: The stderr of the executed command.
> 
> And here.
> 
Ack.
>>           """
>>           self.command = command
>>           self._command_return_code = command_return_code
>> +        self._command_stderr = command_stderr
> 
> And here.
> 
Ack.