From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DC45F44115;
	Thu, 30 May 2024 20:49:03 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CD967402E6;
	Thu, 30 May 2024 20:49:03 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 37AED40289
 for <dev@dpdk.org>; Thu, 30 May 2024 20:49:02 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D38501424;
 Thu, 30 May 2024 11:49:25 -0700 (PDT)
Received: from [10.57.68.198] (unknown [10.57.68.198])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3B463F641;
 Thu, 30 May 2024 11:49:00 -0700 (PDT)
Message-ID: <1be59f33-cf3d-4169-a401-cda21470383c@arm.com>
Date: Thu, 30 May 2024 19:48:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError
Content-Language: en-GB
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240122182611.1904974-1-luca.vizzarro@arm.com>
 <20240514121023.1957025-1-luca.vizzarro@arm.com>
 <20240514121023.1957025-4-luca.vizzarro@arm.com>
 <CAOb5WZZJnQ+73miWQsr_jzY3ebW8_o4Vx_NkkciUGm+fQxG2JQ@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAOb5WZZJnQ+73miWQsr_jzY3ebW8_o4Vx_NkkciUGm+fQxG2JQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 30/05/2024 16:47, Juraj Linkeš wrote:
>> @@ -129,21 +130,27 @@ class RemoteCommandExecutionError(DTSError):
>>       severity: ClassVar[ErrorSeverity] = ErrorSeverity.REMOTE_CMD_EXEC_ERR
>>       #: The executed command.
>>       command: str
>> +    _command_stderr: str
>>       _command_return_code: int
>>
>> -    def __init__(self, command: str, command_return_code: int):
>> +    def __init__(self, command: str, command_return_code: int, command_stderr: str):
> 
> I wanted to change the order here as well to command, command_stderr
> and command_return_code last. The API change doesn't matter as DTS is
> still experimental
> 
Ack.
>>           """Define the meaning of the first two arguments.
>>
>>           Args:
>>               command: The executed command.
>>               command_return_code: The return code of the executed command.
>> +            command_stderr: The stderr of the executed command.
> 
> And here.
> 
Ack.
>>           """
>>           self.command = command
>>           self._command_return_code = command_return_code
>> +        self._command_stderr = command_stderr
> 
> And here.
> 
Ack.