From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0661BA0C47;
	Wed, 27 Oct 2021 17:12:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BCBE540DDA;
	Wed, 27 Oct 2021 17:12:35 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D5581407FF
 for <dev@dpdk.org>; Wed, 27 Oct 2021 17:12:34 +0200 (CEST)
Received: from [192.168.1.71] (unknown [188.170.75.60])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 077C77F6FA;
 Wed, 27 Oct 2021 18:12:33 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 077C77F6FA
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1635347554;
 bh=Z+Sp95C1+oaQf+9hrftmwVaRnEI8XOigSFSQms48XXE=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Cl+GSOPrxlORWyiNyUusCeMwUk2ASzzCnMoq4MEF3HddTDfgOSnIUV4VaUYs6ppgR
 wxpa6phWpCf0yUmktxeZj3uGfOGCKaRZWbiu9zRz9ktVE0ZXJzfFjTB+BgM+Aj69yk
 u/39Fr/xUpQ+wlWGJcow+MFc6drtvWKa16E53POg=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 "John W. Linville" <linville@tuxdriver.com>,
 Hyong Youb Kim <hyonkim@cisco.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org
References: <20211026153802.1820636-1-ferruh.yigit@intel.com>
 <20211027091429.2996153-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <1bf9fa5c-4b7c-6b96-5723-e3d8af958bdb@oktetlabs.ru>
Date: Wed, 27 Oct 2021 18:12:33 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211027091429.2996153-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/af_packet: fix driver init with
 default MTU
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/27/21 12:14 PM, Ferruh Yigit wrote:
> Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length,
> which doesn't include FCS (4 bytes CRC). But ethdev by default uses
> frame size with FCS when application doesn't define any explicit value.
> 
> As a result device configuration fails because device is tried to be
> configured with a frame size length that is bigger than what device
> reported as supported. Device reports as max supported frame size is
> 1514 but configured value is 1518.
> 
> Instead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the
> driver to report the max supported frame size, this matches to the
> initial intention.
> 
> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
> 
> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>