From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E6E751BDB1 for ; Thu, 20 Dec 2018 21:10:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 12:10:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,378,1539673200"; d="scan'208";a="305499294" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by fmsmga005.fm.intel.com with ESMTP; 20 Dec 2018 12:10:18 -0800 To: Honnappa Nagarahalli , Bruce Richardson Cc: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , nd , "yipeng1.wang@intel.com" , "sameh.gobriel@intel.com" References: <20181101045454.632-2-honnappa.nagarahalli@arm.com> <20181101232522.702-1-honnappa.nagarahalli@arm.com> <20181102112507.GE26868@bricha3-MOBL.ger.corp.intel.com> From: "Yigit, Ferruh" Message-ID: <1c1a7981-0c4c-f75b-b353-08b11faf78c9@linux.intel.com> Date: Thu, 20 Dec 2018 20:10:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 20:10:22 -0000 On 11/2/2018 5:38 PM, Honnappa Nagarahalli wrote: >> >> On Thu, Nov 01, 2018 at 06:25:18PM -0500, Honnappa Nagarahalli wrote: >>> Various configuration flags in rte_hash library result in increase of >>> number of test cases. Configuration flags for enabling transactional >>> memory use and read/write concurrency are not required. These features >>> should be supported by default. Please refer to [1] for more context. >>> >>> This patch marks these flags for deprecation in 19.02 release and >>> cleans up the test cases. >>> >>> [1] http://mails.dpdk.org/archives/dev/2018-October/117268.html >>> >>> Honnappa Nagarahalli (4): hash: prepare for deprecation of flags hash: >>> deprecate lock ellision and read/write concurreny flags test/hash: >>> stop using lock ellision and read/write concurreny flags doc/hash: >>> deprecate lock ellision and read/write concurreny flags >>> >> While I'd like to reduce the flags and do cleanup, I'm a little concerned about >> putting this scope of changes in so late in the release. I wonder if less drastic >> changes could work as well for this release, and do the cleanup later. > Thank you Bruce for the review. This patch series is not fixing any user related problems, let us skip this for 18.11. It will give us time as well to think through and get this right. There was no update in the scope of 19.02, I guess it will skip for 19.02 too. Patchset updated as "Change requested" in patchwork. > >> For example, rather than deprecating the flags now, how about just change >> the default for when no flags are set? If user has set flags, follow the existing >> path - if flags is set to zero, then have the defaults be to use RW concurrency >> or TSX. > This changes the behavior of the library and what the flags mean, still requires ABI change, but does not need deprecation of flags (I guess this is what you meant). However, it will not solve the problem of losing the capability to disable TSX. > >> >> /Bruce