From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0043.outbound.protection.outlook.com [104.47.37.43]) by dpdk.org (Postfix) with ESMTP id D10C958C3 for ; Thu, 6 Oct 2016 13:42:08 +0200 (CEST) Received: from BN3PR0301CA0071.namprd03.prod.outlook.com (10.160.152.167) by BY2PR0301MB2008.namprd03.prod.outlook.com (10.163.196.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Thu, 6 Oct 2016 11:42:07 +0000 Received: from BN1BFFO11FD022.protection.gbl (2a01:111:f400:7c10::1:179) by BN3PR0301CA0071.outlook.office365.com (2a01:111:e400:401e::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16 via Frontend Transport; Thu, 6 Oct 2016 11:42:07 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD022.mail.protection.outlook.com (10.58.144.85) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Thu, 6 Oct 2016 11:42:06 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u96Bg3DU013381; Thu, 6 Oct 2016 04:42:04 -0700 To: Thomas Monjalon References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> <295101088.MT2WGLcZeq@xps13> CC: David Marchand , , Jan Viktorin From: Shreyansh Jain Message-ID: <1c349216-6ca6-5f40-d646-2ba59412d184@nxp.com> Date: Thu, 6 Oct 2016 17:13:00 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <295101088.MT2WGLcZeq@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131202277268399845; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(377454003)(24454002)(377424004)(189002)(230700001)(31686004)(356003)(189998001)(47776003)(7846002)(626004)(586003)(68736007)(8676002)(23746002)(81156014)(81166006)(93886004)(83506001)(33646002)(105606002)(2906002)(4001350100001)(85426001)(106466001)(36756003)(104016004)(4326007)(76176999)(87936001)(2950100002)(65826007)(19580395003)(31696002)(19580405001)(8936002)(54356999)(6666003)(97736004)(64126003)(6916009)(86362001)(92566002)(65956001)(305945005)(65806001)(11100500001)(50986999)(77096005)(50466002)(110136003)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB2008; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD022; 1:qdOTO7TpcXGAAGaOA86xAts0bylveKQ9p33UMFQAklf7hAWqa+FQTeBb0VZAw8RVGuFlNR4kG9OLc99psvf6bxScVCzzaHaGtuJGOKbyIcLJ0Sp60dXEu7iLyHVATBk5n6ekntDjI8Zds7ifhUvGAFUMiJutzwi1+6yURzdjaUewjPgy17Z4w26A0u8jzo8hd9hZFtbc55t1df3vXyJicIUvf6u4DGo0zxIpVskycC1CZOd2JeMWgMvbk9PrRDzzUPpWBUXgmYrr0MQASCLH6q9pqWe2x9s1rzV3lHeOas3R7xFkFkTOxVIX+ts2LCjQHun8sUh1jDCsuteBWFWoFIaW9zerDnJWjtZEshdSGwq+pTm61kw4XDetbn3j1zyDRczNsK794OhLdS+kpzVddejYCtsbdZng/KXu5m9RuwYyCUjkdAJqY1YyWTBRMn+u1gnS/fZD5ldKCOW5jMJ6s5gBNqs616RXHk7n4SD68fr9TraNcXLPAzBnw2g9yHCMf0FbD1x03vsf0OflPrcBiFq/Y6481M4KNzLK9WDaSoPzu9bv7X4Ce4KX/yDdOgwVnlv4M/yYKrMW5+TZ/CeZSw== X-MS-Office365-Filtering-Correlation-Id: bff5135c-2052-46fe-ba85-08d3edddccaf X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2008; 2:VbOGuZLrClDjfKNmiGM34IaHf5MXy3fK7V0l/FosJ5Snj/N0CSQroJK735lvwVISIod37hqOhv4PyYbwzRrMV+AcnwXRJVRDvSzzatlwLlvqpvUc2rsColqRZQbGtZLjq3+lD4ECnO9WsJoAH55c5z6TbYvD3nHsX4x7qzbD4YuDKx92LL/QVqJuboxbFVOyWnLFSpppbYT73vPWLMbL6Q==; 3:zP9zvndu1dsZKMHOVPMQ2c6Sksh5LlQdqe96N57VqvBgHkIQBHePZjlEw5kmQXHnuuKJS9bU3fziHMdswmm1UNgZIptXvpupFGzk139ljN/MN1N2B3zMd/gzgv20W6pRrFnH88y0HjDeC9PJrCHmsA8si3ox8bojgJhCTzzwjNjynCk1DNeNpMZ+yKk0OCLqlf+7VniMtbIpDGttX7gXcK62znEeG992KI4OjjSxqRdontGYd0c/NQgJQsQbXMwx X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB2008; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2008; 25:uduRw9TNsUWwMTdjdE7DBKGlkdFTFayIogPpik7Vb4T/UHHdp7YBZJyFxO29JTqs49fN0Q7X1HO4BoPQiTIOE4/yCbqsjpXXIsv/nM7U2tyud8MfQqSgOI+9AS98AZt8+3RkNTZBC7yddBuJ2h1RnmJp2Dm2Q6VF3Z1TzrNPLuhcRT/UjHmd9MinyJFAhlElBzS7FC4sgAYCB+mdtgt4XTFqYkPJREeADSlfRIKAVL8Iez036WaH1fSkYMsXgKPgHfKOOAdPbK3BpQ8Oh0g13GA+bMsy3aVp9GZktWmdfUam50jHm5TIytGRqrgKsdJf95AAPlRG6JAEY148+WXAHLcCppYOMh8npt9h9A5pxahiszkZP1zetiYlvwwf/EdGzjYSbvxgsf2drzDAlE8+QRK1b205eLulXzSoh2qzyQ2Xtc38v7P2I6Tqe7jYQWB1fNSLiDh4lTl5ZRdnNNfn7aVhX9PhqnJDUek2voGswE2vshEd3RY2aTpmJqrN0QZ/tyvG82+yGtC5nxiF645zdQg1a9DgJXfpGzhtMzToxtjV1Wd2uUIFkXyv+j5FoHmY90qSMD0iY6M0WPodE8DcVw7lfumyhdtJzMgLblwXGr/CoxcTbuPgXPiOxpX8f0shHMJPqhbsKtvIq2BtbEx3F4V9fcP+4Uzn/Go/vvAUOxoc1ug5uLV74j0Du6SI5MBphjqD5nNIp6cltn1LR1sJOJs5MHaywQyxtNPv/I69aATSb7yJONIYpwR/AId70aOM29ZtGteSwmjk58Ce+sSwOfgGNNFLucR7/8v6k+5benc= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2008; 31:qPWPxowP5dgGziJTxbgPe2pp9EzXi3ZOgTUoZKIg6goHSz/4xXaId/n1uOn24kSTgWcKp0Yxscedo6ZrjObnJMOD+yGWrr9nOUH0+khCv00TiVsM003NfXAg/E1HNWgZ3umIheAkIleWil3L0GIVezVVwCx0LdvZyLsbYajNRDrQnq1tV+nT57vYszsGwgXQZAgmubs8EWxbz3b8Qusy49JdIRRV3Vh9T8qMrjoJWe4pG3NMIfVc3Pq3lWpJSEKuofbIxQIjHXLkPlTYJHdRbQ==; 4:ShGfeoVV6DGTOP4083D4zyYYc17aQn5MikAkjtAkWHtlWaBxv/x4gHRX5dMK8JZFxE7WhoCvbBQi0nYxkUY/3fCFNZZdVzAXmnFJreT7jVJaTYidwvB72eyGQemFfcPghw4u68Jdi7hdwkUFwZgCaD+C6o3ayq47q+Gr8BFrPcqrFwkA7jDC+Hv8r79ph8uaeMPoFjvJh9Z4JaID/SJxoIqgOwC0G4Y0n/HbB5NaHt2ioWa7APSVgAUojNkV4dUupDhQh8vLJeZnpBzhU+bUqi/4/0BgHUhhnr7WS9fkn2ie93VQJIECb8L+P+Fjw6eieV+19vaY8syHVo/ERLuPao03CNLfHpNPYF8TS0rL7e809m2w+9firh8yyrPrYBY0f1RpQS+XU7GWYVszbdgn5SmTfz3V9mNOVnTAHK4yQjvkbaJZyLW4QQS6Thnxx+oEOEl+1Qg6QAr+A7dnFH9pDY5UqwColk/e8ZTD3WN30vEpOn+gMtfJKrFmfgT86UQikBLOFsCIefQeenlbb5u+ZcUhZVMSXP0WjTTEfiR6ykZTWyckz7z3YtoSD2sHGZuw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(13024025)(13017025)(13018025)(13015025)(13023025)(5005006)(10201501046)(3002001)(6055026); SRVR:BY2PR0301MB2008; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB2008; X-Forefront-PRVS: 00872B689F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB2008; 23:z0sEhaEi4Fw1e8mByNVa0+MFTgJZnvbn8or?= =?Windows-1252?Q?dFZLKErDFaeqX8IDYKXJz+qOEwRBF/EK3Qdl9UX6SYRv0VgDwVdkUMnS?= =?Windows-1252?Q?CSMsOOeP6b/btJaZ8QbcGOD2qym8EFezpPsVUWs8dc2YTAF9mJdhrsLf?= =?Windows-1252?Q?+z9FTm2nSUEYaAdFtm+8aKT+eyPeWMXi8cOiJZTDh9gc2KdxlrjQNgJC?= =?Windows-1252?Q?wUILgN2Z2YWhf52APyQSAsDV2si9sVJL/ujzTTY1g4VByw7xP1Vd3qMb?= =?Windows-1252?Q?cUa20K47HILgUGtefF/8v7lSSVtGs4wtZkkYHC9vkkeAzVazYVjlUiKU?= =?Windows-1252?Q?rVPwuAHUSjb1nITZ+U67IDN/FzoQ7Q8OKkkpex6fVGMRdroHnQ5g6RPE?= =?Windows-1252?Q?pBaU0/KDl5cyVrPUh/9Jjzj6i/U409k96p2jWekSqh0Pz5XjkIvFuFss?= =?Windows-1252?Q?UiQfCepZFaAzRrx76LlEqoQXzJ/V0M0cZaa818K0UAyRcep0dwtgZkR9?= =?Windows-1252?Q?g3W65Ftw8S9zLwAF/Wfj9VPbZVKE8r/WEwStzknwMgc6kvB62CxFhZIE?= =?Windows-1252?Q?sfFsxUT2eAWQmCsnk4v6uX4LUH3FNR0pgRkfHYjLwB+0knNdka0UfgNu?= =?Windows-1252?Q?dV0gjB3FUtHWL+RvBp0lpB1kLf0yentRHp7ie5jl7hGIuvUJmt0PSjui?= =?Windows-1252?Q?ZQKoAS5meJGFYRabAJFzUjF/cEVfxbbVJKxQ/I/S8Ylepwot04bKs0oO?= =?Windows-1252?Q?m/O2joKVAwNGzR+kwdCSGl/7cnPzefhNSWd67ZDX6QfEuciO5noCxSlP?= =?Windows-1252?Q?a+bSZaTPIV66Yw4dr9iRJK4tukDhyE62l+TO46pHNbEdD0kiMoNPvHgg?= =?Windows-1252?Q?b1WoanDr7VO/l5zV6gWawTwVuGjzBEwpB3Ckmk4IyhkhL31Tu6cVW0eq?= =?Windows-1252?Q?5cdMtbMPLzttfMZo8LteEa1SQ+292S8QtzqCOs0fXaq+bgBvWvV7iMjM?= =?Windows-1252?Q?1X45xKqvXaN2ebhluKtz/+SQBvHp8fcuXvIucdC7GpMW+ZPD0xnjAOJy?= =?Windows-1252?Q?n2tNEo3NDqiEIes4hh/1/7t0u61vG16te1uTiH1GylA2+2fSenNJLXag?= =?Windows-1252?Q?EYGS+P5fv3oFZzDBGN5xZth5ruxkyR7T+7dPnDAuuww0ewa80ZfdWxjp?= =?Windows-1252?Q?zsrmYQ6R3k0SML/kXtV9VAg674e7m+lthLqLDWGu6f1fuyHOQEth2e+M?= =?Windows-1252?Q?+oyRS/e86eP3IqAtqxUBhTooCbvmNpxzi30oAHJ5x4ckDESe/2/KND+Q?= =?Windows-1252?Q?N7jCEN0D+l7xfWfW8WOczlN26R+1c5btriyqZbf8ec7uFreTHpDyKsvX?= =?Windows-1252?Q?PUTfYPOotYQ3zVrmooQDad5IMB/Vjn5E5KrOH9RYmDp0srvXAH2zAlPg?= =?Windows-1252?Q?rniMS04YO/68qOFODb1gg8hq5QL3+j2WoBN0JFHaqKXOPobBHCQHwh9r?= =?Windows-1252?Q?M40xxh4tO1zFV/x/7Ls+Bvb19kQiP?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2008; 6:HHd3mpE2gUqMa0+/SimPxxerKxs2YQzuLd5537Bi/JyJjiWS58M+qvKKxXHtP9hC3CIY/1dsQT35XIPTn9DK/EfT7iboXDMj2mUm8hrlKaut3yhPqPZIeK0sKa1d5ccBXw5L/K9veCa4BlTwdUwnwGT6/8hMsygKbeKvXaV2qv747Ez9+7DiiY2K3GLBRkrLVb4UyxhbdxyU2uMpbfiUWiIDGBtme+JN6Vgq+rHgvRbWtcdxXjaURYclmUfj9gIXBKb2w/8hhGARTQknhJe0uwuAP3IWfkzG6BZTM6uUZ7McB+/n3q8NftYdLFjkChB9; 5:h90FlxwjN7+MGfDy1fr24bqdTXwZXlmAvtt1oRG6AF98P67P7Xg50xUuyccACIoCq6ITFMlBm/j5BTjChdaRAMEmN6nnXaczYBKZrp5K0FV2Hw4FrMstItETof86g02DNxIzyspUqL4+oDwPylwQFXPiapgbGwolsIKUukMGWpWqf9OpYP0m8YtoPBi0FnSU; 24:egAl4pmz9d+1CWPqekFCzvvSoq9bYI9GqAoNtdhk+3T4rXBO5lrDZmuo/rzQfyTKWrPFveKPudEWno921uooXZm9HvifaBKKFcp0iv9WHCg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2008; 7:YVwfiVbhuj+Y7kqOFqhOd8rdj06tG60k6xM7R34sXvBOcytQ8P8PtsYlksy3mjzSNiCD7jFuF3ImcWtw2yPIbfOjm2sJ4q/xJicETUiM8d22F1ZYVVeAUL06hrGEc4lswPUopivDwdPCG6S2AysPvwe9ELlzYxlQEOkGMpL304ReZlKeLELMif67GeBRFrwQb6u164IVM9uHucrLLf1T1+uJsGWVuRfDcMce+tHuKPUwdf9KE4+FHZR9V3KdpJ99wS3/85wS5Cf4IGh1AZK48+hZQD2C/mKjZ0bF70EogkLImseOIFJSQXyGPUjLw4qgOAZbcQ+DVNsZOdVSOGO+bw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2016 11:42:06.5279 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB2008 Subject: Re: [dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 11:42:09 -0000 Hi Thomas, On Monday 03 October 2016 07:06 PM, Thomas Monjalon wrote: > 2016-10-03 11:07, Shreyansh Jain: >> Hi David, >> >> On Friday 30 September 2016 09:01 PM, David Marchand wrote: >>> On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain wrote: >>>> (I rebased these over HEAD 7b3c4f3) >>>> >>>> These patches were initially part of Jan's original series on SoC >>>> Framework ([1],[2]). An update to that series, without these patches, >>>> was posted here [3]. >>>> >>>> Main motivation for these is aim of introducing a non-PCI centric >>>> subsystem in EAL. As of now the first usecase is SoC, but not limited to >>>> it. >>>> >>>> 4 patches in this series are independent of each other, as well as SoC >>>> framework. All these focus on generalizing some structure or functions >>>> present with the PCI specific code to EAL Common area (or splitting a >>>> function to be more userful). >>> >>> Those patches move linux specifics (binding pci devices using sysfs) >>> to common infrastucture. >>> We have no proper hotplug support on bsd, but if we had some common >>> code we should at least try to make the apis generic. >>> >> >> I am not sure if I understood your point well. Just to confirm - you are >> stating that the movement done in the patches might not suit BSD. >> Probably you are talking about (Patch 3/4 and 4/4). >> Is my understanding correct? >> >> So, movement to just Linux area is not enough? >> I am not well versed with BSD way of doing something similar so if >> someone can point it out, I can integrate that. (I will investigate it >> at my end as well). >> >> This patchset makes the PCI->EAL movement *only* for Linux for sysfs >> bind/unbind. (I should add this to cover letter, at the least). > > The concern is about function declarations in > lib/librte_eal/common/eal_private.h > We cannot be sure it can be applicable to something else than Linux. > As it is implemented in Linux only, it should not be in a common header. > Ok. But, digging a little I found at least one more similar case. 'rte_eal_check_module()' which is present in the linuxapp/eal.c and has existence in common, but no parallel implementation for BSD exists. This function is accessing /sys/modules - which might be Linux specific. It seems to be a pretty old entry though (dating back to 2014). - Shreyansh