From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 44EE95B30 for ; Wed, 7 Mar 2018 16:25:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 07:25:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,436,1515484800"; d="scan'208";a="180687261" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga004.jf.intel.com with ESMTP; 07 Mar 2018 07:25:17 -0800 To: "Ananyev, Konstantin" , "Awal, Mohammad Abdul" , "thomas@monjalon.net" Cc: "rkerur@gmail.com" , "dev@dpdk.org" References: <1519721907-25198-1-git-send-email-mohammad.abdul.awal@intel.com> <2601191342CEEE43887BDE71AB977258905783AF@irsmsx105.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <1c3de88f-5fee-f060-e925-df7e408b504e@intel.com> Date: Wed, 7 Mar 2018 15:25:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258905783AF@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ether: fix invalid string length in ethdev name comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 15:25:21 -0000 On 2/27/2018 9:38 AM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Awal, Mohammad Abdul >> Sent: Tuesday, February 27, 2018 8:58 AM >> To: thomas@monjalon.net >> Cc: rkerur@gmail.com; dev@dpdk.org; Ananyev, Konstantin ; Awal, Mohammad Abdul >> >> Subject: [PATCH v2] ether: fix invalid string length in ethdev name comparison >> >> The current code compares two strings upto the length of 1st string >> (searched name). If the 1st string is prefix of 2nd string (existing name), >> the string comparison returns the port_id of earliest prefix matches. >> This patch fixes the bug by using strcmp instead of strncmp. >> >> Fixes: 9c5b8d8b9fe ("ethdev: clean port id retrieval when attaching") >> >> Signed-off-by: Mohammad Abdul Awal > Acked-by: Konstantin Ananyev Applied to dpdk-next-net/master, thanks.