From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id E5E941B2A5;
 Thu, 18 Jan 2018 11:09:18 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 18 Jan 2018 02:09:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,376,1511856000"; d="scan'208";a="20730865"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2018 02:09:15 -0800
To: Thomas Monjalon <thomas@monjalon.net>
Cc: stable@dpdk.org, dev@dpdk.org, declan.doherty@intel.com,
 Boris Pismenny <borisp@mellanox.com>, Aviad Yehezkel <aviadye@mellanox.com>,
 Radu Nicolau <radu.nicolau@intel.com>
References: <20180109162317.18183-1-ferruh.yigit@intel.com>
 <20180117215802.90809-1-ferruh.yigit@intel.com>
 <20180117215802.90809-2-ferruh.yigit@intel.com> <2207589.F0NTZTrxns@xps>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <1c3e60a1-5824-77df-4bf4-dac2f8b8059e@intel.com>
Date: Thu, 18 Jan 2018 10:09:15 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <2207589.F0NTZTrxns@xps>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/6] ethdev: return named
 opaque type instead of void pointer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 10:09:19 -0000

On 1/17/2018 10:11 PM, Thomas Monjalon wrote:
> 17/01/2018 22:57, Ferruh Yigit:
>> "struct rte_eth_rxtx_callback" is defined as internal data structure and
>> used as named opaque type.
>>
>> So the functions that are adding callbacks can return objects in this
>> type instead of void pointer.
> 
> It is an API change.
> Let's plan it for 18.05.

No issue for pushing this to next release, but not sure if this API change
effects end user.

"struct rte_eth_rxtx_callback" is private data structure, previously how user
should be using it can be:

a)
void *cb;
cb = rte_eth_add_rx_callback(..);
rte_eth_remove_rx_callback(.., cb);

b)
struct rte_eth_rxtx_callback *cb;
cb = rte_eth_add_rx_callback(..);
rte_eth_remove_rx_callback(.., cb);


And same a) or b) can be used without any side effect with updated API.