From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 253A3A0597; Thu, 9 Apr 2020 10:43:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCA871C1D4; Thu, 9 Apr 2020 10:43:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DADA81C1B4 for ; Thu, 9 Apr 2020 10:43:09 +0200 (CEST) IronPort-SDR: 5h3eq9YByPxmIRzdwRzpbo6+p1xHWo4g05P5p2g/PbsGFr8QWx6jhMcevSjXqQdj56W94ze4MM 8o43+QxiDtVA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 01:43:03 -0700 IronPort-SDR: hs89Ifl6sMqw6L5mhp5yvVU5jpu9n5Jvb7COUt4JJ1N+bv5gwuUFh9McjP1Md970Z/Ax31WP5s kSA8sIn7222Q== X-IronPort-AV: E=Sophos;i="5.72,362,1580803200"; d="scan'208";a="425437613" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.8.214]) ([10.252.8.214]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 01:43:02 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: reshma.pattan@intel.com References: <854770a880777e7ad200481294a7aa5ac9a45f2d.1586361368.git.anatoly.burakov@intel.com> From: "Hunt, David" Message-ID: <1c47516b-f087-6792-bf05-97f498e503c2@intel.com> Date: Thu, 9 Apr 2020 09:42:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <854770a880777e7ad200481294a7aa5ac9a45f2d.1586361368.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, On 8/4/2020 4:56 PM, Anatoly Burakov wrote: > Currently, if power library initialization fails, only a log message is > displayed. This is suboptimal for a number of reasons, but the main one > is that telemetry mode does not depend on the power library and can > therefore run in environments where l3fwd-power would normally not run > correctly (such as inside a VM). This will lead to attempts to > deinitialize the power library on exit, with a subsequent forced unclean > shutdown of DPDK. > > Fix this by only initializing the power library in modes that actually > need it, and change a log message to a failure to initialize. > > Signed-off-by: Anatoly Burakov > --- > examples/l3fwd-power/main.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > Acked-by: David Hunt