From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B79FFA054A;
	Fri, 19 Feb 2021 09:49:51 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2501140395;
	Fri, 19 Feb 2021 09:49:51 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id 09B1A40042;
 Fri, 19 Feb 2021 09:49:48 +0100 (CET)
IronPort-SDR: Ci5QVYfkVm3Xp4hXw2XTahvnwM5ET9keNdExSEMDRN6d74gqn5AUMWQiIqBP5jlgN1qF9bbfc8
 B28khw+LvRBQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="182991722"
X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="182991722"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Feb 2021 00:49:48 -0800
IronPort-SDR: Ms9Y0+0pk6JoAW6+cP7VUkYRuqk7I6RZUjUP3ssBR3dYSt7Yc9vu9VjjDkuFi5j2GVjA0OQmMF
 UNR/AySMe0rg==
X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="386790648"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.55])
 ([10.213.251.55])
 by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Feb 2021 00:49:45 -0800
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org
Cc: stable@dpdk.org, Gaetan Rivet <grive@u256.net>,
 Pavan Nikhilesh <pbhagavatula@marvell.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>
References: <20201222080004.837537-1-andrew.rybchenko@oktetlabs.ru>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <1c67d7dc-a4d9-974f-8bcb-0eb2f7160d89@intel.com>
Date: Fri, 19 Feb 2021 08:49:42 +0000
MIME-Version: 1.0
In-Reply-To: <20201222080004.837537-1-andrew.rybchenko@oktetlabs.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
> If sub-devices support RSS hash offload, the offload should be
> reported by the failsafe device since handling is transparent
> from failsafe point of view.
> 
> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

It looks reasonable, but would be good to get ack from maintainer.

Gaetan, can you please look at this?

Thanks.