From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D8C6C2F42 for ; Tue, 13 Nov 2018 22:28:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 13:28:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,229,1539673200"; d="scan'208";a="90874888" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.79]) ([10.237.221.79]) by orsmga006.jf.intel.com with ESMTP; 13 Nov 2018 13:28:02 -0800 To: "Zhao1, Wei" , "ophirmu@mellanox.com" , Qi Zhang Cc: "dev@dpdk.org" , "Peng, Yuan" , Adrien Mazarguil References: <1542014724-68073-1-git-send-email-wei.zhao1@intel.com> <20181112140305.GD17131@6wind.com> <67D543A150B29E4CAAE53918F64EDAEA37648A56@SHSMSX103.ccr.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLzsFNBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABwsF8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <1c9e3ac6-2185-34e1-0aca-eb08451ddab6@intel.com> Date: Tue, 13 Nov 2018 21:28:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 21:28:06 -0000 On 11/13/2018 2:41 AM, Zhao1, Wei wrote: > Add Ophir Munk for discussion. > > >> -----Original Message----- >> From: Peng, Yuan >> Sent: Tuesday, November 13, 2018 10:27 AM >> To: Zhao1, Wei ; Adrien Mazarguil >> >> Cc: dev@dpdk.org >> Subject: RE: FW: [PATCH] net/i40e: add parameter check for RSS flow init >> >> Hi, Adrien Mazarguil >> >> Yes. It's just the problem related to commit >> a4391f8bae85db0153e1f101c21c61151573baad "app/testpmd: set default RSS >> key as null". >> You can check the detailed bug information from >> https://jira01.devtools.intel.com/browse/DPDK-7136?filter=-2 >> >> Thank you. >> Yuan. >> >> -----Original Message----- >> From: Zhao1, Wei >> Sent: Tuesday, November 13, 2018 9:29 AM >> To: Adrien Mazarguil >> Cc: Peng, Yuan ; dev@dpdk.org >> Subject: RE: FW: [PATCH] net/i40e: add parameter check for RSS flow init >> >> Hi, Adrien Mazarguil >> >> Peng yuan has find this problem, if you use the following test step, >> You will find the problem. >> >> ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 - -i --nb-cores=8 -- >> rxq=4 --txq=4 --port-topology=chained ............... >> testpmd> start >> testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp >> testpmd> end key 67108863 / end >> Segmentation fault (core dumped) The patch causing the crash reverted [1], change will be on RC3 so this should be solved already, you can verify it with head of next-net. Still, this patch adds some checks, no harm to have them if you still want to have it in? (perhaps only need to drop Fixes line.) Qi, What do you think, does it have any risk to get it on rc3? Or should we push to next release since it turned out to be extra safety checks now? [1] Commit 8773db152033 ("app/testpmd: revert setting default RSS") >> >> >> https://patches.dpdk.org/patch/47995/ >> This is the protection I have add, but you still need fix some bug in rte_flow >> CLI. >> >> >>> -----Original Message----- >>> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] >>> Sent: Monday, November 12, 2018 10:03 PM >>> To: Zhao1, Wei >>> Cc: Peng, Yuan >>> Subject: Re: FW: [PATCH] net/i40e: add parameter check for RSS flow >>> init >>> >>> Hi Wei, >>> >>> On Mon, Nov 12, 2018 at 10:02:20AM +0000, Zhao1, Wei wrote: >>>> Hi, adrien.mazarguil >>>> >>>> There is some error in CML layer for config this parameter, in >>>> i40e PMD it will get NULL of in->key even if tester config Some >>>> specific key >>> from testpmd CLI, I add some protection but you also need fix that bug >>> in CLI layer. >>> >>> Odd, is that new? You shouldn't need to worry about the pointer if >>> key_len is zero. >>> >>> Isn't this problem related to commit a4391f8bae85 "app/testpmd: set >>> default RSS key as null"? There's an ongoing discussion to revert this patch >> [1]. >> >> testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp >> testpmd> end key 67108863 / end >> >> This CLI command key is not NLLL, but i40E PMD get NULL. >> >>> [1] https://mails.dpdk.org/archives/dev/2018-November/118633.html >>> >>>>> -----Original Message----- >>>>> From: Zhao1, Wei >>>>> Sent: Monday, November 12, 2018 5:25 PM >>>>> To: dev@dpdk.org >>>>> Cc: Zhang, Qi Z ; stable@dpdk.org; Peng, >>>>> Yuan ; Zhao1, Wei >>>>> Subject: [PATCH] net/i40e: add parameter check for RSS flow init >>>>> >>>>> There need an parameter check for RSS flow init, or it may cause >>>>> core dump if pointer is NULL in memory copy. >>>>> >>>>> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow >>>>> API") >>>>> >>>>> Signed-off-by: Wei Zhao >>>>> --- >>>>> drivers/net/i40e/i40e_ethdev.c | 5 ++++- >>>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/i40e/i40e_ethdev.c >>>>> b/drivers/net/i40e/i40e_ethdev.c index 1c77906..217a8dc 100644 >>>>> --- a/drivers/net/i40e/i40e_ethdev.c >>>>> +++ b/drivers/net/i40e/i40e_ethdev.c >>>>> @@ -12552,13 +12552,16 @@ i40e_rss_conf_init(struct >>>>> i40e_rte_flow_rss_conf *out, >>>>> if (in->key_len > RTE_DIM(out->key) || >>>>> in->queue_num > RTE_DIM(out->queue)) >>>>> return -EINVAL; >>>>> + if (!in->key && in->key_len) >>>>> + return -EINVAL; >>>>> + if (out->key && in->key) >>>>> + out->conf.key = memcpy(out->key, in->key, in->key_len); >>>>> out->conf = (struct rte_flow_action_rss){ >>>>> .func = in->func, >>>>> .level = in->level, >>>>> .types = in->types, >>>>> .key_len = in->key_len, >>>>> .queue_num = in->queue_num, >>>>> - .key = memcpy(out->key, in->key, in->key_len), >>>>> .queue = memcpy(out->queue, in->queue, >>>>> sizeof(*in->queue) * in->queue_num), >>>>> }; >>>>> -- >>>>> 2.7.5 >>>> >>> >>> -- >>> Adrien Mazarguil >>> 6WIND