From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4B5BB1B66F for ; Mon, 5 Feb 2018 19:52:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 10:52:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="25009950" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 10:52:00 -0800 To: David C Harton , yliu@fridaylinux.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com Cc: dev@dpdk.org, olivier.matz@6wind.com References: <20180203145523.28013-1-dharton@cisco.com> From: Ferruh Yigit Message-ID: <1c9e6fb9-e675-00ce-a456-46f8d20e9a7a@intel.com> Date: Mon, 5 Feb 2018 18:52:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180203145523.28013-1-dharton@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 18:52:03 -0000 On 2/3/2018 2:55 PM, David C Harton wrote: > virtio_dev_free_mbufs was recently modified to free the > virtqueues but failed to check whether the array was > allocated. Added a check to ensure vqs was non-null. > > Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing") > Cc: olivier.matz@6wind.com > > Signed-off-by: David C Harton [1] Signed-off-by: David Harton Reviewed-by: Olivier Matz Reviewed-by: Maxime Coquelin Applied to dpdk-next-net/master, thanks. [1] Hi David, Since your previous commits has "David Harton" name, to prevent seen as a new person, I kept same name, fyi.