From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CB7F8457A0;
	Mon, 12 Aug 2024 13:58:16 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 65B56402C3;
	Mon, 12 Aug 2024 13:58:16 +0200 (CEST)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by mails.dpdk.org (Postfix) with ESMTP id A95614029C
 for <dev@dpdk.org>; Mon, 12 Aug 2024 13:58:14 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id B033636
 for <dev@dpdk.org>; Mon, 12 Aug 2024 13:58:13 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 89B751FFD2; Mon, 12 Aug 2024 13:58:13 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on
 hermod.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL,
 T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0
X-Spam-Score: -1.3
Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se
 [62.63.215.114])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id 363DA89;
 Mon, 12 Aug 2024 13:58:11 +0200 (CEST)
Message-ID: <1cd19a85-08be-4c05-b665-f82b1c5095ff@lysator.liu.se>
Date: Mon, 12 Aug 2024 13:58:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/5] eal: extend bit manipulation functionality
To: Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
 =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org
Cc: Heng Wang <heng.wang@ericsson.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Joyce Kong <joyce.kong@arm.com>,
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
References: <20240809090439.589295-2-mattias.ronnblom@ericsson.com>
 <20240809095829.589396-1-mattias.ronnblom@ericsson.com>
 <20240809095829.589396-2-mattias.ronnblom@ericsson.com>
 <89576b74-e45c-4363-abd3-a50480d7aea9@foss.arm.com>
Content-Language: en-US
From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>
In-Reply-To: <89576b74-e45c-4363-abd3-a50480d7aea9@foss.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024-08-12 13:16, Jack Bond-Preston wrote:
> On 09/08/2024 10:58, Mattias Rönnblom wrote:
> <snip>
>> +
>> +__RTE_GEN_BIT_TEST(, test,, 32)
>> +__RTE_GEN_BIT_SET(, set,, 32)
>> +__RTE_GEN_BIT_CLEAR(, clear,, 32)
>> +__RTE_GEN_BIT_ASSIGN(, assign,, 32)
>> +__RTE_GEN_BIT_FLIP(, flip,, 32)
>> +
>> +__RTE_GEN_BIT_TEST(, test,, 64)
>> +__RTE_GEN_BIT_SET(, set,, 64)
>> +__RTE_GEN_BIT_CLEAR(, clear,, 64)
>> +__RTE_GEN_BIT_ASSIGN(, assign,, 64)
>> +__RTE_GEN_BIT_FLIP(, flip,, 64)
> 
> What is the purpose of the `fun` argument? As opposed to just having 
> these written out in the macro definitions. I notice the atomic 
> equivalents don't have this.
> 

It has no purpose, any more. I failed to clean that up, after removing 
the "once" family of functions.

Thanks.

>>   /*------------------------ 32-bit relaxed operations 
>> ------------------------*/
>>   /**
>> <snip>