From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Junlong Wang <wang.junlong1@zte.com.cn>,
Lijie Shan <shan.lijie@zte.com.cn>
Subject: Re: [PATCH] net/zxdh: remove redundant log prefix
Date: Wed, 6 Nov 2024 10:29:38 +0000 [thread overview]
Message-ID: <1ce273b0-5c20-467e-a6f4-dd616fbdab85@amd.com> (raw)
In-Reply-To: <20241106090800.817227-1-david.marchand@redhat.com>
On 11/6/2024 9:08 AM, David Marchand wrote:
> By using RTE_LOG*() macros, the log messages are prefixed by the logtype.
>
> RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "zxdh rx %s(): ", ...
> will emit messages like "ZXDH_RX: zxdh rx %s(): ...\n"
>
> There is no need to add a prefix repeating the same information.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Note: this is not a big issue, but can this be squashed in relevant
> commit in next-net before reaching main? Thanks.
>
Squashed into relevant commit in next-net, thanks.
prev parent reply other threads:[~2024-11-06 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 9:08 David Marchand
2024-11-06 9:41 ` Junlong Wang
2024-11-06 10:29 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce273b0-5c20-467e-a6f4-dd616fbdab85@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=shan.lijie@zte.com.cn \
--cc=wang.junlong1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).