From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0B3772986
 for <dev@dpdk.org>; Wed, 17 May 2017 13:21:46 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga104.jf.intel.com with ESMTP; 17 May 2017 04:21:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,354,1491289200"; d="scan'208";a="87881545"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga002.jf.intel.com with ESMTP; 17 May 2017 04:21:44 -0700
To: Michael Lilja <ml@napatech.com>, dev@dpdk.org
References: <20170517091212.6503-1-ml@napatech.com>
 <20170517103807.18746-1-ml@napatech.com>
Cc: Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <1cf09930-e77c-f71e-db29-d5cdce352fd8@intel.com>
Date: Wed, 17 May 2017 12:21:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170517103807.18746-1-ml@napatech.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: improved FDIR programming times
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 May 2017 11:21:47 -0000

On 5/17/2017 11:38 AM, Michael Lilja wrote:
> Previously, the FDIR programming time is +11ms on i40e.
> This patch will result in an average programming time of
> 22usec with a max of 60usec .
> 
> Signed-off-by: Michael Lilja <ml@napatech.com>

Please keeps maintainers in CC while sending patches.

> 
> ---
> v5:
> * Reinitialization of "i" inconsistent with original intent

It can be useful to keep history about older versions.

> ---

There are two checkpatch warnings, can you please fix them [1], you can
keep Beilei's ack in next version.

[1]
WARNING:LONG_LINE: line over 80 characters
#39: FILE: drivers/net/i40e/i40e_fdir.c:1299:
+       for (i = 0; i < (I40E_FDIR_WAIT_COUNT *
I40E_FDIR_WAIT_INTERVAL_US); i++) {

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#67: FILE: drivers/net/i40e/i40e_fdir.c:1319:
+       return -ENOSYS;

<...>