From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0900C42D91; Fri, 30 Jun 2023 03:05:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F50C410FD; Fri, 30 Jun 2023 03:05:27 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 73A6640150; Fri, 30 Jun 2023 03:05:25 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QscVC5lhwzMn4m; Fri, 30 Jun 2023 09:02:11 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 09:05:23 +0800 Subject: Re: [PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config To: Ferruh Yigit , , , References: <20230626124332.28157-1-liudongdong3@huawei.com> <20230629132127.7508-1-liudongdong3@huawei.com> <20230629132127.7508-3-liudongdong3@huawei.com> CC: , From: Dongdong Liu Message-ID: <1d35d8e3-1bd6-7301-eba3-e33fd35cc8a6@huawei.com> Date: Fri, 30 Jun 2023 09:05:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh On 2023/6/29 23:52, Ferruh Yigit wrote: > On 6/29/2023 2:21 PM, Dongdong Liu wrote: >> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst >> index 5373ec5a8f..001ccbdb62 100644 >> --- a/doc/guides/nics/hns3.rst >> +++ b/doc/guides/nics/hns3.rst >> @@ -140,6 +140,32 @@ Runtime Configuration >> For example:: >> -a 0000:7d:00.0,mbx_time_limit_ms=600 >> >> +- ``fdir_vlan_match_mode`` (default ``strict``) >> + >> + Used to select VLAN match mode. This runtime config can be ``strict`` >> + or ``nostrict`` and is only valid for PF devices. >> + If driver works on ``strict`` mode (default mode), hardware does strictly >> + match the input flow base on VLAN number. >> + >> + For the following scenarios with two rules: >> + >> + .. code-block:: console >> + >> + rule0: >> + pattern: eth type is 0x0806 >> + actions: queue index 3 >> + rule1: >> + pattern: eth type is 0x0806 / vlan vid is 20 >> + actions: queue index 4 >> + >> + If application select ``strict`` mode, only the ARP packets with VLAN >> + 20 are directed to queue 4, and the ARP packets with other VLAN ID >> + cannot be directed to the specified queue. If application want to all >> + ARP packets with or without VLAN to be directed to the specified queue, >> + application can select ``nostrict`` mode and just need to set rule0. >> + >> + For example:: >> + -a 0000:7d:00.0,fdir_vlan_match_mode=nostrict> > > '::' doesn't provide pre-formatted text without an empty line after it, > I will fix this while merging, but other device argument documentations > have same problem, can you please send a patch to fix it? Thanks for pointing this and helping fix it. I will send a patch to fix the remain issue. Thanks, Dongdong. > > . >