From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E08E1A0351; Mon, 10 Jan 2022 11:17:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C6A3426E2; Mon, 10 Jan 2022 11:17:23 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 5EA484013F; Mon, 10 Jan 2022 11:17:20 +0100 (CET) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JXV8r0cx3z9s9K; Mon, 10 Jan 2022 18:16:12 +0800 (CST) Received: from dggpemm500013.china.huawei.com (7.185.36.172) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 18:17:18 +0800 Received: from dggpemm500008.china.huawei.com (7.185.36.136) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 18:17:18 +0800 Received: from dggpemm500008.china.huawei.com ([7.185.36.136]) by dggpemm500008.china.huawei.com ([7.185.36.136]) with mapi id 15.01.2308.020; Mon, 10 Jan 2022 18:17:18 +0800 From: wangyunjian To: "Zhang, Qi Z" , "dev@dpdk.org" , "users@dpdk.org" , "Yang, Qiming" CC: Huangshaozhang , dingxiaoxiong Subject: RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up? Thread-Topic: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up? Thread-Index: AdgF0Pn/6qGT4vxjTVSzS48+AOJr4gAMyjXwAAGoDHA= Date: Mon, 10 Jan 2022 10:17:18 +0000 Message-ID: <1d42933cb44c4af58e31b55b03e8684f@huawei.com> References: <41f0c2c9f77348fbb22dad35ef155536@huawei.com> <559e14c286d240caa7e1649df9664843@intel.com> In-Reply-To: <559e14c286d240caa7e1649df9664843@intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.242.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z [mailto:qi.z.zhang@intel.com] > Sent: Monday, January 10, 2022 5:29 PM > To: wangyunjian ; dev@dpdk.org; users@dpdk.org; > Yang, Qiming > Cc: Huangshaozhang ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [dpdk-users] A question about the link status of = the intel > E810 nic can not be up? >=20 >=20 >=20 > > -----Original Message----- > > From: wangyunjian > > Sent: Monday, January 10, 2022 11:20 AM > > To: dev@dpdk.org; users@dpdk.org; Yang, Qiming > > ; Zhang, Qi Z > > Cc: Huangshaozhang ; dingxiaoxiong > > > > Subject: [dpdk-dev] [dpdk-users] A question about the link status of > > the intel > > E810 nic can not be up? > > > > Hi, All: > > > > I am using Intel E810 with DPDK v21.11 to create a dpdkbond but there > > is a probability that the failure will occur. > > > > During the test, the bonding is repeatedly added and deleted. > > Sometimes, the link status of the NIC is Down. And if call > > ice_dev_set_link_up again, the link status of the NIC can be recovered. > > > > Alternatively, the problem can be avoided by modifying the ice pmd driv= er. > > > > diff --git a/drivers/net/ice/ice_ethdev.c > > b/drivers/net/ice/ice_ethdev.c index > > 13a7a9702a..fcd22e20a5 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -3604,7 +3604,7 @@ ice_dev_start(struct rte_eth_dev *dev) > > ice_dev_set_link_up(dev); > > > > /* Call get_link_info aq commond to enable/disable LSE */ > > - ice_link_update(dev, 0); > > + ice_link_update(dev, 1); >=20 > This looks good to me, it's reasonable to wait for complete right after s= et link > up as it is not in an link status change interrupt handling scenario. >=20 > We will try to reproduce this issue, meanwhile could you help on followin= g > below 2 things. >=20 > 1. share the device ID / firmware version that you met this issue. # ethtool -i eth16 driver: ice version: 1.6.4 firmware-version: 3.10 0x8000ad4a 1.3106.0 expansion-rom-version:=20 bus-info: 0000:04:00.0 supports-statistics: yes supports-test: yes supports-eeprom-access: yes supports-register-dump: yes supports-priv-flags: yes # lspci -n -s 04:00.0 04:00.0 0200: 8086:159b (rev 02) > 2. send a v2 with reworded title and commit log as a normal patch if you = want > to contribute. OK, I'll send v2 patch to fix it. Thanks >=20 > Thanks > Qi >=20 > > > > pf->adapter_stopped =3D false;