From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FC1F43B67; Wed, 6 Mar 2024 21:53:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E08942EA2; Wed, 6 Mar 2024 21:53:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 8B72542E7A for ; Wed, 6 Mar 2024 21:53:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709758419; x=1741294419; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=wyNerrtGHqygNJJTU1yi2mAy/uEtRvETWCoKcYbel4c=; b=iWJ6LTa0L+oVJMp4yKnWFvjr5NQRv6xbqi8hdEAfZEmT8oUOqZIfiOZP XmGoHB0Xu7bPDfXQSsJsWEJBrMHC+N76lqYafL/KqLWMwYfZs5OXXuxSM uelO9HHgHo7cPJX8bO02aZbR14MFwuirEtYncAiutBcFb1p7WFQnlcKMB tvrmIQf3PXlGvYko1URkVDHAZqBB78GjSSQq12spax3BPuN8y5JXsSKAJ yqF1EyTdJE8PgjTXY0vDVR4DbjYirjrD0fpQx+GC9W+7y4zVye/dEjxqE BdSMoF+9lDjGv4b5AlU48NC/XJioChKxaU8xo+10sk7y6Rx+MGCL37TrF w==; X-IronPort-AV: E=McAfee;i="6600,9927,11005"; a="4521072" X-IronPort-AV: E=Sophos;i="6.06,209,1705392000"; d="scan'208";a="4521072" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:53:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,209,1705392000"; d="scan'208";a="40766040" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Mar 2024 12:53:33 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 12:53:30 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Mar 2024 12:53:30 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Mar 2024 12:53:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYdw+ZpDWac4evyYZ+SG0g+uKHbrTtg85Wqul9INVMMDxrqxSMX0Jfh+ALRuU3+wZrx6tYMluvYNPhpmPKyvWOvtTiiLIsQ7Dceut1Xfoie1oYTkB09toYB6kZoTKPG6iH4vzYRX2ewfHwswYyZ+QcJnvFOklaRdMolYZrx+0C9R9JHm4ChgIHgPJZrn2dRS/bd6DDYQfSpMLIgjSUbf6ooECF+wXbI9Uep/JnNrupgdBWu2hjnB1GHeYNMkUhNAj+qs89VWKY8D2YEo7YWTOXX0ozBIKSeJMeh5IsfsbDqEM6GDjOnXeh/cKxPa/2Y6bVz3/7ytcjnFCiKkNoF7sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yz83/kphEHR9LcfoXZfISaABESyycFLtWXtXfNbwpqs=; b=djTZ3ppUoY1Q2j6jLyaPP5YVNC0kj/TXVo3/6wmC/wI5v6AL1qSQbHXjVYZ1zAoGktuqOuMLIxjTbo+pMc1wHBRDJ0ViKPSBthHlws0f9gLz0h6fdRQ8AIl/4wI3czukj1HqWgMQzqKGB3UwsQHhU/6QZmMFy9M7xWU0SKiKZNP3AtxW4PjmIug7w7+mhoH9A4BpMfPHdjluNEy2OpWZi+eMzeMc2D47R/KHfd14unnFZJVkQ2/yN5v1PYytKax4/WyD8qZktcn3U3wWfsp2eWndHsg0OHf/i5aJF4tjR+W0/We/2IS4gvGhZmcXrjvVDOakWoumSzHS9SBgU3W/kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by SA1PR11MB6896.namprd11.prod.outlook.com (2603:10b6:806:2bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Wed, 6 Mar 2024 20:53:27 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::efb3:f2f6:caf5:9edc]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::efb3:f2f6:caf5:9edc%4]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024 20:53:27 +0000 Message-ID: <1d551014-873d-4a85-bf41-baa1574101ce@intel.com> Date: Wed, 6 Mar 2024 20:53:25 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/6] fib: replace zero length array with flex array Content-Language: en-US To: Tyler Retzlaff , CC: Bruce Richardson , Cristian Dumitrescu , Honnappa Nagarahalli , Sameh Gobriel , Yipeng Wang , , References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com> <1709756036-24068-4-git-send-email-roretzla@linux.microsoft.com> From: "Medvedkin, Vladimir" In-Reply-To: <1709756036-24068-4-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0053.eurprd04.prod.outlook.com (2603:10a6:10:234::28) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|SA1PR11MB6896:EE_ X-MS-Office365-Filtering-Correlation-Id: b7fc02ef-93e8-4b36-6bac-08dc3e1f78d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 15WqNI1rTAHxWTc0cBpv+WXpfrb7vYDzMYxVgAze4SX2qVauTVJqC19GlXsxZyZGo1JKUoGLsp5MxFSulZLEdnLFNUBWaBFvvCYu0cIrz4RxRAbXuvp/NXLdAH6hnKiLHoO37nRpHBCt5oD0ZRX1ONZmXT3PdjBYUglvKtw3Ds4JEZe9JZkP/9J4MAlpv2Zs0zLE25NuyJdhJj1efZB8ZSrMpLeGyknAAeBGBg2hhdgSx1cUA1vwAI3V4SYNuIXSzDHuPy1Dxe5jtT0M02yVpwCwGinx+4mAZzcI2Pn0gfDAxLZXUIbKnXm+R88+eN6NtcLwt56MnfoULAzJQDoKNdF2IakUeWdlS/+3qXVnv/SoxjH90K12ruUdROI+W8GrA5Mb41WrdBZACOnO8xKBVDaWafaJhsvgxj6t0eiJ+qSulXpEOIaIC8HKQBp19nQYjVsoMTicJynzHyKli17maiy0kXcj75DmWXvwsHLg1WJHaTqfWX1T2U5wI7ZdU/t53uCNhQRCTocxtnw5xMvubSWtb+S7FqfhaW8cxW6DUNy/w4D2bxr1RMs29llGK9ErFJ3dFHjsY4dDHUSV4J0Qfx6Z71T3h5EeN+4uavhe3Agtn53DIHm5S+sIBnFzvS7kO8y9wib0reNhEUzm5rd9VwgMNE9hHegdNDCNfWTBsWU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1p5MmtEL0M5dXFPMFF6MjFZck0vMVNtMkNGM3d6ejNiOG8rS1pvK0F3b1cw?= =?utf-8?B?bkYzbExFM1dBQnlMVXh1WHF6QjhidW9XdGxna0Vjakp3T0Y2ZzNrUXBmSGFN?= =?utf-8?B?NTVUa1NjOFBQaks4MWlVVlpwcjRmTzM2Y1hyalAvYk1HQms0L2ExVkpaYkNX?= =?utf-8?B?VHFraUpvMTY5Tkc3ejZXcTJIdHZyaFVjUFMrcGppTmtoNTNZSURBVjNwRFVo?= =?utf-8?B?Y2dTRkpGZGpqZ3hxejV2SFNyRXZIcy94RDZDamJDMkxpQjVpT2c4Q0I0K0NU?= =?utf-8?B?V0NoaGM1TExpaSsreGJXQys4QzN2cXlpeGRidzVyZkxaYXMwY3hNY3JaWjVQ?= =?utf-8?B?U2ZicUduUGo3a2VzNEo4US9yZmsrTUU0V1RKSUtvcHVkSmVlbzZyWmZDMmhW?= =?utf-8?B?RmVjK1BUT1JPWDdtMExYQ2VXYUNhaW1QRWxKRFVGZTViTnA5dEFaeEVyb2FJ?= =?utf-8?B?UkdlZkx1ZTR0OVZNMjc3amd0QVZER3VMZnpIMkpXTHM3eWZNeThoVzZ1MytQ?= =?utf-8?B?WWZ6VFMreVZSdFdvbEdlM0piV2trckdxbDE2NnVHRmtkd3RKYWRyRWFyNDdu?= =?utf-8?B?VjhzcTlyeUM1cE82cU5jVncxc1F1RERNWGtnVW5NSHNjdkRKMm0xVDJVY0Zv?= =?utf-8?B?VGNkMDRFcHlnNk10Z3VJREhpNDlrUytzQlg3ZElHQk1oTys4WXNXMUF3QnI0?= =?utf-8?B?eVRSaVpzWm1HWE5zMndhcjMvS0t2NmdKZUIvMVd5UXlMRWNXR1N2RFZSWFRt?= =?utf-8?B?ZFhCT3FFSmJUZnBuakpKNWVURW9XaE1NendPZkhvRElOUzlvYlJLa2NBVUVr?= =?utf-8?B?UDVsdmt0R09iblRtYjBNLzVkaFdCVmFsN3JPOVhLVWUxVzdHR21SM3ordWxk?= =?utf-8?B?eW9aUk43M25VL2diMmQxbnZvTEZXVGQ2OWxiRU1rTGJRNTZUNXhkNUJBeExw?= =?utf-8?B?MUdhUUFhU0krTzR3MDc5QS9JcVBYdXNLQm5JZHhuUFNvVHFIL1cySTVQZGE2?= =?utf-8?B?dzVENlRjQ1BNdE1sVFk4Nk9RbTh3bWZNUFJybDc0VXo4VWFNNFpqU2FrWGdv?= =?utf-8?B?SVVPUkRranJpb2cwSWhpT2JFRnRyNy82a0ppd1JDTk1oSUlxL25vNWN6NXQx?= =?utf-8?B?M1huR1RGQ3IySWNYNEgvTFpwSDBuVlc4NUh4T3VYSHlYQWNrZDZWZW5UaWpM?= =?utf-8?B?bHljM3VEZG8xcGVFSTkzNXdDaDk0dlZyZ0IvbHhQWjRXQWUxZFQzTlV3N0J4?= =?utf-8?B?b0h2aDV1UGxpa211Ui91cWwzWjEvNyszT2ZveVdiRU93c29QL2V2dDRmSGpN?= =?utf-8?B?OGxtS0g2emdQb0dUa2E2VnUxQzgwMW1qaUdjLzhNajllR2s5VHNlUGlZTXdu?= =?utf-8?B?RHdkTTEzOEtPeHZnaWZyYSs0cEFZcVBRQzhNanFQQmxEWjZKdlp4YWRIdVl3?= =?utf-8?B?cjN4dWhpb0pKZGM3WGdOQUI4OHFxbEFWMkdueUhUczFjV3JjQ2ZCRVVtWjJU?= =?utf-8?B?bCsrMitkRE1pblRuVE8xeTFCYVdidDZwUmlETlpsaFFPSDQzcUZ4NG5ST0xv?= =?utf-8?B?cGROd0tpeldoQy9EYlJpN1ljbVNTYjI4N05Fa3hwTnVZQmczMld0M2NyMHhZ?= =?utf-8?B?V1pHQVl4YTVRTVpoTHROOUtESFFpNkJQbU90UzlYQlhiRlU1dHhKQ00rZmtN?= =?utf-8?B?UnQ3RXNaVzRKQzJITGhuUzBEcjU5TTZTcnFZeFI0U1o1MmpPRTJZWnRpd0lv?= =?utf-8?B?N1U1L0Y5NmNZMzdQVVgvbnZFWnlOQkVKY0dmZ2RvQktxQ1R1SHNaazlHdXhX?= =?utf-8?B?TE1xUUlSZU1lZ2Q5MnVhbVJ0ZmpabTIycVRBZ1FrdzJYS1JadENNTHFHWldE?= =?utf-8?B?bVFmQzFLUUx0Nng3WTI2d3JUdTdZTVhWUWl0cWxHekhGTysxQThwNk5vU2pJ?= =?utf-8?B?R0twZnFqNFNTRnNVeG1YR0ZSRDNVQkNNYjhVOXQ1c2RPVTVrS2hZNXlBZWhJ?= =?utf-8?B?YVh6QmNVNHdwUm1yUVRSODZCbmxTNlhTUmMyaVlWZldSRDlDdVJIYXljZVRk?= =?utf-8?B?SzF4R2xnMStYMk9VR1pQR091bmV3TGNSaU5pdHBtVmNnWDUxK0VuQ3A4dTY3?= =?utf-8?B?QTNEaFR5UEtwaDZtd0ZYSzdhZisvbVgvbVM2SExocWdaOTFqR2NENnZTb0VN?= =?utf-8?B?NXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b7fc02ef-93e8-4b36-6bac-08dc3e1f78d0 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 20:53:27.3999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EIsH/14+bosihN3W75bWVsmZmcvBQ/Cw1t+WyR02sEHbuAIb0EsMKJQllv2inrUsCZlpsHIWJbzRns3AE8mpRExQ889Y9RaBANqO4xdvtAc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6896 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Vladimir Medvedkin On 06/03/2024 20:13, Tyler Retzlaff wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > Reviewed-by: Morten Brørup > Acked-by: Stephen Hemminger > --- > lib/fib/dir24_8.h | 2 +- > lib/fib/trie.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/fib/dir24_8.h b/lib/fib/dir24_8.h > index 6d350f7..7125049 100644 > --- a/lib/fib/dir24_8.h > +++ b/lib/fib/dir24_8.h > @@ -34,7 +34,7 @@ struct dir24_8_tbl { > uint64_t *tbl8; /**< tbl8 table. */ > uint64_t *tbl8_idxes; /**< bitmap containing free tbl8 idxes*/ > /* tbl24 table. */ > - __extension__ alignas(RTE_CACHE_LINE_SIZE) uint64_t tbl24[0]; > + alignas(RTE_CACHE_LINE_SIZE) uint64_t tbl24[]; > }; > > static inline void * > diff --git a/lib/fib/trie.h b/lib/fib/trie.h > index 36ce1fd..2c20184 100644 > --- a/lib/fib/trie.h > +++ b/lib/fib/trie.h > @@ -38,7 +38,7 @@ struct rte_trie_tbl { > uint32_t *tbl8_pool; /**< bitmap containing free tbl8 idxes*/ > uint32_t tbl8_pool_pos; > /* tbl24 table. */ > - __extension__ alignas(RTE_CACHE_LINE_SIZE) uint64_t tbl24[0]; > + alignas(RTE_CACHE_LINE_SIZE) uint64_t tbl24[]; > }; > > static inline uint32_t -- Regards, Vladimir