Re: [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value

["Mattias Rönnblom" <mattias.ronnblom@ericsson.com>]

On 2020-05-06 13:09, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
>
> number of enqueued events doesn't include events
> that were marked with RTE_EVENT_OP_RELEASE


You should have a complete sentence. "The returned number from 
rte_event_enqueue_*() wouldn't include events marked with 
RTE_EVENT_OP_RELEASE.", or something like that.


Other than that:

Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>


> Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
>   drivers/event/dsw/dsw_event.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> index e5e3597aa..611b36781 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
>   	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
>   			"accepted.\n", num_non_release);
>   
> -	return num_non_release;
> +	return (num_non_release + num_release);
>   }
>   
>   uint16_t