From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8650D1B6B3 for ; Fri, 3 Nov 2017 16:56:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DBA5E5F7AF; Fri, 3 Nov 2017 15:56:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DBA5E5F7AF Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D7CA5D98D; Fri, 3 Nov 2017 15:56:44 +0000 (UTC) To: dev@dpdk.org, yliu@fridaylinux.org, lei.a.yao@intel.com Cc: mst@redhat.com References: <20171103155235.29869-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com> Date: Fri, 3 Nov 2017 16:56:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171103155235.29869-1-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 03 Nov 2017 15:56:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 15:56:52 -0000 Hi Lei, On 11/03/2017 04:52 PM, Maxime Coquelin wrote: > If multiple queue pairs are created but all are not used, the > device is never started, as unused queues aren't enabled and > their ring addresses aren't translated. The device is changed > to running state when all rings addresses are translated. > > This patch fixes this by postponning rings addresses translation > at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES > being negotiated or not. > > Reported-by: Lei Yao > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 33 ++++++++------------------------- > 1 file changed, 8 insertions(+), 25 deletions(-) Could you confirm the patch fixes the issue on your side? I tested below cases with and without IOMMU: - Host DPDK queues = 1 / QEMU queues = 1 / Guest DPDK queues = 1 - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 1 - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 2 Thanks, Maxime