From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EECEA034C; Fri, 29 Apr 2022 10:02:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2E41415D7; Fri, 29 Apr 2022 10:02:30 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id B6D18410E3 for ; Fri, 29 Apr 2022 10:02:28 +0200 (CEST) Received: from kwepemi100013.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KqPwv5ZFXzCsV1; Fri, 29 Apr 2022 15:57:51 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi100013.china.huawei.com (7.221.188.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 29 Apr 2022 16:02:26 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 29 Apr 2022 16:02:26 +0800 Message-ID: <1d828455-1e65-7b32-f267-e2b63b0a35d0@huawei.com> Date: Fri, 29 Apr 2022 16:02:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH V1 1/2] app/testpmd: fix supported RSS offload display To: David Marchand CC: dev , Thomas Monjalon , , Andrew Rybchenko , References: <20220425092523.52338-1-lihuisong@huawei.com> <20220425092523.52338-2-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2022/4/29 15:27, David Marchand 写道: > On Mon, Apr 25, 2022 at 11:26 AM Huisong Li wrote: >> @@ -773,20 +787,8 @@ port_infos_display(portid_t port_id) >> if (!dev_info.flow_type_rss_offloads) >> printf("No RSS offload flow type is supported.\n"); >> else { >> - uint16_t i; >> - char *p; >> - >> - printf("Supported RSS offload flow types:\n"); >> - for (i = RTE_ETH_FLOW_UNKNOWN + 1; >> - i < sizeof(dev_info.flow_type_rss_offloads) * CHAR_BIT; i++) { >> - if (!(dev_info.flow_type_rss_offloads & (1ULL << i))) >> - continue; >> - p = flowtype_to_str(i); > This patch removes the only call to flowtype_to_str not under #if > defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE). > > As reported by the CI, it breaks compilation when disabling net/i40e > and net/ixgbe drivers because it results in a static unused symbol > left behind. > > FAILED: app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o > ccache gcc -Iapp/a172ced@@dpdk-testpmd@exe -Iapp -I../app -Ilib/ethdev > -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include > -I../lib/eal/include -Ilib/eal/linux/include > -I../lib/eal/linux/include -Ilib/eal/x86/include > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry > -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool > -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter > -Ilib/cmdline -I../lib/cmdline -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Ilib/bpf > -I../lib/bpf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 > -Wall -Winvalid-pch -Wextra -Werror -O2 -g -include rte_config.h > -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral > -Wformat-security -Wmissing-declarations -Wmissing-prototypes > -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-missing-field-initializers -D_GNU_SOURCE -march=corei7 > -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ > 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -MF > 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o.d' -o > 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -c > ../app/test-pmd/config.c > ../app/test-pmd/config.c:5506:1: error: ‘flowtype_to_str’ defined but > not used [-Werror=unused-function] > flowtype_to_str(uint16_t flow_type) > ^~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > > Please fix by removing the unnecessary fwd declaration of this symbol, > then moving flowtype_to_str function under the #if > defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) check. > > I marked this patch as changes requested, thanks. This is a little hidden. I'll fix it, thanks. > >