From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F94B459D7; Thu, 19 Sep 2024 16:35:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21391432C2; Thu, 19 Sep 2024 16:35:13 +0200 (CEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mails.dpdk.org (Postfix) with ESMTP id 190D2406FF for ; Thu, 19 Sep 2024 16:35:11 +0200 (CEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2f75aa08a96so10674491fa.1 for ; Thu, 19 Sep 2024 07:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1726756510; x=1727361310; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CYRH/PxYf2TtnBLJhArGmV45LoGdLr3oZUybddP4F6g=; b=mhEMwbcGlHnxntmkgXUkWntAbi14OyA/WdFPTiikDNH1ohPvinHuw3Yx7p4+XEBU/O xRAmvySRgLW1GUzLgxdMv5DBA6z4sz6LgxoErPKk4OnUDj0BDcPPVWraFTFWgh0Q1uht Eclx0hOeyJjIAJXtuBYj/fbEh2o/vbxAHXB8y1v8cUlWGbAHN6j+Ep4sWBYVb4PfQUL0 2loqcHokT1pqnM3M4lJGLqeNaEPOR0ZfN0QhFvNV084hiPXVMRRvYN3rAOox25QwblJh gpjpkuB03QqEqM4JOA14n0iip+aJE3B3F5whrG803lzFH/uHHDwmTeo0wxt5zlSEwd6G Rtaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726756510; x=1727361310; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CYRH/PxYf2TtnBLJhArGmV45LoGdLr3oZUybddP4F6g=; b=ifeUW5rRHNMcNekZj2oT115d87Wl/j2NnTS0QucTsBK1Jp/5t496iU351FZ/tLoGy2 +gCP6PJRCAoKIIoPnTQe4DKL69C31Lc2Xt34ATugXJhmIxjabs+zjkqhBw3IgdoUq200 ECh6LAPJL64sokzzyyNl6eIKMvNMsSqDi5Q/D1JcnxUORnEzl9pv+7VLFSVkZ42YoVZu u8v6dyFzyC3m4hygU3Ox306DviPu5a2JNWLtJ1SI8R/tLLTKabnL+3F/y7gES4obIgiC QGlQe8ow8rFS30ow7+1qIV9Ucbov0atU7mbBedvsMW3oGrUUCmwn5mal/lcIMV3UNHca 3oGQ== X-Gm-Message-State: AOJu0YwgwttpVDtFGLe1IZC14U7zI4dtIzTYZcgy/VbMjD3rAdiwbIpS qy6RnJTdYr96+aRGmkOEMkv4UNDfrP3LZtDM5Uf5JrkdE8lnGfKVMgCwPpg3bIA= X-Google-Smtp-Source: AGHT+IHm/ijSiz9Yydv5IL5inJobOiQNyZi6Kik3eMe0Yq1Tll2b3h4Akm61zem7w5qLwsVeYIYK3A== X-Received: by 2002:a2e:611:0:b0:2f3:cd4e:b929 with SMTP id 38308e7fff4ca-2f787f1cbe0mr111575781fa.34.1726756510503; Thu, 19 Sep 2024 07:35:10 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb8c8d7sm6104527a12.64.2024.09.19.07.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Sep 2024 07:35:10 -0700 (PDT) Message-ID: <1d850e93-c2fc-49d5-b3e7-baedf0373adf@pantheon.tech> Date: Thu, 19 Sep 2024 16:35:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] dts: fix runner target in the Dockerfile To: jspewock@iol.unh.edu, probb@iol.unh.edu, Luca.Vizzarro@arm.com, thomas@monjalon.net, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, paul.szczepanek@arm.com, wathsala.vithanage@arm.com Cc: dev@dpdk.org References: <20240911155058.11321-1-jspewock@iol.unh.edu> <20240919142438.10192-1-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240919142438.10192-1-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 19. 9. 2024 16:24, jspewock@iol.unh.edu wrote: > From: Jeremy Spewock > > Currently the runner target in the Dockerfile attempts to run the > `poetry install` command when building the image, but this fails due to > poetry not being found in the container. Poetry is installed in a > previous step with pipx, but doing so adds the binary to use poetry to > ~/.local/bin which isn't present in the PATH variable in the container > image. The command `pipx ensurepath` fixes this issue in most cases, but > it requires a restart of the shell in order for the changes to take > place which is not something that can be done in the runner target. To > solve this problem this patch manually adds ~/.local/bin to PATH in the > runner target. > > Additionally, the command for installing poetry in the runner target > uses a depreciated flag, and the --revision parameter does not work with > the runner target. To address these problems the --no-dev flag is > removed in this patch and replaced with the new method of doing the same > thing and git is added to the base target of the image. The CMD of the > runner target is also replaced with an ENTRYPOINT for ease of use. > > Fixes: 19082c1fac43 ("dts: add Dockerfile") > Cc: juraj.linkes@pantheon.tech > > Signed-off-by: Jeremy Spewock Applied to next-dts after adding review-by tags. Thanks.