From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2182745957; Tue, 10 Sep 2024 16:12:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F75242DC3; Tue, 10 Sep 2024 16:12:22 +0200 (CEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mails.dpdk.org (Postfix) with ESMTP id 3EBD1402AB for ; Tue, 10 Sep 2024 16:12:20 +0200 (CEST) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7a81bd549eso88767666b.3 for ; Tue, 10 Sep 2024 07:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725977540; x=1726582340; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4XOcLDDZq0VeMG7VrTzrq/V4rXvUuN/GWNzQmTum7r8=; b=R3LUuqxCy+68Auu7q2PfyxL9k7jbBeuyvgMCKOqtDe5gnumb+YptfUhvjji32YWwmb bM0ilWTYsQGZTGkoo5eFirMva+rthbKAnIOWr6EOYePSvsX2n+mLbZvh8uza4ca6xXf1 phDe/2Pppm2LjEQAGuucp55n5TbYKRPnfHzTB/j8itZBTqJ7fPcrF2+rwfFR5NaiXZSC wbtc1ciqjJsfWgpVa9UrTFqpsaJWWvUS4yhXNih49VqMYmp+UsJdq4i58FIhwwftLvVM uU2plXYoyA9hVOFkJk9kXm4Bg4od5ZVmf248zLBosTrS1Bge9vojvki2nWghFMMwWAxv YBGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725977540; x=1726582340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4XOcLDDZq0VeMG7VrTzrq/V4rXvUuN/GWNzQmTum7r8=; b=PcdBvdapgNQlSHwPDmRLofduuFJT/Cunqfe3ZhB2XHvp2tS0pTsdvUXUVDPnG1KEpW tZP5E+iWa+H1NuB6AuiwSLocLgodXqVn/lkwTIRR/n1TQCn2z8j15O10Ve4FMn78I9bw 0vyoycyZaaGottUPAFBgIassvKn/1pAD2XOOG4tb3wOEQizan54FWlrB46cWZJTjk/pJ f/npZyQjJ8bFqcnxvQENYoDr1gbR9ksaU7W+dIUqA+EaViws/MBfd+2erXZCrQkpUEAH Msuqw6mizNRtNoRL8R/Q3ZBDJ+rtkictrz/Ji7T9SWcjx6sV60k19cMBtwXvipB6zFr0 T3Pw== X-Gm-Message-State: AOJu0YyFkBaV524GKZGkGo/epjAxHbXSB7I2NF/0JSPEk8f0zJp0e01O trPbOaQSSGqPf1GrcFWqmV9RD2XBjdKFrBZqEmxbC34oxoIP4rp+zSt3sIYfrn8= X-Google-Smtp-Source: AGHT+IFpuV84TFYu5qGhw1yq05r9bxdVz3oZdS0chMVA2Rqx4JGELdMAzDLhCGA8m7bF2wu4ZA2J3g== X-Received: by 2002:a17:907:3682:b0:a8d:439d:5c25 with SMTP id a640c23a62f3a-a8ffaab09d2mr127901966b.4.1725977539512; Tue, 10 Sep 2024 07:12:19 -0700 (PDT) Received: from [192.168.0.113] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d2595119bsm486381266b.61.2024.09.10.07.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 07:12:18 -0700 (PDT) Message-ID: <1d8bed79-82d0-456e-97f9-3dc427ae46f0@pantheon.tech> Date: Tue, 10 Sep 2024 16:12:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] dts: add conditional behavior for test suite To: Nicholas Pratte , probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-12-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240705171341.23894-12-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5. 7. 2024 19:13, Nicholas Pratte wrote: > There is some odd functionality/behavior in how the --test-suite > parameters interacts in conjunction with the 'test_suites' attribute in > the config file. If a user leaves an empty list underneath > 'test_suites,' or if they negate the attribute entirely, even if said > user adds test suites via the --test-suite parameter, a schema violation > is thrown. > > This patch mitigates this, by removing the schema requirement if the > user has indicated test suites within main.py parameters, allowing for > the 'test_suites' attribute to be optional. > Nice idea, doesn't look like there's any hard in adding it. Should we document this (the fact that it could be optional under certain circumstances) somewhere, like add something to the description in schema? > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte > --- > dts/framework/config/__init__.py | 7 ++++++- > dts/framework/runner.py | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py > index ed1c979fb6..82182b5c99 100644 > --- a/dts/framework/config/__init__.py > +++ b/dts/framework/config/__init__.py > @@ -553,7 +553,7 @@ def from_dict(cls, d: ConfigurationDict) -> Self: > return cls(test_runs=test_runs) > > > -def load_config(config_file_path: Path) -> Configuration: > +def load_config(config_file_path: Path, test_suites: list[TestSuiteConfig]) -> Configuration: The variable should maybe contain that these test suites are not from config_file_path. Maybe just rename to other_test_suites? Or something like that. Also, it needs to be added to Args: