From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAC78A034F; Wed, 24 Feb 2021 13:29:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A44C14069B; Wed, 24 Feb 2021 13:29:29 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7A2E040042 for ; Wed, 24 Feb 2021 13:29:28 +0100 (CET) IronPort-SDR: iPxPSRJIYgVo8CfRnBxAds1LBENenWscqwKYyEyOmcJDufYBD0roByFPUXpdDb3Gm0zSZfHHdm DE/aJP6N1/HQ== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="172278173" X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="172278173" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 04:29:27 -0800 IronPort-SDR: GnAfZaftAjJsFR4KapZDaJ/h86HybKxwHQGwurgaGgbNVq0iIa4jNtlXzVLubHGai8oXb0QDPZ hD2w+55X0YBg== X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="442051909" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.253.18]) ([10.213.253.18]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 04:29:26 -0800 To: "Li, Xiaoyun" , "Lu, Wenzhuo" , "Iremonger, Bernard" Cc: "dev@dpdk.org" References: <20210205142650.1106807-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <1d905352-0358-a395-b3bf-3f062a14d8a3@intel.com> Date: Wed, 24 Feb 2021 12:29:22 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/7/2021 1:58 AM, Li, Xiaoyun wrote: > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Friday, February 5, 2021 22:27 >> To: Lu, Wenzhuo ; Li, Xiaoyun ; >> Iremonger, Bernard >> Cc: Yigit, Ferruh ; dev@dpdk.org >> Subject: [PATCH] app/testpmd: remove duplicated offload display >> >> "show port cap all|" was to display offload configuration of port(s). >> >> But later two other commands added to show same information in more >> accurate way: >> show port (port_id) rx_offload configuration show port (port_id) tx_offload >> configuration >> >> These new commands can both show port and queue level configuration, also >> with their capabilities counterparts easier to see offload capability and >> configuration of the port in similar syntax. >> >> So the functionality is duplicated and removing this version, to favor the new >> commands. >> >> Another problem with this command is it requires each new offload to be added >> into the function to display them, and there were missing offloads that are not >> displayed, this requirement for sure will create gaps by time as new offloads >> added. >> >> Signed-off-by: Ferruh Yigit > > Acked-by: Xiaoyun Li > Applied to dpdk-next-net/main, thanks.