From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Simei Su <simei.su@intel.com>, <qi.z.zhang@intel.com>,
<jingjing.wu@intel.com>, <xiaolong.ye@intel.com>,
<ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add symmetric toeplitz hash support
Date: Tue, 1 Oct 2019 16:36:20 +0300 [thread overview]
Message-ID: <1d97be6e-b8fc-b02b-382e-e651deee6fb0@solarflare.com> (raw)
In-Reply-To: <1569921733-10631-2-git-send-email-simei.su@intel.com>
On 10/1/19 12:22 PM, Simei Su wrote:
> Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash function.
> To support symmetric hash by rte_flow RSS action, this patch adds
> new hash function "Symmetric Toeplitz" which is supported by some hardware.
>
> Signed-off-by: Simei Su <simei.su@intel.com>
> Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_ethdev/rte_flow.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 354cb1d..ca4e868 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1814,6 +1814,12 @@ enum rte_eth_hash_function {
> RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
> RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
> RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
> + /**
> + * Symmetric Toeplitz: src, dst will be replaced by
> + * xor(src, dst). For the case with src/dst only,
> + * src or dst address will xor with zero pair.
> + */
> + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> RTE_ETH_HASH_FUNCTION_MAX,
> };
It looks like symmetric does not make sense in the case of src/dst only.
The goal of symmetric function is to make it the same for both directions.
next prev parent reply other threads:[~2019-10-01 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 4:57 [dpdk-dev] [PATCH 0/2] " simei
2019-07-25 4:57 ` [dpdk-dev] [PATCH 1/2] ethdev: " simei
2019-07-31 12:08 ` Andrew Rybchenko
2019-07-31 12:30 ` Adrien Mazarguil
2019-07-31 13:03 ` Andrew Rybchenko
2019-07-31 13:43 ` Shahaf Shuler
2019-09-29 11:51 ` Andrew Rybchenko
2019-09-30 3:12 ` Su, Simei
2019-09-30 6:14 ` Andrew Rybchenko
2019-09-30 6:34 ` Su, Simei
2019-09-30 7:49 ` Zhang, Qi Z
2019-07-25 4:57 ` [dpdk-dev] [PATCH 2/2] app/testpmd: " simei
2019-07-26 0:55 ` [dpdk-dev] [PATCH v2 0/2] " simei
2019-07-26 0:55 ` [dpdk-dev] [PATCH v2 1/2] ethdev: " simei
2019-09-28 18:32 ` Ori Kam
2019-07-26 0:55 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: " simei
2019-09-28 18:39 ` Ori Kam
2019-09-24 5:30 ` [dpdk-dev] [PATCH v2 0/2] " Zhang, Qi Z
2019-10-01 9:22 ` [dpdk-dev] [PATCH v3 " Simei Su
2019-10-01 9:22 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Simei Su
2019-10-01 13:36 ` Andrew Rybchenko [this message]
2019-10-01 9:22 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: " Simei Su
2019-10-01 15:06 ` [dpdk-dev] [PATCH v3 0/2] " Ferruh Yigit
2019-09-23 23:11 ` [dpdk-dev] [PATCH " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d97be6e-b8fc-b02b-382e-e651deee6fb0@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).