From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 0CAD38DA9 for ; Thu, 26 Apr 2018 18:06:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51C4840201A1; Thu, 26 Apr 2018 16:06:58 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EA42946A9; Thu, 26 Apr 2018 16:06:56 +0000 (UTC) To: Arnon Warshavsky , thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org References: <1524518942-1998-1-git-send-email-arnon@qwilt.com> <1524518942-1998-6-git-send-email-arnon@qwilt.com> From: Kevin Traynor Organization: Red Hat Message-ID: <1db20a32-5e21-4142-75cc-7366c64d3bbe@redhat.com> Date: Thu, 26 Apr 2018 17:06:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1524518942-1998-6-git-send-email-arnon@qwilt.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 26 Apr 2018 16:06:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 26 Apr 2018 16:06:58 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 05/11] eal: replace rte_panic instances in eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 16:06:59 -0000 On 04/23/2018 10:28 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +++++--- > lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +++++--- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index 8fb6138..6e08705 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -66,9 +66,11 @@ > RTE_CACHE_LINE_SIZE, > rte_socket_id()); > > - if (eventdev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (eventdev->data->dev_private == NULL) { > + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data", > + __func__); > + return -ENOMEM; > + } > } Similar to 1/11 in that there is some allocate before this and maybe you should jump to the release at the end of the function > > eventdev->dev = &pci_dev->device; > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > index 8c64a06..b7c08fa 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > @@ -61,9 +61,11 @@ > RTE_CACHE_LINE_SIZE, > socket_id); > > - if (eventdev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private device" > - " data"); > + if (eventdev->data->dev_private == NULL) { > + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data", > + __func__); > + return NULL; > + } > } > > return eventdev; >