From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 362C32C31 for ; Thu, 29 Dec 2016 10:40:36 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 29 Dec 2016 01:40:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,426,1477983600"; d="scan'208";a="207791132" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by fmsmga004.fm.intel.com with ESMTP; 29 Dec 2016 01:40:35 -0800 To: Yuanhan Liu References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-4-git-send-email-jianfeng.tan@intel.com> <20161226062821.GB19288@yliu-dev.sh.intel.com> <20161226075745.GF19288@yliu-dev.sh.intel.com> Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "Liang, Cunming" From: "Tan, Jianfeng" Message-ID: <1e08318c-d8fc-2c0c-a365-fb94d0a450b0@intel.com> Date: Thu, 29 Dec 2016 17:40:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161226075745.GF19288@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/7] net/virtio_user: move vhost user specific code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2016 09:40:37 -0000 Hi Yuanhan, On 12/26/2016 3:57 PM, Yuanhan Liu wrote: > On Mon, Dec 26, 2016 at 06:58:58AM +0000, Tan, Jianfeng wrote: >> >>> -----Original Message----- >>> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] >>> Sent: Monday, December 26, 2016 2:28 PM >>> To: Tan, Jianfeng >>> Cc: dev@dpdk.org; Yigit, Ferruh; Liang, Cunming >>> Subject: Re: [PATCH v2 3/7] net/virtio_user: move vhost user specific code >>> >>> On Fri, Dec 23, 2016 at 07:14:22AM +0000, Jianfeng Tan wrote: >>>> To support vhost kernel as the backend of net_virtio_user in coming >>>> patches, we move vhost_user specific structs and macros into >>>> vhost_user.c, and only keep common definitions in vhost.h. >>> Good. >>> >>>> Besides, remove VHOST_USER_MQ feature check, it will be added back >>>> in following multiqueue patch. >>> Why then? >> Only vhost user recognizes this feature bit, and vhost kernel does not. My intension is to put those vhost user specific code inside vhost user. > That's okay. But why you have to remove it and then add it back? After second thought , I agree that it's necessary to add it back. Currently, our vhost does not implement the semantics of VHOST_USER_F_PROTOCOL_FEATURES. Besides, all other comments from you on this patch series will be addressed on next version. Thank you very much for those suggestions! Thanks, Jianfeng > > --yliu > >> And in fact, I forget to add it back. I should add it back in this patch. >> >> Thanks, >> Jianfeng >>> --yliu