From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D2B0A0548; Mon, 26 Apr 2021 14:26:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F06541104; Mon, 26 Apr 2021 14:26:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A87EE40140 for ; Mon, 26 Apr 2021 14:26:18 +0200 (CEST) IronPort-SDR: 1+DqR25A2C2jRzHoL/O1H4TC1Kjp5C6ZG4h1jdD39JgTWNLsKleTXfW3HPJD42hgwP++O8mDUs TKJW+lMZHOrw== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="196383866" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="196383866" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 05:26:13 -0700 IronPort-SDR: CDLB/fAO4JkDAm/X0IHe0VZTG8gevcuQhuJCgbSRsdHpS07hZyO2y2jPzMdL3NoaoYnzGGsBoC S24e3SYa5Q9g== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="402908471" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.240.23]) ([10.213.240.23]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 05:26:12 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619056552-43937-1-git-send-email-humin29@huawei.com> <1619056552-43937-4-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <1e1b9fac-51f7-7420-b67d-260e7865db3c@intel.com> Date: Mon, 26 Apr 2021 13:26:09 +0100 MIME-Version: 1.0 In-Reply-To: <1619056552-43937-4-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > The link fails code should be parsed using the structure > hns3_mbx_vf_to_pf_cmd, else it will parse fail. > > Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > drivers/net/hns3/hns3_mbx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c > index ba04ac9..0550c9a 100644 > --- a/drivers/net/hns3/hns3_mbx.c > +++ b/drivers/net/hns3/hns3_mbx.c > @@ -346,12 +346,13 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code) > } > > static void > -hns3pf_handle_link_change_event(struct hns3_hw *hw, > - struct hns3_mbx_pf_to_vf_cmd *req) > +hns3pf_handle_link_change_event(struct hns3_hw *hw, void *data) Why not s/struct hns3_mbx_pf_to_vf_cmd/struct hns3_mbx_vf_to_pf_cmd/ but change to parameter to "void *", wouldn't it reduce the type check? > { > #define LINK_STATUS_OFFSET 1 > #define LINK_FAIL_CODE_OFFSET 2 > > + struct hns3_mbx_vf_to_pf_cmd *req = data; > + > if (!req->msg[LINK_STATUS_OFFSET]) > hns3_link_fail_parse(hw, req->msg[LINK_FAIL_CODE_OFFSET]); > >