From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FAD2425A4; Fri, 15 Sep 2023 12:54:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 540DF402DE; Fri, 15 Sep 2023 12:54:21 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) by mails.dpdk.org (Postfix) with ESMTP id D7629402D7; Fri, 15 Sep 2023 12:54:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIAFzh1DQjXCqX0XXKFALZ75iqXT26ILCFyt1j57gJs56HKsjt3AXepIAAyOfq+8WKidz6lM/Z9TPVJw4Ww86ntX6MJ67iYnfIHd8WWrYkxA3aKPDd4/qX0/tr+bdSphfuYNznY7/xaDLVn6OxkFjqQYH+0YmIVCmHVZMMr+JQ621IphZ5H87YD0mnCugIMN/QbSOKA3/meWcgZ4sJQhoOfKsU+BAH1MhYaLFfQv6J7nhcADSfVTDk8KOV4cx8Vz5+ZZrlMPIJblhUVrjmzLWre2EevToxLDIc7rjQoEmFPeoWRNhEhV+sFcJJm+F2c9TfwONwg3i9iINuQCHDGQUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tFj5YKouKlQ6r9CvkqvJBU86QWksH7356hVDe3g7KT8=; b=gA390Ywlrzs/UAZbE0fmfrezcW0CCCSkiaqJa/hbBDgw2OGA8ei98m7+2j4aW3M6Lum8KXfaE+ZOEV+BeMKq3xZlZHl1JaUAD6TcAJ2sfqttIPVm7q8mljuL2m7LU2/cBtVhwd1m3eVToVUHRpKKWYBKEM4zyu6jAgxpguM4/Ufknbtb0vP8qQfNEolfz/zwbjye0prso+1cWAVV2qyqx1pvm2YBpwuBWhk2V6mdivDhK7YGVP8gn5tyz/e9w/seZsXrxa24fc3v0E3PDySsNzmgokNRad1v7zOie0P5pGX+yu/N9+7k0Kz/8Wcu6TeMqVYK263Ti1bLegGdnukdhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tFj5YKouKlQ6r9CvkqvJBU86QWksH7356hVDe3g7KT8=; b=QqHUGTyMOtABgK+qMoP+Cm8srgVKV/7qFFzkKSD3o4aw0HvY6l6QMXsiRLonTL4hQO5yI8dNN3tRQSuI4XqoplsEPYVvNG8OtNrThsvCn1VVugF/Leo9o5C8nepDE25qfLPFhrMvG1vAGULSkNEFHaAIPXIzT7CavqcvMhd9ukE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB8167.namprd12.prod.outlook.com (2603:10b6:a03:4e6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Fri, 15 Sep 2023 10:54:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 10:54:17 +0000 Message-ID: <1e1f06fd-c004-4612-90ba-c6322df27941@amd.com> Date: Fri, 15 Sep 2023 11:54:10 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/axgbe: use CPUID to identify cpu To: Selwin Sebastian , David Marchand Cc: stable@dpdk.org, dev@dpdk.org, Bruce Richardson References: <20230831123131.4787-1-selwin.sebastian@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230831123131.4787-1-selwin.sebastian@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0036.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB8167:EE_ X-MS-Office365-Filtering-Correlation-Id: 11d08534-ba09-4665-9423-08dbb5da1b4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EzT/9iSew08Pu5oKQZBb+i55+TgE7eyR4eQ0lXBIso7VkI3FXJHBcdZTsgpq/4kW9QtpZGsmCEXyScbeqvpHWSI6byYxqko5VRwcWj0PfdvNG8WY4Go17QGDC8RSJDa/4SKj4K5UxjiY1sC8Ii1voVm5H2o8KJ9TeNQtHrFjnvwmewFxBdTT2Wbzf6UyrCFpwyZou3wkj3PLdQHmUdG/ESNWs1GzoUIUqbS86K3qSgpP1PMPDf1L72HRVOrndjz7o9+q3IQUGqcmvYRa0Fwgk49osS7bRFPrCZIB+VexrqQFJU8oKuQ5s7aJKGv7WNXGB6NcVso652tpx96DRJ3c+YhZjAbhkmyHcyqC5AWPaerbRZhTU2msYAJvohmmZttWakM+h5RSau0BMtFSmXLq+vi2uAdHY8CRySWGwzFNPNzLJbr9s+o0VSJJ8MMrYx+lDAm7s16SuPwTdokOIgVB6os065n47l4RUv9cXPVxZ5rAoP6OAl3JqM1qydsEbLY4aT1IkzyRo7NBdar/shkLlWRP5clJuwLSKhvWlcGKNOuhX9N3UqL1ii3E3g1uZianhXtmwunkAFPeQW98PcrPcnLXzrjlIAIv3wfgf/qi8dxFQ6RzKbDR5gOpeWyiYdPoJZEPRwGclLIgxePPTV3jFA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(136003)(366004)(346002)(39860400002)(1800799009)(186009)(451199024)(6486002)(6666004)(6506007)(53546011)(478600001)(83380400001)(44832011)(6512007)(26005)(2616005)(2906002)(66946007)(66476007)(110136005)(5660300002)(8676002)(66556008)(316002)(8936002)(41300700001)(86362001)(38100700002)(31696002)(36756003)(4326008)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzJqRFZBZVdPeFRZUS9OWkF3UDlLZHRVK21JQ2hVR2xUMTVidEpOSjdHYnli?= =?utf-8?B?YVE3MllxWVJreWFDSVpsRWhOcXFqalduQkQ1by84NzQwdzZqeGt2T25LY250?= =?utf-8?B?Ulp0RWtsTjZKZHVSRlpmY0dzSjU4Vkw2TVgvS0hWTmlMS1AyWkVkS3BjeFlM?= =?utf-8?B?aE5LU1ZvSXE4cytCT3E2WndLdkpFazVTQ2hSVEFkVXNLVnhCbTJOclQxQW5E?= =?utf-8?B?Z01KWmUwOGVXb1JKUWY4ZkZaN0VOS2JKWWVvby9kRnNlQTJTWkRZL2JsbkVw?= =?utf-8?B?KyszYm9zNTdlL3ZXV2JBcGtIS3k5eS80U3NvZGVOUHhLWm91NTNqdUdPTzI3?= =?utf-8?B?WU5md2E5eG9jUjF2VUJ0Y2xIRi9wNVRDTlJOQ1lXVjZHRVFtWk96Q0dOMHA4?= =?utf-8?B?ejhCRHRGZFNOYVVMWUJmYmNxTThteStXUmtGSmdvL1RpZ29WbXpWSGFyd0lk?= =?utf-8?B?Z0pValJ2aHZtbkNVelFlTml0TXN3L3M3V1hTUjlRdkFwZmp0WHFDdDN1NDJt?= =?utf-8?B?QXNPRTFOdTZ4Uys1OHl1OGFETlJ5cC9LOHFibzYwZGtWQ1J1TGZYNllIN0tn?= =?utf-8?B?MHFFZS9TdHF1VHlxejVXUXNKZ2E5Wm94dWF0WXk1cmpPa2dkdndyeENqMTY3?= =?utf-8?B?VnB3U0xvck9SN1lDcFBOTmlYU29tSDRtbmRkQVdFcHo3dXR5U01JVVVPVk5X?= =?utf-8?B?bE13MkhPZkZpTGJFZFJUWG1kWE1QVVJjeHVhRDhBQTJVRHBHdU43bTdkaVRk?= =?utf-8?B?bDc4RWtid2NzSjMyTmh6eE8zQUQ3R3RIM2RreEM0SDZuOTNrRG5QYmNqT3Az?= =?utf-8?B?Z1FvR0VyTVZ1eHJBTTlWRzdpRHB3ODE4emlSd29pREZjL2d5RTVqSU12eFh2?= =?utf-8?B?eG9Jd0g4SnpaVGhkRFhiU2VkS2h5S2JHL1kvOUhsQlcyNkNsVTBrUGhpa2oy?= =?utf-8?B?cDVBd1NuMHVybzVnMXpETm4xK3ZHaXo4bXdHYkIvSFNUaVlZQ1ZrQTY4T3JB?= =?utf-8?B?Y09uMU4wYUprRVNiYUUzL1hyQWlwN2wrL3ZlaXZtYjB3NXFyZkpDcTlkQU9m?= =?utf-8?B?Zkw0TTdXdklXckhNa05QbEI1cmpaUVdCL0s5ODlDa1ZJa2M0c1BuK0JCYUNx?= =?utf-8?B?N1Y3OWJJTHRhcUdraFJabjdIWXIvNHo0ZnFZbzlYb0RxRzl0RlFjUVBBaUU1?= =?utf-8?B?N2UxTzhUYldLTkdHM25KQTRxc3dLQ205ZUJ5Y2NZeUQ3ZWRMbVRvNU5GS1k1?= =?utf-8?B?L2V3eVFxVGpJbTdsbjcyVlpkNWE3RTFpcjZaRU1VWlhzSjRwNFlMcHU5Rnds?= =?utf-8?B?UndsdXk0Ynh6YzRhcUZoQTcyb2F0QU9SVXBBcDBsMjRpRFptVmUyTTFNc09w?= =?utf-8?B?SVdyQllOZXBFMjNwZWV5YmJUdkRiSFVJRGRCQkF3S09TUEloWm0rVDlUcFRa?= =?utf-8?B?WXJVYS8xRGQvVHZJb3FMQVVOcVJnOFRXMnhIazRhaWd3dTQ3ZmtxZ0M4aUFF?= =?utf-8?B?Sndldi9IZDB5azcwRkw3OHZJMkNyUWJ6OFRIRlYxamIyS2E1WUhnSVBiY0Rp?= =?utf-8?B?NDdwU1hOZWtSQkxacXhvK1VpWDFpamdlbVAwRWttR3VIUkhHdkRJdlRsVmd2?= =?utf-8?B?ZDVtTGIrc3I3TDNqbzJVZFpBcStxR1ZaTlNsSWw2K3hqd0p4WStrcEF6RSt1?= =?utf-8?B?MEdVUWdTWWtiaGN1K3F2a29NYkJGME04KzhZc0liTmJQQlBpNnBuSkdERG9C?= =?utf-8?B?OXZGY1E1ck0yb1hCRnMveFFrd0wvbGVKeVFqanVLLzNhZmVtTGxvUS90MzI2?= =?utf-8?B?RDJDUUdHNzJSRC9Hem9XYzBrUzMvUFp1bVVlTlpuR3lsY2x6aWxKSEk3ZStJ?= =?utf-8?B?bldTVnp2M1VJN0RXeXRDdlJDanB2MW1LcktrZXVZQU0xZUdxaysxSEtRdS8w?= =?utf-8?B?NkdISURTZ1Q0SWFsVWR2ei82czNxc0ZmaW1DYndMODdIZS95SWZTOUhoVnNx?= =?utf-8?B?R1hLbVdMcHd0S0RrMzhldm52TXlnNUFUVExqcXF6T3NuL2xBakNkdlZoR0lE?= =?utf-8?B?ZXZ6WUhVaDhRRVBjZ3FNWXdlS3VjUFpVbGVjNjBqNTlNY2hhdmpZVllFQ1Vr?= =?utf-8?Q?ZCoG0osFSkId7F6yK54V6SHMJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11d08534-ba09-4665-9423-08dbb5da1b4e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 10:54:17.3025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9jbHa3QVbrWbKhnacHIN3tTW5Ykw6vPd3vFE69db4kVfWE/P7yeEImkXGDpHAHPN X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8167 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/31/2023 1:31 PM, Selwin Sebastian wrote: > Using root complex to identify cpu will not work for vm passthrough. > CPUID is used to get family and modelid to identify cpu > > Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to distinguish device") > Cc: stable@dpdk.org > > Signed-off-by: Selwin Sebastian > --- > drivers/net/axgbe/axgbe_ethdev.c | 102 ++++++++++++++++++------------- > 1 file changed, 59 insertions(+), 43 deletions(-) > > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index 48714eebe6..59f5d713d0 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -12,6 +12,8 @@ > > #include "eal_filesystem.h" > > +#include > + > This patch cause build errors for some non x86 architecture, because of 'cpuid.h'. There is already a 'rte_cpuid.h' file that includes 'cpuid.h' and it is x86 only file. @Selwin, does it makes sense to implement the feature you are trying to get in eal/x86 level and use that API in the driver? For those eal/x86 APIs, they will be missing in other architectures, @David which one is better, to implement APIs for other architectures but those just return error, or restrict driver build to x86?