From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 5790C2B9E for <dev@dpdk.org>; Fri, 1 Mar 2019 08:40:52 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 10F6D4C008C; Fri, 1 Mar 2019 07:40:51 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Mar 2019 07:40:46 +0000 To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org> References: <20190228224754.26511-1-stephen@networkplumber.org> <20190228224754.26511-2-stephen@networkplumber.org> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <1e231d45-1f60-26f4-7c32-f89286773db9@solarflare.com> Date: Fri, 1 Mar 2019 10:40:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190228224754.26511-2-stephen@networkplumber.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24462.003 X-TM-AS-Result: No-0.483100-8.000000-10 X-TMASE-MatchedRID: u1zqiMeMcroOwH4pD14DsPHkpkyUphL9F43xkw8RMy1qv/+QKNcPLnzy gxarwJxuEDn8EJgbQzO1JbtVeGZHGMWRBQTcKnaHngIgpj8eDcC063Wh9WVqgjuUMbK1NdLP+gt Hj7OwNO2OhzOa6g8KrXNxbRoXBD1pvnr7vOf4QEe3b5ziPXABda+ti85rGMgTXNP1TEKaNW6PgC DbAY3P7tVH8LonOSWy/S2A05ietQe2WKPzVcog4dOscg+Ycji8 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.483100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24462.003 X-MDID: 1551426051-919SuaarzEaJ Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: replace snprintf with strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 01 Mar 2019 07:40:52 -0000 On 3/1/19 1:47 AM, Stephen Hemminger wrote: > The set_port_owner was copying a string between structures of the > same type, therefore the name could never be truncated (unless source > string was not null terminated). Use strlcpy which does it better. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>