From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0A70C475E for ; Fri, 9 Dec 2016 13:14:46 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 09 Dec 2016 04:14:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="38530789" Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.152]) by orsmga004.jf.intel.com with ESMTP; 09 Dec 2016 04:14:44 -0800 To: Thomas Monjalon , Zbigniew Bodek References: <1480851219-45071-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <4126251.ynkckbu1rM@xps13> <2cec934f-b645-be28-8e82-a271692260d0@caviumnetworks.com> <1683862.k80B36XYkt@xps13> Cc: dev@dpdk.org, zbigniew.bodek@caviumnetworks.com, pablo.de.lara.guarch@intel.com, jerin.jacob@caviumnetworks.com From: Declan Doherty Message-ID: <1e237126-c2b3-9fbd-af68-6f6f28c1592d@intel.com> Date: Fri, 9 Dec 2016 12:06:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1683862.k80B36XYkt@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 02/12] lib: add cryptodev type for the upcoming ARMv8 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 12:14:47 -0000 On 07/12/16 20:09, Thomas Monjalon wrote: > 2016-12-07 20:04, Zbigniew Bodek: >> On 06.12.2016 21:27, Thomas Monjalon wrote: >>> 2016-12-06 18:32, zbigniew.bodek@caviumnetworks.com: >>>> From: Zbigniew Bodek >>>> >>>> Add type and name for ARMv8 crypto PMD >>>> >>>> Signed-off-by: Zbigniew Bodek >>> [...] >>>> --- a/lib/librte_cryptodev/rte_cryptodev.h >>>> +++ b/lib/librte_cryptodev/rte_cryptodev.h >>>> @@ -66,6 +66,8 @@ >>>> /**< KASUMI PMD device name */ >>>> #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc >>>> /**< KASUMI PMD device name */ >>>> +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 >>>> +/**< ARMv8 CM device name */ >>>> >>>> /** Crypto device type */ >>>> enum rte_cryptodev_type { >>>> @@ -77,6 +79,7 @@ enum rte_cryptodev_type { >>>> RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ >>>> RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ >>>> RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ >>>> + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ >>>> }; >>> >>> Can we remove all these types and names in the generic crypto API? >>> >> >> Hello Thomas, >> >> I added another PMD type and therefore we need new, unique number for >> it. I'm not sure if I understand correctly what you mean here, so please >> elaborate. > > My comment is not specific to your PMD. > I think there is something wrong in the design of cryptodev if we need > to update rte_cryptodev.h each time a new driver is added. > There is no such thing in ethdev. > Hey Thomas, I've been meaning to have a look at removing this enum, I just haven't had the time as yet, I think since there is now a standard naming convention for all pmds, the use for this is redundant. This change will require a ABI/API deprecation notice, so I'll put that into 17.02 and then do the patches to remove for 17.05 Declan