Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/10/2018 12:56 PM, Wei Dai wrote:
> This patch check if a input requested offloading is valid or not.
> Any reuqested offloading must be supported in the device capabilities.
> Any offloading is disabled by default if it is not set in the parameter
> dev_conf->[rt]xmode.offloads to rte_eth_dev_configure() and
> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup().
> If any offloading is enabled in rte_eth_dev_configure() by application,
> it is enabled on all queues no matter whether it is per-queue or
> per-port type and no matter whether it is set or cleared in
> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup().
> If a per-queue offloading hasn't be enabled in rte_eth_dev_configure(),
> it can be enabled or disabled for individual queue in
> ret_eth_[rt]x_queue_setup().
> A new added offloading is the one which hasn't been enabled in
> rte_eth_dev_configure() and is reuqested to be enabled in
> rte_eth_[rt]x_queue_setup(), it must be per-queue type,
> otherwise trigger an error log.
> The underlying PMD must be aware that the requested offloadings
> to PMD specific queue_setup() function only carries those
> new added offloadings of per-queue type.
> 
> This patch can make above such checking in a common way in rte_ethdev
> layer to avoid same checking in underlying PMD.
> 
> This patch assumes that all PMDs in 18.05-rc2 have already
> converted to offload API defined in 17.11 . It also assumes
> that all PMDs can return correct offloading capabilities
> in rte_eth_dev_infos_get().
> 
> In the beginning of [rt]x_queue_setup() of underlying PMD,
> add offloads = [rt]xconf->offloads |
> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
> defined in 17.11 to avoid upper application broken due to offload
> API change.
> PMD can use the info that input [rt]xconf->offloads only carry
> the new added per-queue offloads to do some optimization or some
> code change on base of this patch.
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

In next-net replaced this one (v12) with existing v10.

Applied John's comments on doc.
Squashed sfc patches.

For next version of the patch can you please either get the patch from next-net
and update it or make incremental changes to on top of next-net which can be
squashed later into this patch.

Thanks,
ferruh