From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33780A04DB; Tue, 24 Nov 2020 18:46:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C323C926; Tue, 24 Nov 2020 18:46:46 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 415EEC924 for ; Tue, 24 Nov 2020 18:46:43 +0100 (CET) IronPort-SDR: M5azWXOnlxKUYp0P84ICKR5wrfvOqelTxAam5Dzkove1oGXIa5A5gZPPMvD1sFnwO6H/VvVrs3 XbL4K2hrh1UA== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="236125485" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="236125485" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 09:46:41 -0800 IronPort-SDR: ETtihsojsjGoOGGE7aqJP9iiRpyEzpe/EU+cnGB7sPiKV8eQb+z+/RRSJsphdlHnKEmIYQdx9y EsJBAM8UT5qA== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="370445067" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.85.132]) ([10.251.85.132]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 09:46:36 -0800 To: "Yang, SteveX" , "Ananyev, Konstantin" , Andrew Rybchenko , "dev@dpdk.org" , Thomas Monjalon , "Zhang, Qi Z" , Ajit Khaparde , "jerinj@marvell.com" , Viacheslav Ovsiienko , Matan Azrad , Bruce Richardson Cc: "Xing, Beilei" , "Lu, Wenzhuo" , "Iremonger, Bernard" , "Yang, Qiming" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" References: <20201028030334.30300-1-stevex.yang@intel.com> <20201102085234.72779-1-stevex.yang@intel.com> <20201102085234.72779-3-stevex.yang@intel.com> <67bb56e7-d12f-d364-1cc4-dfefd20739b0@oktetlabs.ru> <8721bb8d-e361-f815-257f-08d531e23fba@intel.com> From: Ferruh Yigit Message-ID: <1e5d6121-0650-3d48-1482-d15f4a598aff@intel.com> Date: Tue, 24 Nov 2020 17:46:31 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 9:07 AM, Yang, SteveX wrote: > > >> -----Original Message----- >> From: Ananyev, Konstantin >> Sent: Tuesday, November 3, 2020 12:05 AM >> To: Yigit, Ferruh ; Andrew Rybchenko >> ; Yang, SteveX ; >> dev@dpdk.org >> Cc: Xing, Beilei ; Lu, Wenzhuo >> ; Iremonger, Bernard >> ; Yang, Qiming ; >> mdr@ashroe.eu; nhorman@tuxdriver.com >> Subject: RE: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo >> frame flag condition >> >> >> >>> On 11/2/2020 1:18 PM, Andrew Rybchenko wrote: >>>> On 11/2/20 11:52 AM, SteveX Yang wrote: >>>>> Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as >> type >>>>> condition of jumbo frame. Involved scopes: >>>>> - rte_ethdev; >>>>> - app, e.g.: test-pmd, test-eventdev; >>>>> - examples, e.g.: ipsec-secgw, l3fwd, vhost; >>>>> - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, >>>>> ixgbe; >>>>> >>>>> Signed-off-by: SteveX Yang >>>>> --- >>>>> doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>>> b/doc/guides/rel_notes/deprecation.rst >>>>> index 2e082499b..fae139f01 100644 >>>>> --- a/doc/guides/rel_notes/deprecation.rst >>>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>>> @@ -138,6 +138,18 @@ Deprecation Notices >>>>> will be limited to maximum 256 queues. >>>>> Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be >> removed. >>>>> +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be >> set >>>>> +according to >>>>> + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame >>>>> +uses the >>>>> + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU >> (1500) >>>>> +set, the >>>>> + frame type of rx packet will be different if used different >>>>> +overhead, it will >>>>> + cause the consistency issue. Hence, using fixed value >>>>> +``RTE_ETHER_MTU`` can >>>>> + avoid this issue. >>>>> + Following scopes will be changed: >>>>> + - ``rte_ethdev`` >>>>> + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; >>>>> + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; >>>>> + - net PMDs which support VLAN tag(s) within overhead, e.g.: >>>>> +``i40e``; >>>>> + >>>>> * cryptodev: support for using IV with all sizes is added, J0 >>>>> still can >>>>> be used but only when IV length in following structs >>>>> ``rte_crypto_auth_xform``, >>>>> ``rte_crypto_aead_xform`` is set to zero. When IV length is >>>>> greater or equal >>>>> >>>> >>>> If so, what's the point to have the offload? May be just deprecate >>>> and later remove it? >>>> >> >> Same thought actually, can we remove DEV_RX_OFFLOAD_JUMBO_FRAME >> flag completely? >> PMD can decide based on provided MTU size does segmentation, etc. is >> needed. >> > > Yes, it seems can be removed when base on MTU size. > I've checked related code of using DEV_RX_OFFLOAD_JUMBO_FRAME. > Most of them use for checking boundary of max packet length and set 'dev->data->mtu'. > Steve already sent the RFC for above fix: https://patches.dpdk.org/patch/84486/ We can consider removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' but anyway it is for 21.11. This deprecation notice is required to fix the ethdev in next release, as in the above RFC. I cc'ed a few more relevant people, can you please review this deprecation notice. Thanks, ferruh >>> >>> Above just changes the condition of what is called jumbo frame, nothing >> more. >>> >>> ethdev assumes max frame size (without jumbo frame support) can be >>> 'RTE_ETHER_MAX_LEN' (1518) >>> >>> But a PMD can support double VLAN, and it can have >> RTE_ETHER_MAX_LEN + >>> 8 bytes frame size and still may not support jumbo frame. >>> >>> In that case ethdev overwrites the frame size as RTE_ETHER_MAX_LEN, >>> and this will reduce the supported MTU to 1492 (instead of expected 1500). >>> Above deprecation notice is to fix this.