* Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
@ 2021-12-02 9:35 Dariusz Sosnowski
2021-12-02 11:38 ` Huichao Cai
0 siblings, 1 reply; 6+ messages in thread
From: Dariusz Sosnowski @ 2021-12-02 9:35 UTC (permalink / raw)
To: Huichao Cai; +Cc: konstantin.ananyev, dev
Hi,
On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote:
> > Substituting options with NOOP might cause rte_ipv4_fragment_packet to produce more fragments than necessary, since options with copied flag unset will still occupy space in IPv4 header.
> --The "ip_options_fragment" just make a replacement and doesn't change the length of the IPv4 header.So I don't quite understand why it leads to produce more fragments.
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
Best regards,
Dariusz Sosnowski
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
2021-12-02 9:35 [PATCH] ip_frag: add IPv4 options fragment and unit test data Dariusz Sosnowski
@ 2021-12-02 11:38 ` Huichao Cai
2021-12-02 12:03 ` Ananyev, Konstantin
0 siblings, 1 reply; 6+ messages in thread
From: Huichao Cai @ 2021-12-02 11:38 UTC (permalink / raw)
To: Dariusz Sosnowski; +Cc: konstantin.ananyev, dev
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
--Do I need to modify it this way?
[-- Attachment #2: Type: text/html, Size: 470 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
2021-12-02 11:38 ` Huichao Cai
@ 2021-12-02 12:03 ` Ananyev, Konstantin
2021-12-02 12:11 ` Huichao Cai
0 siblings, 1 reply; 6+ messages in thread
From: Ananyev, Konstantin @ 2021-12-02 12:03 UTC (permalink / raw)
To: Huichao Cai, Dariusz Sosnowski; +Cc: dev
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
I didn't look at it in detail yet,
just wonder would be real gain in terms of space?
From: Huichao Cai <chcchc88@163.com>
Sent: Thursday, December 2, 2021 11:39 AM
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org
Subject: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
--Do I need to modify it this way?
[-- Attachment #2: Type: text/html, Size: 4278 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
2021-12-02 12:03 ` Ananyev, Konstantin
@ 2021-12-02 12:11 ` Huichao Cai
2022-02-09 5:50 ` Huichao Cai
0 siblings, 1 reply; 6+ messages in thread
From: Huichao Cai @ 2021-12-02 12:11 UTC (permalink / raw)
To: Ananyev, Konstantin; +Cc: Dariusz Sosnowski, dev
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
Perhaps performance is more important.This code comes from the linux kernel(5.10.9 and so on). :)
It is more performance-focused based on comments. :)
[-- Attachment #2: Type: text/html, Size: 715 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
2021-12-02 12:11 ` Huichao Cai
@ 2022-02-09 5:50 ` Huichao Cai
0 siblings, 0 replies; 6+ messages in thread
From: Huichao Cai @ 2022-02-09 5:50 UTC (permalink / raw)
To: Ananyev, Konstantin; +Cc: Dariusz Sosnowski, dev
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
Hi everyone,
This patch hasn't changed status for a long time, I want to know what the current situation of this patch is?
Huichao Cai
[-- Attachment #2: Type: text/html, Size: 2313 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
2022-02-11 9:41 ` Ananyev, Konstantin
@ 2022-02-11 10:00 ` Huichao Cai
0 siblings, 0 replies; 6+ messages in thread
From: Huichao Cai @ 2022-02-11 10:00 UTC (permalink / raw)
To: Ananyev, Konstantin; +Cc: dev
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
>AFAIK, we can't copy-paste code from Linux kernel.
>As you noted it is under GPL, while DPDK is under BSD-3 license.
Well, I'll rewrite the code.
>Library routine has no idea would original IP packet will be used later or not.
>In your particular case it might be not needed, but there might be other usages,
>that do use it (logging, send un-fragmented via other port, etc.).
>So I think we have to preserve original behaviour.
Ok,I will preserve original.
[-- Attachment #2: Type: text/html, Size: 965 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-11 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 9:35 [PATCH] ip_frag: add IPv4 options fragment and unit test data Dariusz Sosnowski
2021-12-02 11:38 ` Huichao Cai
2021-12-02 12:03 ` Ananyev, Konstantin
2021-12-02 12:11 ` Huichao Cai
2022-02-09 5:50 ` Huichao Cai
2022-02-10 12:21 Ananyev, Konstantin
2022-02-11 2:12 ` Huichao Cai
2022-02-11 9:41 ` Ananyev, Konstantin
2022-02-11 10:00 ` Huichao Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).