From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D3742C6D; Fri, 9 Jun 2023 12:09:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3711A40EDB; Fri, 9 Jun 2023 12:09:38 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2078.outbound.protection.outlook.com [40.107.100.78]) by mails.dpdk.org (Postfix) with ESMTP id 94B5140A84 for ; Fri, 9 Jun 2023 12:09:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RBVuko1nmgCZaxY7WXs50xrXZ+cBHE1Kx039zAggerGWM4ZiUuGmtv63886SdckCnavJ0DsRO4WNGj290kIrBNLRVuofC0xa2N4z9FbF4F8Lu433m+bJwnT37LzsVEjPa0CA4kFQ8MlJt47m+/jm/w5vwAZtlpCA7TvQxfV7OEsCm0IOs/g9byuGJ90GLbDJv3+xOQhiRlxwt2jvH8WZ+EU59wEO7TFjTBPkQqkdiKdfhNtgLuTvewDySxjUI34IrOIJQiXCyGx8rokSkzqa1HG29sgQmSQuf1eNpdFJQbr4PJ/6zSi7i5NkBUtgToW4iRsD5nQuONkqqg9qy3AB9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8K5KXXHZorWhb7Ks8184le8XhRWWZAZp9eyhdGT/PA=; b=KQYiDgvZ3HZcGmcCwVc08+kfgp1xMsjXhyrbU9AcesqQ9cyeQhKNo5iVQCY/moshFA/xe6FwvpEV5KWIq3eXWs0p4wtC1S/S9sxq7/0VyYqqPqwxTatYpkb1zHsKVgnM+50k3Ff0WoFcFew/wpM/eNvlJ65ibWRod2T05b7mbf4a1uQhXjXkkX1lwDgwd7tbWiHG7A69Qe0/4dAIuSVR1iVdbUorBpYacOvjZ0i//7RpwoZgEUufyGFo4YjnChwlyqGz6mKDY/YxZvg4UE7LCG96W1iYdKiwlcqf5wkvgSM/4m6dvd4nEHejtQJCFmxnsvtvDBtXZqutbC12LP67OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8K5KXXHZorWhb7Ks8184le8XhRWWZAZp9eyhdGT/PA=; b=NwBKCTVGEslgMvkhxokrCzpA8jKEPh6XcAMJ8ZMTT3qcKbOtjU2NETiVw4g5Es1pCbo61jkHyk5TMsUKTIUw5YnBe4YVzZhKrld5MuqKeeNmXb6khU1XQ+tPhQ9EIgYiGTlloVsfczLsojIuDrgZAzONlZGudk2guMSTUmXsuQg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB5419.namprd12.prod.outlook.com (2603:10b6:510:e9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Fri, 9 Jun 2023 10:09:32 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 10:09:32 +0000 Message-ID: <1e88d6f0-1d46-1b2e-262b-17bf54170d24@amd.com> Date: Fri, 9 Jun 2023 11:09:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [dpdk-dev] [PATCH v9 5/5] ethdev: merge driver ops to get all xstats names and by ID Content-Language: en-US To: Ferruh Yigit , Andrew Rybchenko , Igor Russkikh , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Viacheslav Ovsiienko , Liron Himi , Stephen Hemminger , Long Li , Jerin Jacob , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Thomas Monjalon Cc: dev@dpdk.org References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20211001090723.1414911-1-andrew.rybchenko@oktetlabs.ru> <20211001090723.1414911-5-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR05CA0020.eurprd05.prod.outlook.com (2603:10a6:10:1da::25) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB5419:EE_ X-MS-Office365-Filtering-Correlation-Id: 660184ba-656e-4eb7-79ea-08db68d19e93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lpK2VCG/5nk7u8QSVKxk5dNdeynH+gw7LQQHa5NftMaToh0LLHGUtSwBG1OZtkQlt/meJeiNUGAK8bRZ4/Ofnd2arff1Aj58/jg/IoNETlxiuk0eaC1ZxEc61z/XMla0K3IXWvhcyIROWd6XxMN73nCcQARn+mBWjMgBAa/Fkz9d/KklN6ZoAGjckRVPByyaW6KMsR+4tjDr3RU0OtDT/5FwU2s42clNbib4D4CMW/FOhF8sfcDd8dTqJHxj+CsS9SrqkeYEuivwPtOlXEwTrZl/vvYwCzEHJ61cCRPeXK2BJqSBYl1XdAnrV0DkFfQPi56Jbh4GiKFbZYzHpAHw80MMDpRqNPUTR4BQFtZDP0H0BvMBtIMQuANI5NmlZLhOFelfSSx64fjo6Jma6oPlm4YWapBVpDhpbXHNEG4riyPisM9otHB428CBxyaBS7RQZKp50avo5hqYLMfhuBL2AT6XlP6zy1JFHlXdGUdv/F/nm7HXsklX8tbvADLfHaTTQ0WuU6dGHMY418z2FfISVuLvpf6iBHYyNKr3IduXTt2ohjTDotiwAObgQTF1qnqV1O4WERyMijs7kpOQ/5Z+9X79rDJiSraE7stV5ytg962vmM9S1KbQsd+dTmXFXaPvJEc848m6p7dC53NH8LWXBcycISf9Tdz4ebeKB3876No= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199021)(26005)(186003)(6506007)(6512007)(53546011)(38100700002)(921005)(41300700001)(6486002)(31686004)(2616005)(83380400001)(478600001)(110136005)(6666004)(4326008)(66476007)(66556008)(66946007)(316002)(44832011)(8676002)(8936002)(5660300002)(7416002)(7406005)(7366002)(2906002)(86362001)(31696002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW9KT09QVzM4T0J6TEtlZDJvTVpzMGhWaXF2YW9LM0hpZU50bWhzSW9OUXVi?= =?utf-8?B?VDFwSnZkLzllcGhJMURxS0tLc3ZoQzRpL3FlOTVobXN1K0pWeVB5YlRrMUFK?= =?utf-8?B?RXJwSkRqMjNZcWc3NVN1V3pvSHZ3Mm1HenpjOXhaZ2NGK0NUSlNwZ0ZuTWdG?= =?utf-8?B?RGsrQ3VFNy83L2JNN1FvUUcrb0JINDZvN2NWL0ljL0xVeTFRZEhmT3ljdndV?= =?utf-8?B?ZGNVcmZpYVlHZ2dPRThyemhyTWVFSW5sa3NndnFEbzhQV1dWQU0xNUVMWXhP?= =?utf-8?B?YlYwOWNtZFZKekdqV2VVYmh4eXJBVVJ6SU5TOWwrL0t5TXRkYTRBVzFITHMv?= =?utf-8?B?T3o5RmNmTlNnUUJxWTdkT2hVWlZPYmpWQ3UvREIrZ0hNMmt5Y2JCVVBWZUV6?= =?utf-8?B?ZjdhZ0RsWTBTeVkvR2tscnlYSlpYUjl4NUlYMmg3alN4RXF3NDBreFBTRlZZ?= =?utf-8?B?ZTFHenJha0ZyYS8yU01sY3Q1bzljaEQ4Z0ZJR2FWWFNhUEoxZDhFdVE2ZlJp?= =?utf-8?B?cHRrSHdpTDZaUXFtcDh5d0dtMnZRT2FPeWUweVVPREs2d0c1MHZncS9MdExW?= =?utf-8?B?cWhjRTFkSlJYSHN1K0lwK2FURVoxcThBWS84MVlrUkg3akMvbGxWbkY2aHhO?= =?utf-8?B?QXhaNW9yRzNUTCtZOWpvUzZCRVAvcGdZYS83SDRoaHBha0JkOWpsOUEzemZP?= =?utf-8?B?SHc2MmRycXJVUUhpeXVwZTQ4VHZXTGNSck9qZG0va3FjUFlPS0h6VC9ZcTJn?= =?utf-8?B?aTdPcGtHa0lVZVdhRnk5RnA0endBcHdHQzZOSEFuWTNyTmk0QjArSU9SaS9B?= =?utf-8?B?dHhPMmR6ZmVBRTNPczBFVGNyWGg0VGxuT25NbDhFMnRUQ1MwUnpaRkhYZUxy?= =?utf-8?B?VmkrcGVrendZSjlCcysza1hJWlBsNWs2b212WkNZRzc0N2ZqaTVGbnFqc1Yw?= =?utf-8?B?THJYVzhmcEZUalltaW1sUzVDZy92V2p0clVLdmxoVFdoVVRXZmtzSElxLzJX?= =?utf-8?B?TGZ0MGxRN3Y2RGZ3VG9Ma0sxQ0ZUTWNzdytXUkorcnNINmZlR2N5SVJoL1Nr?= =?utf-8?B?M3FNaHNmY1c0Mmtsd0Q2QzEwODNyM0xUNnlpaHNnZkVneHdDMkhycDVXRHdK?= =?utf-8?B?d3lEK2JWNTc4WW91SEVZajc5NFBOVVF2bnVuOVZ4bWdpL2xnNEJjaERBbm1U?= =?utf-8?B?TlRoVURLZUtacDlsbjRhRUNuZUpKeHhYVGdYc0ZLcU1uQitHdHFhU0NzeFJt?= =?utf-8?B?YXFPRWkzNmp0eDlPN21JN2I3TDF6REZGVVpiOGpsbWVqV2hESjVHUXYyVUFi?= =?utf-8?B?NGVhbjFzUHdlb3V0cXVSeGlqQ1Y3dHhqQklZNWFGbGdTUjNwRnRRb25tckVL?= =?utf-8?B?a2tIc2VxZHVsVm9xT3dxN3oxbWFrRlJ5YUwweW5nWmc1dEJvaGFVaURKL3Zk?= =?utf-8?B?RUVERE1RVi9KcmgwRDh1c3NCNW1HVjdtdzA1aDYzRDloTGJCQUxjYVpBd3Ry?= =?utf-8?B?dHdTMS80bnY1NnpEZzhXUmdRRGtXc3JaZXdXcVV1SWw3S2ROdy9MRnpReWU5?= =?utf-8?B?QzNvNmVhSTM3R1JsWVhxdDZBckFwMm50OTFXcjRFUGxvOGRGbS9rQkx6OEFm?= =?utf-8?B?a0ZtR1o2K0gzd1J6MjFZbTJsVUgzOUZGaG4ySkpQVlo2SGJmMWsxQUVPUjZo?= =?utf-8?B?QVJQOWJpcjhpQ2s3Mjk4Tm9VeWg2dFdzRFllQVFOYjdWMER3c2NKTGhKNGpz?= =?utf-8?B?RmlJM0RncHJUK1NieEhmQnd4bzFQZFF4RnRtZFBoamxuaWw2bFh6UENXdy9E?= =?utf-8?B?WDZhK2ZqN2FDSEVsQ09tR0xXckNJSWRVcjNqRTBjM0NYWTBrdStXbkc3OWdD?= =?utf-8?B?NytZVG1jdTFUMmJxZEc0NU9pdC9qVFJZVm1QQWNoZkZiR3Q3V1NlQ2ZYb3JD?= =?utf-8?B?TDlKbVFWWlh1VWljZ0FUSDB3a0NmYUc2Y0NxOXNaOU9pdG4vL05rMGtPUUIz?= =?utf-8?B?UXhnNTNmNGpBakc3dzZkbzFGOHBBcktYUk9hbGs1bTU2TzVocGFFTzVJTXRM?= =?utf-8?B?OWlXS0JiTkQ2ZmhIL1p1RHM0NlJPR0IzZU9WM2FtSU1IV1B0UE00SVVzRUJY?= =?utf-8?Q?gDxfeAkn6Aij4y6xDEltwBKpV?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 660184ba-656e-4eb7-79ea-08db68d19e93 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 10:09:32.4781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vA4QOwJarRfmXIBShBEGMS+KRbtiCjy61uZpUK+in3VT2S0q1H5A9kNZzDGenJ56 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5419 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/2021 12:06 PM, Ferruh Yigit wrote: > On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: >> All xstats names may be retrieved passing NULL ids. >> >> If a driver does not support getting names by IDs, the callback should >> return -ENOTSUP on attempt to use it. If so, the request is handled >> on ethdev layer by getting all names and filtering out requested only. >> >> Signed-off-by: Andrew Rybchenko > > The intention is to simplify dev_ops for drivers and have one less dev_ops, > but for xstat_by_id, it is already covered by ethdev layer if PMD doesn't > implement one, so PMD needs to implement them only if it has a better way > to provide _by_id values. > > So this merge is bringing an additional check for the ones that doesn't > implement _by_id dev_ops, and for the ones that implement there isn't much > difference, still PMD needs two functions, one for to get all values, and > one for to get _by_id, now although there is single dev_ops, PMD > implementation > doesn't differ much. > > Because of above reasons I am not sure about this patch, let me proceed > with > rest of the series, we can discuss this patch more separately. > The patch is in patchwork for a long time, there was no new comment/discussion, I am updating it as rejected. Please send a new version if you want to pursue the optimization more.