From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Chilikin, Andrey" <andrey.chilikin@intel.com>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/5] hash: add new toeplitz hash implementation
Date: Fri, 15 Oct 2021 15:09:32 +0200 [thread overview]
Message-ID: <1e8a4e50-929f-c532-4dde-b717e1d2f57c@intel.com> (raw)
In-Reply-To: <DM6PR11MB4491D5A470CF20848F79BC7F9AB99@DM6PR11MB4491.namprd11.prod.outlook.com>
On 15/10/2021 12:55, Ananyev, Konstantin wrote:
>
>>>> +/**
>>>> + * Calculate Toeplitz hash.
>>>> + *
>>>> + * @warning
>>>> + * @b EXPERIMENTAL: this API may change without prior notice.
>>>> + *
>>>> + * @param m
>>>> + * Pointer to the matrices generated from the corresponding
>>>> + * RSS hash key using rte_thash_complete_matrix().
>>>> + * @param tuple
>>>> + * Pointer to the data to be hashed. Data must be in network byte order.
>>>> + * @param len
>>>> + * Length of the data to be hashed.
>>>> + * @return
>>>> + * Calculated Toeplitz hash value.
>>>> + */
>>>> +__rte_experimental
>>>> +static inline uint32_t
>>>> +rte_thash_gfni(uint64_t *m, uint8_t *tuple, int len)
>>>> +{
>>>> + uint32_t val, val_zero;
>>>> +
>>>> + __m512i xor_acc = __rte_thash_gfni(m, tuple, NULL, len);
>>>> + __rte_thash_xor_reduce(xor_acc, &val, &val_zero);
>>>> +
>>>> + return val;
>>>> +}
>>>> +
>>>> +/**
>>>> + * Calculate Toeplitz hash for two independent data buffers.
>>>> + *
>>>> + * @warning
>>>> + * @b EXPERIMENTAL: this API may change without prior notice.
>>>> + *
>>>> + * @param m
>>>> + * Pointer to the matrices generated from the corresponding
>>>> + * RSS hash key using rte_thash_complete_matrix().
>>>> + * @param tuple_1
>>>> + * Pointer to the data to be hashed. Data must be in network byte order.
>>>> + * @param tuple_2
>>>> + * Pointer to the data to be hashed. Data must be in network byte order.
>>>> + * @param len
>>>> + * Length of the largest data buffer to be hashed.
>>>> + * @param val_1
>>>> + * Pointer to uint32_t where to put calculated Toeplitz hash value for
>>>> + * the first tuple.
>>>> + * @param val_2
>>>> + * Pointer to uint32_t where to put calculated Toeplitz hash value for
>>>> + * the second tuple.
>>>> + */
>>>> +__rte_experimental
>>>> +static inline void
>>>> +rte_thash_gfni_x2(uint64_t *mtrx, uint8_t *tuple_1, uint8_t *tuple_2, int len,
>>>> + uint32_t *val_1, uint32_t *val_2)
>>>
>>> Why just two?
>>> Why not uint8_t *tuple[]
>>> ?
>>>
>>
>> x2 version was added because there was unused space inside the ZMM which
>> holds input key (input tuple) bytes for a second input key, so it helps
>> to improve performance in some cases.
>> Bulk version wasn't added because for the vast majority of cases it will
>> be used with a single input key.
>> Hiding this function inside .c will greatly affect performance, because
>> it takes just a few cycles to calculate the hash for the most popular
>> key sizes.
>
> Ok, but it still unclear to me why for 2 only?
> What stops you from doing:
> static inline void
> rte_thash_gfni_bulk(const uint64_t *mtrx, uint32_t len, uint8_t *tuple[], uint32_t val[], uint32_t num)
> {
> for (i = 0; i != (num & ~1); i += 2) {
> xor_acc = __rte_thash_gfni(mtrx, tuple[i], tuple[i+ 1], len);
> __rte_thash_xor_reduce(xor_acc, val + i, val + i + 1);
> }
> If (num & 1) {
> xor_acc = __rte_thash_gfni(mtrx, tuple[i], NULL, len);
> __rte_thash_xor_reduce(xor_acc, val + i, &val_zero);
> }
> }
> ?
>
I think you're right. Given that the mathematical properties of this
hash function are clear and it is very fast, it can be used with
rte_hash, so bulk version will be useful. I'll replace in v3 the _x2()
version with _bulk() as you suggested.
--
Regards,
Vladimir
next prev parent reply other threads:[~2021-10-15 13:09 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 16:03 [dpdk-dev] [PATCH 0/5] optimized Toeplitz " Vladimir Medvedkin
2021-09-06 16:03 ` [dpdk-dev] [PATCH 1/5] hash: add new toeplitz " Vladimir Medvedkin
2021-10-07 18:23 ` Ananyev, Konstantin
2021-10-08 11:19 ` Ananyev, Konstantin
2021-10-15 9:11 ` Medvedkin, Vladimir
2021-10-15 10:55 ` Ananyev, Konstantin
2021-10-15 13:09 ` Medvedkin, Vladimir [this message]
2021-09-06 16:03 ` [dpdk-dev] [PATCH 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-08 11:31 ` Ananyev, Konstantin
2021-10-15 9:13 ` Medvedkin, Vladimir
2021-09-06 16:03 ` [dpdk-dev] [PATCH 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-09-06 16:03 ` [dpdk-dev] [PATCH 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-09-07 0:35 ` Stephen Hemminger
2021-09-08 13:59 ` Medvedkin, Vladimir
2021-09-06 16:03 ` [dpdk-dev] [PATCH 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 0/5] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 " Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 " Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 " Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 1/5] hash: add new toeplitz " Vladimir Medvedkin
2021-10-25 17:05 ` Thomas Monjalon
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-25 17:04 ` Thomas Monjalon
2021-10-26 20:30 ` Medvedkin, Vladimir
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-25 17:02 ` Thomas Monjalon
2021-10-26 20:29 ` Medvedkin, Vladimir
2021-10-27 8:29 ` Thomas Monjalon
2021-10-27 15:48 ` Medvedkin, Vladimir
2021-10-25 17:27 ` Stephen Hemminger
2021-10-26 20:31 ` Medvedkin, Vladimir
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-21 9:42 ` Ananyev, Konstantin
2021-10-21 17:17 ` Medvedkin, Vladimir
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 9:46 ` Ananyev, Konstantin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-15 16:58 ` Stephen Hemminger
2021-10-18 10:40 ` Ananyev, Konstantin
2021-10-19 1:15 ` Stephen Hemminger
2021-10-19 15:42 ` Medvedkin, Vladimir
2021-10-18 11:08 ` Medvedkin, Vladimir
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 2/4] hash: add bulk " Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 2/4] hash: add bulk " Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-11-04 10:20 ` Thomas Monjalon
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 2/4] hash: add bulk " Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8a4e50-929f-c532-4dde-b717e1d2f57c@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).