From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1C6C4333A; Wed, 15 Nov 2023 17:02:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DD0D402B7; Wed, 15 Nov 2023 17:02:19 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061.outbound.protection.outlook.com [40.107.244.61]) by mails.dpdk.org (Postfix) with ESMTP id 98F7E402B0 for ; Wed, 15 Nov 2023 17:02:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5kn4eLRRMq/O0xrVhNVasqS2pAXnIEhG/l/6SwO2HW3dy6XyA6f+gsLHFSHlSp1eIfanKVjz+0oCDc9xjUch5MIQNbihg3U9o7S/uKdow5DMDDTs2KoxJuxSz1OouyC4g3SgqNwXN2lxADd/ViQTak2z25Fy3xMNZZA67iRTmnqPKsovkePTjSAXMUd9D2QaB300lgK0DIKTFGFv9p+L66m/KC5LeZ7LPd+WfK+oeOG2PWswhpRXrlUolCpCTfZxhoV+bcoPN9tNtQsVtZQuHEJo+IbZDCf0DN4EOf6RR94YZf6ItIucMBO6EfOQfKesAAh9jicnDoy2lj3QU6s2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+g0NfTZlKp84C7uDwEAl98uWGsLqh4rKNiHnk4KxWGI=; b=JzCCfia/2TlSF7BHFoxvC2CD56Wv/2EGdNsIIBfFc56QdIR6hZUUusuVpmwgrAfIJE7gU7NATlbssMCydsnS+L9a/371lswQ+RySzNZB8m/Xe43Jhy5pFlch+86Th/P855ZI0kZsmtCUkq1vK1BLbAPD1KiT4Txuz5G58vC8A/jq5xPv1uomIda3CmHDiOur2Zs2vKGpaNdYXiTCjfdEPHfqRKj+vgONHFESkmJkTsW7IpWThGNadFeFBB1YYdIUnIrerLc1Jhk6XdUHbFGjDPoiTpmmJiZOXiOisp0SZQYXDvPT0YcAuTg5xOUNo9e1XANcr6RSsPyVTbYFn7Tw1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+g0NfTZlKp84C7uDwEAl98uWGsLqh4rKNiHnk4KxWGI=; b=VUI7g8F/n+RbN8IcW43MHiWpttDLEXxo4B7mxipCn9XV5bFSruNNG56/8J9wozHalGe3iHK4GbaO/XBDNC69G1UWpa+ZLscnOCAY/T3YUO/1phP4BtKoVra9Cj/zq9hmv5ZIfbhvNhFpA8OwtW9Lr0UsuZfQ4/pINmPpcqi1r6M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6347.namprd12.prod.outlook.com (2603:10b6:930:20::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Wed, 15 Nov 2023 16:02:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.015; Wed, 15 Nov 2023 16:02:14 +0000 Message-ID: <1e935cd6-bd13-4b91-b64a-d5fd52e00758@amd.com> Date: Wed, 15 Nov 2023 16:01:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] Enhance the bond framework to support offload Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com References: <20231008015041.1551165-1-chaoyong.he@corigine.com> <20231018074821.1908906-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231018074821.1908906-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6347:EE_ X-MS-Office365-Filtering-Correlation-Id: 04e197a6-ef38-4006-1846-08dbe5f43b89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vl01JKIl4dQEMi5IZe+da2Op01hKt6YjRfrDqWz6y2qFTodpBycSWxCtoHUvKhbZxSeWeoV5cW7aOy1LrIHnNAyuK5iKXqUqKiofDGwziZdNEUaen496bnHzwNL5Zz4FQdfgDbn510kqVi0dje2uABXonnXE/DOG6XvSGLcImkaSyvmf+95MB0NZQPBfQD/8BchTGMLATTLs8/pxkA3gA/oSc7y65l7RTfG+ekPrckr2L3N2hHRoSHiQzUJucUqseY3xyrdrXLJ5pX1AtQOAKvM+01MTAjU1GHn5ODlcIKcT7d0yXJMs30/k0QlwYFXmK9iylbdTFX5yzciyBbH1uU3TfM8vOFCx7s9PpJXmPTXCnfrxhGckXrp4GWCN2ukMYK/rM0tiJRRb1Oe89vf+wt2yfYFWSZg0As2iBFG/exGwSibfkK7+H3E96xPIF8M1BnRcPj5el8aRlwOR5E1e8GHsuRskboMUoa5gl7xgH27CGBcJS898q/it8PFnuPJ+6THrr3ZXfiJ4TtpxOW9vThazHN2JCueg+5tR00vhnWT30XL4ThRwMIOpwWBv/k5Oao68vhr9+r3kr7v9xw2eg0Pd+jkialQUk2AKqG20mYMWv2Jg6xOAgegKWXjZtFZoeaN8gLEwvdvtwohSMaLPRw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(346002)(136003)(376002)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(31686004)(38100700002)(2906002)(31696002)(86362001)(5660300002)(44832011)(6512007)(83380400001)(6506007)(53546011)(26005)(2616005)(6486002)(478600001)(6666004)(41300700001)(36756003)(66899024)(66946007)(66556008)(4326008)(316002)(8936002)(8676002)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVZ1eTVLZkswM21GMUI1TzEvdkUxcGhQeGdCbjRWb0lIa3R6SngwUzB1QXdM?= =?utf-8?B?bVFpM3hqa1M3UzFWZ1FTMkF0cld5S3lGejJaMFIvb3ZYd29YMTdUNEpYWWpE?= =?utf-8?B?b3ZsVzlwSm9yemx1ZERyU3ljaEQ2eXc1N1JTZEVpYUtMNWw3ejRGZ2RJMXRO?= =?utf-8?B?dUZNQTFidXM0bmIxd0EvbkpibnBkSFR1TE13dElXR2MwUFZLaFVwZlI0NW8x?= =?utf-8?B?SVFEQlozaFF2MnhFWUdwUTZiT1pvMzA5eEF1ZTYvQUpZT0FNVnhJbSt2cXZy?= =?utf-8?B?K29IRUlGM3ZnZTJFd200Q0ZsV3JFbXorTXhId3JVenVYVm5meHpCTzgzZlBs?= =?utf-8?B?UzFxb3pEUzJpS1RCazVTR0I0bjZTMS9DWU84Y2J5bGV6UENjRnJZc2hUWk9K?= =?utf-8?B?SHpsOFBKUTRUYUErS1kwV0xpT2F5NjhlYmVGMVVrQUsrL1gvS0dpTjFFcEl0?= =?utf-8?B?NzBDUEJZNUx6Y0Q3dDEvUHEzTGwvS08wTEVnb05oa3ZZZWRqKzZQdUFGSmVj?= =?utf-8?B?OFUrTWZzZzNlL1lCOHYyZkdkcHNkMEVhRlUvUmQyNC9uT1ZaTzlZa2JjQUVw?= =?utf-8?B?MERDODZYWVEvWGkxazh5cWQ0ckl1VFNVL1VBbHRJaGV5aVN5TGN5TmhMd2Ro?= =?utf-8?B?YWFoc3l3TFNDenVyTHZ5UUNUL24wMG15TEp6YmZIaTRZalNpNUkvVEE0REpO?= =?utf-8?B?M1Y1dXhERHRSV1FCYXpIUTkvTlR5M2ZxZGJoOUxEcVRGZzFkeXdsUSt0Q3Nt?= =?utf-8?B?dU1qbWlMcks3UktxSmFIMUJPVk5kdkIwdForM1dhZlVnQmFSMStVbHZJYVIr?= =?utf-8?B?L3pPZXFBcC9UZ0grMVlxMXUwUExBa1piS0hUTnVKd0ljck5MS00rbXNBWVcy?= =?utf-8?B?MVQ4dXY3dWJzbGQ3YTdkSkJsd2plZmwzbkJJd3hiemRNRHluS2xQRDI2Q1dW?= =?utf-8?B?dXpHdlQzWCtBWS9NN3R0OE55MklXUmZZb0NOZUxJUUhSTEZqdG9NUlV0dlc1?= =?utf-8?B?L0xZSTFKdmpMKzQ3S29RUVBNeng0VlU3cnBXNHRYc25odDNhaVdoQzlzV0ZF?= =?utf-8?B?ZUwvWXhKRjNESHlrUTRPMUxjR2hxd0NORkZrTSsxd2d1WHRoSStwdjlwemlK?= =?utf-8?B?WTlxbmRFOUdUOW9YdTBwejRwRHI1WmJGRmZTTDA2T2h1SDFaU0lsUng0NVBv?= =?utf-8?B?RlRYWDVHL3dzT1h4QVJuZ0pUMjBJMlhESDJFUFlKMVE4T0xoUHhKcDR2MmRK?= =?utf-8?B?blRRUmFMRGl5cXF6Yko0d3N1MWJoa3JlczVjVEsrQjM2ZGt3THhVc0pWemkv?= =?utf-8?B?YW5lZXdhK1RDajI3WlRYOHIxWUZENnlEd0IzNkR0cHJtVmpiMnVnODd2V2tR?= =?utf-8?B?RHNPOGFrcDA5VjFhNmRoNUJvd0F4eDl1Y0J0WUdFRE50OUNhRUJsdGRRNmJt?= =?utf-8?B?Zzh1U2t6Tk1SMHRVa1ZrdW8wemVnZWhRQk9EVFJXWVg3OEZONHVkUGxXTW4r?= =?utf-8?B?Uk1tbnQrQjNncWZiWlduczQwQUs5V3dOQXVOcS9FTUN0bXpHZUk4RzFkRmRL?= =?utf-8?B?N0FTZWJzUElJUmpXck9sMFZiemZuaFBBc2hmMHJMZVN6TDBqMkVibGRqR01H?= =?utf-8?B?NjM1Q0pReWg1Y2F2ak9idTlaNjlqWFVBaHY0d0dUdFo3bm14eUxDRTBIdFRK?= =?utf-8?B?Mmp0SWl3ZUpnRXVjZG43aFdSb2lNZUVZOXNERHhHdVIvYkdkVnpweDRrUm1m?= =?utf-8?B?dFFiZlYwOFIzVnh6SFhBamhXQ2NWQ2NRaTcvVnM4YnBmVjJhUzRYOTJlVVZt?= =?utf-8?B?emMyc2tuRmtNSmRDM25iNENqdnlmbFpqWnl0dG1JKzhJUjQ3bnN3YlFTM3FJ?= =?utf-8?B?SHd2MW1rWGxDSmNZVUxMd21rSmpuR29LYjlqM2dKTEpRWkhpUHdodCtXNmFJ?= =?utf-8?B?OXlWZC9ZUjRLTlRaZUMzUVhvVnNBVGNtcEt1R05pdE56VjZYR2Q1dVNUOEJX?= =?utf-8?B?YWo1d0JBZmY0NkIrclFLM1g5VzFieXpVTTY4Y0hxSGg4SlpJQmkvRGQ4Vlls?= =?utf-8?B?VWxreXJybEJnaTQ5emxMNk9CeVc3M0dnYnVpbVdMbFNHR215NENqMnl6UjBn?= =?utf-8?Q?0YPI=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04e197a6-ef38-4006-1846-08dbe5f43b89 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 16:02:13.9253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vWkhaHB2wH1OvCwdIKU/71AewoWJhusa4sSA78nAyyKa91jhQ1ePqfcY5oII5QZ6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6347 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/2023 8:48 AM, Chaoyong He wrote: > This patch series try to enhance the bond framework to support the > offload feature better: > * Add new API to make the member port can access some information of the > bond port which belongs. > * Add new API to get the result of whether bond port is created by the > member port. > * Add two command line argument to control if enable member port > notification and dedicated queue features. > * Add logic to support add ports which share the same PCI address into > bond port. > * Also modify the testpmd application to test the new APIs and logics > added by this patch series. > > --- > v2: > * Fix compile error on github-robot by removing the redundancy function > declaration in the header file. > v3: > * Use the hole in the structure for the new added flag data field. > v4: > * Drop two commits not necessary for this series. > * Modify some logic as the review comments from reviewers. > --- > > Long Wu (6): > ethdev: add member notification for bonding port > ethdev: add API to get hardware creation of bonding port > net/bonding: add bonding port arguments > net/bonding: support add port by data name > net/bonding: support checking valid bonding port ID > net/bonding: add commands for bonding port notification > > Hi Chaoyong, This patchset discussed in the technical board, to be able to discuss in more details, can you please provide more details in the usecase? Also there can be a gap on how to test this new additions, again knowing the intended usecase may help. There are a few things not ideal in the set, like adding bonding specific APIs, ethdev additions specific to bonding, port not working on generic capabilities/configuration approach but app needs to know that it is bonding port etc ... I will postpone the patchset to next release, please clarify more the usecase and we can continue discussions. Thanks, ferruh