From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4128B2BA3 for ; Fri, 9 Jun 2017 11:21:04 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2017 02:21:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="96253879" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 09 Jun 2017 02:21:02 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Jan Blunck , Gaetan Rivet , Tetsuya Mukawa , Declan Doherty References: <20170510110104.70838-1-ferruh.yigit@intel.com> <136091512.oDuubpNRB2@xps> From: Ferruh Yigit Message-ID: <1eae2dda-3fb3-1d46-5d45-1493c1fe1cd4@intel.com> Date: Fri, 9 Jun 2017 10:21:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <136091512.oDuubpNRB2@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] eal: remove vdev probe by dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 09:21:05 -0000 On 6/8/2017 9:45 PM, Thomas Monjalon wrote: > 10/05/2017 13:01, Ferruh Yigit: >> Virtual device/driver probing done via name. >> >> A new alternative method introduced to probe the device with providing >> driver name in devargs as "driver=". >> >> This patch removes alternative method and fixes virtual device usages >> with proper device names. >> >> Fixes: 87c3bf29c642 ("test: do not short-circuit null device creation") >> Fixes: d39670086a63 ("eal: parse driver argument before probing drivers") >> >> Signed-off-by: Ferruh Yigit >> --- > [...] >> static int >> vdev_probe_all_drivers(struct rte_vdev_device *dev) >> { >> const char *name; >> - char *drv_name; >> struct rte_vdev_driver *driver; >> int ret = 1; >> >> - drv_name = parse_driver_arg(rte_vdev_device_args(dev)); >> - name = drv_name ? drv_name : rte_vdev_device_name(dev); >> + name = rte_vdev_device_name(dev); > > It seems you are reverting the commit d39670086a63: > eal: parse driver argument before probing drivers Mostly yes. > > In some cases the virtual device name should be totally different than > the driver being used for the device. Therefore lets parse the devargs for > the "driver" argument before probing drivers in vdev_probe_all_drivers(). > > Is this "driver" option useless? There is already a generic way to probe, why need another method, I didn't get the motivation but this looks like a hack, only place I found used is in bonding unit test, which can be switched to generic way without this support. And this is a hidden / an undocumented feature. Thanks, ferruh