From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98F66A0C41; Wed, 15 Sep 2021 21:51:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62C1B4003F; Wed, 15 Sep 2021 21:51:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F2B14003C for ; Wed, 15 Sep 2021 21:51:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631735516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=268oZ6UkLj0HY4RvZ3X+wepcglHBGJGV11WJofmlkfY=; b=XBOS3LDaxTEIrkvXfVEwvPLDR0v5Qa1ZmkGRFrpXY4ii4LP8OXRBFajrrEEspbn1uHOoZ/ j1VABI6y9R5QV4OuBiV3+uifhL8ehEWwmT0PmWzjrzeOJN3IHypAAIdgPGIzrtZcg+3LBr PdyhkUHoa1WmUwKU4oliFzsjAeXiZgc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-sYFimoG_M06LC3M1yWw69A-1; Wed, 15 Sep 2021 15:51:53 -0400 X-MC-Unique: sYFimoG_M06LC3M1yWw69A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96517A40C2; Wed, 15 Sep 2021 19:51:52 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0A25196F8; Wed, 15 Sep 2021 19:51:47 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: Chenbo Xia References: <20210915145447.28481-1-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: <1eb2a952-f8b3-2ebd-2784-127f954f24d4@redhat.com> Date: Wed, 15 Sep 2021 21:51:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210915145447.28481-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/21 4:54 PM, David Marchand wrote: > Caught by code review, this copy is unnecessary. > > Signed-off-by: David Marchand > --- > lib/vhost/virtio_net.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 8549afbbe1..1d30ad0fd9 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -3364,6 +3364,8 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, > count = 0; > goto out; > } > + pkts[0] = rarp_mbuf; > + pkts++; > count -= 1; > } > > @@ -3386,15 +3388,8 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, > out_access_unlock: > rte_spinlock_unlock(&vq->access_lock); > > - if (unlikely(rarp_mbuf != NULL)) { > - /* > - * Inject it to the head of "pkts" array, so that switch's mac > - * learning table will get updated first. > - */ > - memmove(&pkts[1], pkts, count * sizeof(struct rte_mbuf *)); > - pkts[0] = rarp_mbuf; > + if (unlikely(rarp_mbuf != NULL)) > count += 1; > - } > > return count; > } > That's indeed much better! Reviewed-by: Maxime Coquelin Thanks, Maxime