From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AC0DA0350; Tue, 22 Feb 2022 17:41:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C130840E64; Tue, 22 Feb 2022 17:41:36 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 5219E40DF6 for ; Tue, 22 Feb 2022 17:41:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645548095; x=1677084095; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=p3uLVdd4fQp1XeVfgnds5VRgB0pPbM9kOhW9t97M2l0=; b=JwIUzpwQYbFmvvRaQ5Yn0qKlyAAlc/hLqprOgyn5ouAOJrD4e9tXd3qr uW9lXxzZK6l8WxX7hxT8N9RARqu+jU3xX5/G0vgNqD6wqKygdPP4pXMXW XshV8VK21DSUejYwR5iX3WlMD1qt5zoVXjnYdM91GpK5YfzDw6h72Faf1 tnkvYfBJuiNMOOiSeN5FeQlatY2iF8q1mK5MPzW55rznvtuGM2Uvx1UHW ALoSYQIEoGehgEN43FMW/vPasdxwHJ4Px1MIGM95NDvVaQVk3nlw478wm KxSN6hqb6+RBizleEIIuX3B316RI2H4oIf+XgbTV8DN2FAuoN0bQNvuLF g==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="231722523" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="231722523" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 08:41:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="591368859" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 22 Feb 2022 08:41:26 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 08:41:26 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 08:41:26 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 08:41:25 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 08:41:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AGww2wPNiNw6HK+J2AD3fYgoywo3wsnQjHj5Gxv1ST+jk4Fn4Bfj6KSrgCY1PAYnXIwBuodxEQ0/3EisM2b6rTAQYsE5sXqAYv301vocbkY3W/KFuAvzrv1EPbMH+uUZ/K5LUGxFrH2Rii0gMXf8xc+IfawnWD9rWSYQtEEb6Q4Xqv4bBT8bwliGzxBL/2wZQGgn9hKNC1VuwLHRQZhcLjRAk7Cj+BsOlJ6XsyFFI928llZUKRM8oqsxKB+V+6F+K67PGGrJ/lpOE8tPOMxS0GeylcHvS0P1jTHUkmh7v/uK0s8FuVAnn4FWdF+42tN/bqcwUJKg1Ep/Nb+TSik0oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZzFe5OTLBJyYbKQ1+nXOrsXyhmev7sLkt+3e8jMqmo=; b=evU7CPIB2mKXT1A7LuhMvRB313wLJk72QI9d4vggYuzAuPi3kJxlXsTeTYJkkBBJHjIeRgku2UdW+rvR66YmGqOMGbjbqF2f7hWeLHwqZMT0r0ObhnjpgxKC/w5ReSDDrwJDta1WtCt1ar2mNVrZ/sIexGw+7O5rJfgwjqGrIL888lRVzt6Pa8iBwjnFwDwRZIEnDBmueQxBN8v8921xdS+Eh1bR4+pX839OuGXch4nmM7AG0Dis2ocOIEcwJNmhD/Cnr31ig9niEXxQWYcmNdNOGb2bTZVZ5pXQjzViXrrr3LGalpOacyxTE7c7iEBUaLhxeZ810YltRdwgi9+2mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB2958.namprd11.prod.outlook.com (2603:10b6:805:da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Tue, 22 Feb 2022 16:41:22 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 16:41:22 +0000 Message-ID: <1ebbb3cb-a041-6d14-88f0-72eedbaddbdc@intel.com> Date: Tue, 22 Feb 2022 16:41:15 +0000 Content-Language: en-US To: Alexander Kozyrev , , CC: , , , , , , , References: <20220219041144.2145380-1-akozyrev@nvidia.com> <20220220034409.2226860-1-akozyrev@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v8 00/10] ethdev: datapath-focused flow rules management X-User: ferruhy In-Reply-To: <20220220034409.2226860-1-akozyrev@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0346.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9745c83-16a1-42ce-593f-08d9f62228b0 X-MS-TrafficTypeDiagnostic: SN6PR11MB2958:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUor+H0XP+TI6PIznvQZsm+JmEiIJ8Z4m7bJZcz3oqKELZlokApan2yCVuON8230ZRxMqPyqY5XoMRY47RL9sI17SHJ/mZ5J5QVjdZ2dQ35AiV7/DJ3LsGcRk41742U4251lPQLgozC77AkT/AXCvKuKPTK+BVs/0hn7LU4sFEUx3p+OGeVi6r8ZHLdXtr4mtYAbgaYOLzkDfM5wF5JgvhG28Eq/bUiPwO6EQWcWi2Exf4vNif8DNZa+NP23c6hOJj0cL9HnfN5dzYqwxTugDLDFitEtFRfPWynsmKmaMxfiDI8yIM7n+s4WXW7cXDAfrwdeBtQIcHixD1q1wIgcJn+JW6OPZ4130OxayXgNhOIksbJrNgaQbbj4fHegcHQjF4fmuMUERLY3bBEV7Ak0f2dr2aJl/eozlvhEgasaig/9RmqUzG5WwVF8EJBi6YPSRlMyQtVBk765MKHumKrnTWlAorXTaC5mkiQqF90FuPJBp5pgqTgTa8YsLlJbtZU1Q7xOLJI/ehb1at5x47utEm5nzAI+N8+fyX/tuaNZDJN4qcWFWH3Wlu6NBHOaPv6XXygYWyvNOg0l4FDZfCOxCNUv+C/wKy6fh9Axhythdzgqdoia47XGRiaKdmL3PPSttnvS4fogMrbe+xW0ZmXcOgNsJdGiuJ2jv0xP5bk1l63GyniVKdzypJki2J38ukeJEOmnapFl5FqYReXF+a4Ixgo5I5A86fEqoyfWVOnZHV0KtlYb4Vk381Ahegak0CtO+bsgn5xYn+gjEd9lcHnmz30eU9b8ksAiLxUegvKXbfE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(26005)(66556008)(66946007)(6512007)(107886003)(2616005)(53546011)(6506007)(6486002)(31696002)(6666004)(86362001)(66476007)(8676002)(508600001)(316002)(82960400001)(83380400001)(4326008)(38100700002)(5660300002)(31686004)(2906002)(8936002)(36756003)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RW5PalFoVDM5bGtmVHE3Szc5L3dKOXlKcHhPS3NCcDY2Qy9jSHpURG5BZFBJ?= =?utf-8?B?dVRzTmdtYzZxcnhUaFkza01xWmRRVjQ2cjNtK0Evc203NmdnT1BhTDlOcDgz?= =?utf-8?B?VU44dnRCdFpycERaRGJmYVNoVlpYV0JFL2RzSXMyZXM1QUVva0owRHQ0c0o4?= =?utf-8?B?eXlwWG1HKzZwTHJrcHhLM0FkckRnejdDRlRkNGxLVGJ4NUQzWkExQ2ZZaVpT?= =?utf-8?B?NUx5M2ZFMHVreW5vNHl0UEVwZFZ5YkNPQ0NpdGFNTDU4eWNIMkdTZk9rSHhw?= =?utf-8?B?QXpDVG5VZk0zWWhGUGcrMGFyaEMvRmpoR2lSaXJ3TUx1V3BNbXEzOVFEbVlj?= =?utf-8?B?NXh1ZGlBL1ZiNmlFekRxbzJZZUlNK242SEplUTRYdVUvMW5WSTIwUUlaU0FQ?= =?utf-8?B?Y2pQa3E2aUtqeHNmaUxQcjZKUml1VFFXeDUxeEtCcEphbjJqS2hBNGpFQ0w0?= =?utf-8?B?dUliOHJHaTBSOE9US1NiV2Npd0pJclVFcHZyKyt2TGxucjRqME1xWTBGSXRj?= =?utf-8?B?azA2cVpVV2pqbkhMNVdRMXpHdGtqQ3lNVzJNbGxpUzRZTHpldDhzclQxMjFD?= =?utf-8?B?YkltaXQwT1NrU1FZeVJLbUdBT0pLcm9uZ2w1ZWRMakJJaW44QjE4NFhTaEpP?= =?utf-8?B?aVJyeGFVOWUvbnpyWlh0RHJDb00xK2Foa2pQcnVoa2MvZG1YOHo0NkdQZmxS?= =?utf-8?B?RVRnOG1uVWVFSkNyR0xicFNoNm9UZ1Zmb3B3L1VUREhvb0hQUWdGanV3TUk5?= =?utf-8?B?bHdWWW9CUWtRK3JRR29GdnNnbmdaMXlGcXhzM1pmRXA3aS93RUtkV0t4NEhN?= =?utf-8?B?TlFYd3FQdEs0b1JFRUltbzFRRjIvRkJmd2RicHh6dFdPQW5OQU10RTZycXJr?= =?utf-8?B?bmRZS3hnZ0hsOEVDbzBVT2dweFl3QlJnS1lzdHkwTGJlVkFwWks5RE9LQThh?= =?utf-8?B?M3haZGtoYmgzelNXNkF1UGUzclZJelBidkJwU0g1YjZidHhZaUlrYVpsU2Vi?= =?utf-8?B?ZFN6aFNGemJUaWhVZEJPTlQzbjc3LzJ5MzBiQTJuVklIckZUSXF3bXNEQ2pN?= =?utf-8?B?bVdCc3NSeDZrLzU4OGJ6YytOaGUvZE1hT20xcGl3VzlVT2F2cGtFK2tsY2Zp?= =?utf-8?B?SkIwOFJiMjhZK3JaQy9sYkE2aEU0S1NOaERPeHlzV1hXVDdZbXMyK1pTTjJw?= =?utf-8?B?bzZEOURuRTVSTUl6NXY0WXk4TDJia2wyT1g3cWtORnBiNmxsdHZEOWRwVHBh?= =?utf-8?B?SzRQdkFSQTQvVkRvMHdwbU5ieFpLYlNjc3RNMUI1VlhxQkVJanhxV083c3VF?= =?utf-8?B?S2tDaUtIMUlGWkNPNkM4aDFrcjV5ZVpjVVMwQlJzaDFINE1TNGNPNnVlVmk5?= =?utf-8?B?WkwrUER0ZG1HKzgvRFVhT1FmOHQ4MHZubDNKd3ZTZFN2c0k5dE5PeTdFejB3?= =?utf-8?B?Y1ozajl4Uk1CdG5LYmQ3bXNVRWtLWGc3RlNTTWUzcmV5M1hsSHNtQm5XbkVJ?= =?utf-8?B?RDJHUVBGMEFuTENrN3g2bkp2YVhUMHVIUUd1QmlTTWZYa2hYRzVrVzZ3L2ZM?= =?utf-8?B?ajRleVd4L3FHWkJYZWVCZ2VEWTVDVjRUY2laYmFtRkxHdENwbklnNnQ0d0ZK?= =?utf-8?B?blZaVU4vczZTR28zMVh4RGJtaUxHaFpqSjcwM1krWS9GRnNjQTBkSnJyRmlK?= =?utf-8?B?U0JJK0xaNDlSMmxFL2RYdm9vczU4V29QNTB4bk5MWTRzSW1HVUdCK2tpVmV3?= =?utf-8?B?L003SzgwOVVXRXNhS1dNQ2J3TWFpK3psY0YwUC9NcnBueWF0bS93cndYenU2?= =?utf-8?B?QU5BRFNnRE9wamovd2VBTy8wdHlQZFgveHNXNXZ2SHJGREhNTjhzZkNYb2w4?= =?utf-8?B?aGF1VTRJMHh3eXpNcGJqUkVGLzMrNW8xSHRrUWs5WW55QjVnNHJMRWZuOEtE?= =?utf-8?B?WkczZUErRUJrL0lWMzhHQW54UGY5WEt1eEdZZ0JYc3QxUDBST25ZdFhMb3hN?= =?utf-8?B?SVlrbElpcDFvQ3luUDZyVFVRYmRxam1HQkJiY20rNVpaUHlGZHQyQkNxMFlw?= =?utf-8?B?K0svVERsa2hhQjVidldGdFdEL0NvQW9iLzNLSktRYjhVL1kyVXozTUVoTlNN?= =?utf-8?B?WTQ4WnkyQXhUTTl2d1hGVTJVb1BZZ0lZVnVWOVhGa1NYSUxJeG5RTnZhYmNO?= =?utf-8?Q?r9X7D9tMmWurNfEVZFf/Khg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f9745c83-16a1-42ce-593f-08d9f62228b0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 16:41:22.4883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y3SYiJv+nplOC+wvChXtKZgonkk1m6CndDa/v2SMZQH8AgHpVKrlUKgvT4WMwPiNhj2OL4a8eJv055Mi8nSkLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2958 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/20/2022 3:43 AM, Alexander Kozyrev wrote: > Three major changes to a generic RTE Flow API were implemented in order > to speed up flow rule insertion/destruction and adapt the API to the > needs of a datapath-focused flow rules management applications: > > 1. Pre-configuration hints. > Application may give us some hints on what type of resources are needed. > Introduce the configuration routine to prepare all the needed resources > inside a PMD/HW before any flow rules are created at the init stage. > > 2. Flow grouping using templates. > Use the knowledge about which flow rules are to be used in an application > and prepare item and action templates for them in advance. Group flow rules > with common patterns and actions together for better resource management. > > 3. Queue-based flow management. > Perform flow rule insertion/destruction asynchronously to spare the datapath > from blocking on RTE Flow API and allow it to continue with packet processing. > Enqueue flow rules operations and poll for the results later. > > testpmd examples are part of the patch series. PMD changes will follow. > > RFC:https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226-1-akozyrev@nvidia.com/ > > Signed-off-by: Alexander Kozyrev > Acked-by: Ori Kam > Acked-by: Ajit Khaparde Since these are new APIs and won't impact existing code, I think can be OK to get with -rc2, only concern may be testing. @Andrew, can you please review this version too, if it is good for you, we can proceed.