From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C724A320B for ; Mon, 21 Oct 2019 12:59:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F164C1BEA0; Mon, 21 Oct 2019 12:59:01 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id ED38A1BE97 for ; Mon, 21 Oct 2019 12:58:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571655539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoTyRjWxxkcmaOXyfdy4I+V7u38M0WP+th+PelX/VZE=; b=eTq8SU2DCy/gQBBkgezc8gl4HyxenjxwUp63PGzWii0OfnH7ZKQoTTIPO7af8eEoZ6BNVE rT1QK17bMy4mUhoD6CE8b0VU7fNQZ8yvIsP60vGf6rRN8bSli2Dp73uVgIyeZhn68/nIBQ Di9BePiV9ZYf3Yn/85+uJHXGcy4AhS8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-UzsUGfh5NVypCcCu6M1ykQ-1; Mon, 21 Oct 2019 06:58:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3857B8017CC; Mon, 21 Oct 2019 10:58:54 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8BCA60126; Mon, 21 Oct 2019 10:58:32 +0000 (UTC) To: Rasesh Mody , dev@dpdk.org, jerinj@marvell.com, ferruh.yigit@intel.com Cc: GR-Everest-DPDK-Dev@marvell.com References: <20191020052051.9905-1-rmody@marvell.com> From: Kevin Traynor Message-ID: <1eea6d89-0921-9fae-7a7f-28bb95b9cab1@redhat.com> Date: Mon, 21 Oct 2019 11:58:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191020052051.9905-1-rmody@marvell.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: UzsUGfh5NVypCcCu6M1ykQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/10/2019 06:20, Rasesh Mody wrote: > In our testing we have identified a critical FW bug. Performance > is degraded significantly for certain packet sizes with 8.40.25.0 FW. >=20 > This patch updates the FW to version 8.40.33.0. The updated FW has a > fix to performance issue. >=20 > The patch also adds initialization for FW overlay RAM as part of > hardware initialization which is required by the new FW. >=20 > Fixes: 066f0d380a2f ("net/qede/base: update FW to 8.40.25.0") >=20 Hi Rasesh, it should be: Fixes: 21c959e2cb10 ("net/qede/base: update FW to 8.40.25.0") > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/qede.rst | 4 +- > drivers/net/qede/base/common_hsi.h | 6 +- > drivers/net/qede/base/ecore.h | 4 +- > drivers/net/qede/base/ecore_dev.c | 19 ++- > drivers/net/qede/base/ecore_hsi_debug_tools.h | 3 + > drivers/net/qede/base/ecore_hw.c | 4 +- > drivers/net/qede/base/ecore_init_fw_funcs.c | 138 ++++++++++++++++++ > drivers/net/qede/base/ecore_init_fw_funcs.h | 35 +++++ > drivers/net/qede/base/ecore_int.c | 14 +- > drivers/net/qede/base/ecore_iro_values.h | 122 ++++++++-------- > drivers/net/qede/qede_ethdev.h | 2 +- > drivers/net/qede/qede_main.c | 2 +- > 12 files changed, 274 insertions(+), 79 deletions(-) >=20 > diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst > index 471d98014..2f4045795 100644 > --- a/doc/guides/nics/qede.rst > +++ b/doc/guides/nics/qede.rst > @@ -78,9 +78,9 @@ Supported QLogic Adapters > Prerequisites > ------------- > =20 > -- Requires storm firmware version **8.37.7.0**. Firmware may be availabl= e > +- Requires storm firmware version **8.40.33.0**. Firmware may be availab= le > inbox in certain newer Linux distros under the standard directory > - ``E.g. /lib/firmware/qed/qed_init_values-8.37.7.0.bin``. > + ``E.g. /lib/firmware/qed/qed_init_values-8.40.33.0.bin``. Not available in latest Fedora and Ubuntu releases > If the required firmware files are not available then download it from > `linux-firmware git repository `_ Not available here either > or `QLogic Driver Download Center `_. Maybe here? 8.37 is the latest elsewhere.