From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 16D811B252
 for <dev@dpdk.org>; Mon,  2 Oct 2017 17:06:29 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Oct 2017 08:06:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,469,1500966000"; d="scan'208";a="1226082648"
Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44])
 ([10.237.220.44])
 by fmsmga002.fm.intel.com with ESMTP; 02 Oct 2017 08:06:25 -0700
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
References: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
 <1556159.HUIlaTtd6f@xps>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <1eefa9bb-6f61-f5ba-383f-cfe9ae62862c@intel.com>
Date: Mon, 2 Oct 2017 16:06:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1556159.HUIlaTtd6f@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Oct 2017 15:06:30 -0000

Hi Thomas


On 2/10/2017 3:55 PM, Thomas Monjalon wrote:
> Hi,
> I have some comments about the API scope and some formatting.
>
> Suggested title:
> 	power: add turbo functions to map file
>
> 02/10/2017 14:20, David Hunt:
>> allows vm_power_manager example to be built against shared libraries
> Fixes: 94608a0f7f45 ("power: add per-core turbo boost API")

Sure, I'll address this in next version.
>> Signed-off-by: David Hunt <david.hunt@intel.com>
> [...]
>> +DPDK_17.11 {
>> +	global:
>> +
>> +	rte_power_acpi_turbo_status;
> Is it really the function you want to expose?
> rte_power_turbo_status seems more generic.

Not really, it was in there for completeness, but users should be able 
to keep track of the turbo'd cores, so not really needed.

> More comments about what is part of the API:
> If you do not want to expose ACPI and VM implementations,
> it should not be part of the rte_* include files.
>
>> +	rte_power_freq_disable_turbo;
>> +	rte_power_freq_enable_turbo;
>> +};
>> +
> This is a trailing new line.
>
>


I'll address the above comments in the next version.

Regards,
Dave.