From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E1FE02C60 for ; Fri, 23 Dec 2016 13:50:44 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 23 Dec 2016 04:50:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,393,1477983600"; d="scan'208";a="45808015" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 23 Dec 2016 04:50:43 -0800 To: Qiming Yang , dev@dpdk.org References: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <1481008582-69416-6-git-send-email-qiming.yang@intel.com> From: Ferruh Yigit Message-ID: <1f007f12-36ab-d51c-1ef2-ce2a545e55ad@intel.com> Date: Fri, 23 Dec 2016 12:50:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481008582-69416-6-git-send-email-qiming.yang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/5] ethtool: dispaly bus info and firmware version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 12:50:45 -0000 On 12/6/2016 7:16 AM, Qiming Yang wrote: > This patch enhances the ethtool example to support to show > bus information and firmware version, in the same way that > the Linux kernel ethtool does. > > Signed-off-by: Qiming Yang > --- > v2 changes: > * modified the commit log > --- > --- > examples/ethtool/ethtool-app/ethapp.c | 2 ++ > examples/ethtool/lib/rte_ethtool.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c > index 38e466c..9b77385 100644 > --- a/examples/ethtool/ethtool-app/ethapp.c > +++ b/examples/ethtool/ethtool-app/ethapp.c > @@ -184,6 +184,8 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params, > printf("Port %i driver: %s (ver: %s)\n", > id_port, info.driver, info.version > ); > + printf("bus-info: %s\n", info.bus_info); Can you please remove above line from this patch, if you want can be a separate patch. Thanks, ferruh > + printf("firmware-version: %s\n", info.fw_version); > } > } > > diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c <...>