From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 836E2A04C7; Mon, 14 Sep 2020 18:31:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76B392BAB; Mon, 14 Sep 2020 18:31:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1A914160 for ; Mon, 14 Sep 2020 18:31:46 +0200 (CEST) IronPort-SDR: bo9J8ypHHoRub4+YPGuTPPssI57oOL1YQbWikpnswXloGspMsJ1Tn8cpTrvTYOz5AxsJjbUIkQ xAhYVjEVoulA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="243938859" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="243938859" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:31:39 -0700 IronPort-SDR: mu6bAMkqECMivFwcLj2KlYd586Dl1WOKe0bYyTloCYdzzEnrN8uuJ/6VLAY4b0Bn2dmmKrQNcE CjUiOOK36bdg== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507200090" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:31:37 -0700 To: "Wei Hu (Xavier)" , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Shahaf Shuler , Qi Zhang , Andrew Rybchenko , Thomas Monjalon Cc: dev@dpdk.org, xavier.huwei@huawei.com References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200820014204.25035-1-huwei013@chinasoftinc.com> <20200820014204.25035-5-huwei013@chinasoftinc.com> From: Ferruh Yigit Message-ID: <1f017605-c7cf-78c3-b1c1-0827a8e6f8b6@intel.com> Date: Mon, 14 Sep 2020 17:31:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200820014204.25035-5-huwei013@chinasoftinc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Huisong Li > > Currently, the information of Rx/Tx queues from PMD driver is not displayed > exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" > and "ports[pid].tx_conf" maintained in testpmd application may be not the > value actually used by PMD driver. For instance, user does not set a field, > but PMD driver has to use the default value. Overall the question is why testpmd maintains the config values itself? If this is testpmd implementation problem that is no big deal, but if our APIs are forcing applications to maintain local copies that is something to fix I think, which may lead the differences in application copy and more troubles as you are fixing here. > > This patch fixes rxtx_config_display so that the information of Rx/Tx > queues can be really displayed for the PMD driver that implement > .rxq_info_get and .txq_info_get ops callback function. > > Fixes: 75c530c1bd5351 ("app/testpmd: fix port configuration print") > Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ferruh Yigit